Oopsie fixes

Author: bladekt

common/src/main/java/com/lambda/mixin/entity/LivingEntityMixin.java

@@ -45,14 +45,6 @@ void onJump(CallbackInfo ci) {
         self.velocityDirty = true;
     }
 
-    @Inject(method = "tickMovement", at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/LivingEntity;isImmobile()Z"))
-    void onTravelH(CallbackInfo ci) {
-        Entity self = (Entity) (Object) this;
-        if (self != Lambda.getMc().player) return;
-
-        RotationManager.update();
-    }
-
     @Redirect(method = "travel", at = @At(value = "INVOKE", target = "Lnet/minecraft/entity/LivingEntity;getPitch()F"))
     private float hookModifyFallFlyingPitch(LivingEntity entity) {
         Float pitch = RotationManager.getMovementPitch();

common/src/main/kotlin/com/lambda/event/events/RotationEvent.kt

@@ -10,21 +10,24 @@ abstract class RotationEvent : Event {
     /**
      * This event allows listeners to register a rotation request to be executed that tick.
      *
-     * CAUTION: The listener with the lowest priority will win as it is the last to override the context.
+     * Only one rotation can "win" each tick
+     *
+     * CAUTION: The listener with the LOWEST priority will win as it is the last to override the context.
      *
      * @property context The rotation context that listeners can set. Only one rotation can "win" each tick.
      */
-    class Pre : RotationEvent(), ICancellable by Cancellable() {
-        // Only one rotation can "win" each tick
-        var context: RotationContext? = null
-
-        init {
-            // Always check if baritone wants to rotate as well
-            RotationManager.BaritoneProcessor.baritoneContext?.let { context ->
-                this.context = context
-            }
-        }
+    class Update : RotationEvent(), ICancellable by Cancellable() {
+        // Always check if baritone wants to rotate as well
+        var context = RotationManager.BaritoneProcessor.baritoneContext
     }
 
+    /**
+     * This event allows listeners to modify the yaw relative to which the movement input is going to be constructed
+     *
+     * @property strafeYaw The angle at which the player will move when pressing W
+     * Changing this value will never force the anti cheat to flag you because RotationManager is designed to modify the key input instead
+     */
+    class Strafe(var strafeYaw: Double) : RotationEvent()
+
     class Post(val context: RotationContext) : RotationEvent()
 }

common/src/main/kotlin/com/lambda/interaction/RotationManager.kt

@@ -36,16 +36,14 @@ object RotationManager : Loadable {
     private var keepTicks = 0
     private var pauseTicks = 0
 
-    @JvmStatic
-    fun update() =
-        runSafe {
-            RotationEvent.Pre().post {
+    init {
+        listener<TickEvent.Pre> {
+            RotationEvent.Update().post {
                 rotate(context)
                 currentContext?.let { RotationEvent.Post(it).post() }
             }
         }
 
-    init {
         listener<PacketEvent.Send.Post> { event ->
             val packet = event.packet
             if (packet !is PlayerPositionLookS2CPacket) return@listener
@@ -208,7 +206,8 @@ object RotationManager : Loadable {
             val baritoneYaw = if (handledByBaritone) baritoneContext?.rotation?.yaw else null
 
             // The yaw relative to which the movement was constructed
-            val movementYaw = baritoneYaw ?: playerYaw
+            val strafeEvent = RotationEvent.Strafe(baritoneYaw ?: playerYaw)
+            val movementYaw = strafeEvent.post().strafeYaw
 
             // Actual yaw used to move the player
             val actualYaw = currentRotation.yaw

common/src/main/kotlin/com/lambda/module/modules/player/Freecam.kt

@@ -82,7 +82,7 @@ object Freecam : Module(
             mc.options.perspective = lastPerspective
         }
 
-        listener<RotationEvent.Pre>(Int.MAX_VALUE) {
+        listener<RotationEvent.Update>(Int.MAX_VALUE) {
             if (!rotateToTarget) return@listener
             val target = mc.crosshairTarget?.orNull ?: return@listener
 

common/src/main/kotlin/com/lambda/task/tasks/BreakBlock.kt

@@ -51,7 +51,7 @@ class BreakBlock @Ta5kBuilder constructor(
     }
 
     init {
-        listener<RotationEvent.Pre> { event ->
+        listener<RotationEvent.Update> { event ->
             if (!rotate) return@listener
             event.context = lookAtBlock(blockPos, rotationConfig, interactionConfig, sides)
         }

common/src/main/kotlin/com/lambda/task/tasks/OpenContainer.kt

@@ -43,7 +43,7 @@ class OpenContainer<H : ScreenHandler>(
             }
         }
 
-        listener<RotationEvent.Pre> { event ->
+        listener<RotationEvent.Update> { event ->
             if (screenHandler != null) return@listener
             event.context = lookAtBlock(blockPos, rotationConfig, interactionConfig, sides)
         }

common/src/main/kotlin/com/lambda/task/tasks/PlaceBlock.kt

@@ -41,7 +41,7 @@ class PlaceBlock @Ta5kBuilder constructor(
     }
 
     init {
-        listener<RotationEvent.Pre> { event ->
+        listener<RotationEvent.Update> { event ->
             if (!rotate) return@listener
             event.context = ctx.rotation
         }