Skip to content

Commit 003b7f1

Browse files
committed
Update Cloud Build config
1 parent 1b44203 commit 003b7f1

File tree

2 files changed

+7
-21
lines changed

2 files changed

+7
-21
lines changed

Makefile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ DOCKER_PLATFORMS=linux/amd64,linux/arm64
2929
PLATFORMS=$(LINUX_PLATFORMS) windows_amd64
3030

3131
# VERSION is the version of the binary.
32-
VERSION?=$(shell if [ -d .git ]; then echo `git describe --tags --dirty`; else echo "UNKNOWN"; fi)
32+
VERSION?=$(shell git describe --tags --always --dirty)
3333

3434
# TAG is the tag of the container image, default to binary version.
3535
TAG?=$(VERSION)
@@ -275,10 +275,6 @@ build-in-docker: clean docker-builder
275275
-c 'cd /gopath/src/k8s.io/node-problem-detector/ && make build-binaries'
276276

277277
push-container: build-container
278-
# So we can push to docker hub by setting REGISTRY
279-
ifneq (,$(findstring gcr.io,$(REGISTRY)))
280-
gcloud auth configure-docker
281-
endif
282278
# Build should be cached from build-container
283279
docker buildx build --push --platform $(DOCKER_PLATFORMS) -t $(IMAGE) --build-arg LOGCOUNTER=$(LOGCOUNTER) .
284280

cloudbuild.yaml

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,12 @@ timeout: 3600s
55
options:
66
# job builds a multi-arch docker image for amd64 and arm64
77
machineType: E2_HIGHCPU_8
8+
substitution_option: ALLOW_LOOSE
89
steps:
9-
- name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20230623-56e06d7c18'
10-
entrypoint: bash
11-
env:
12-
- PROW_GIT_TAG=$_GIT_TAG
13-
- PULL_BASE_REF=$_PULL_BASE_REF
14-
- VERSION=$_PULL_BASE_REF
15-
- DOCKER_CLI_EXPERIMENTAL=enabled
10+
- name: 'gcr.io/cloud-builders/docker'
11+
entrypoint: make
1612
args:
17-
- -c
18-
- |
19-
echo "Building/Pushing NPD containers"
20-
apk add musl-dev gcc
21-
make push-container
13+
- push-container
2214
substitutions:
23-
# _GIT_TAG will be filled with a git-based tag for the image, of the form vYYYYMMDD-hash, and
24-
# can be used as a substitution
25-
_GIT_TAG: 'PLACE_HOLDER'
26-
_PULL_BASE_REF: 'master'
15+
_GIT_TAG: 'dev'
16+
_PULL_BASE_REF: 'dev'

0 commit comments

Comments
 (0)