Skip to content

Commit b0e5435

Browse files
tookyclaude
andcommitted
fix: address PR review feedback
- Remove duplicate Slice 3 entry in TODO.md - Broaden parent evaluate command description to cover both API-backed trail evaluation and local input evaluation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 29b45a4 commit b0e5435

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

TODO.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,3 @@
4040
- [x] Slice 1: `evaluate input --input-file` with a file path
4141
- [x] Slice 2: stdin support (omit --input-file to read stdin; `-` not supported by cobra)
4242
- [x] Slice 3: help text and examples
43-
- [ ] Slice 3: help text and examples

cmd/kosli/evaluate.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,17 @@ import (
66
"github.com/spf13/cobra"
77
)
88

9-
const evaluateShortDesc = `Evaluate Kosli trail data against OPA/Rego policies.`
9+
const evaluateShortDesc = `Evaluate data against OPA/Rego policies.`
1010

1111
// Backtick breaks (`"` + "`x`" + `"`) are needed to embed markdown
1212
// inline code spans inside raw string literals.
1313
const evaluateLongDesc = evaluateShortDesc + `
14-
Fetch trail data from Kosli and evaluate it against custom policies written
14+
Evaluate trail data or local JSON input against custom policies written
1515
in Rego, the policy language used by Open Policy Agent (OPA).
16+
17+
Use ` + "`evaluate trail`" + ` or ` + "`evaluate trails`" + ` to fetch data from Kosli and evaluate it.
18+
Use ` + "`evaluate input`" + ` to evaluate a local JSON file or stdin without any API calls.
19+
1620
The policy must use ` + "`package policy`" + ` and define an ` + "`allow`" + ` rule.
1721
An optional ` + "`violations`" + ` rule (a set of strings) can provide human-readable denial reasons.
1822
The command exits with code 0 when allowed and code 1 when denied.`

0 commit comments

Comments
 (0)