UNPICK changes to review

Author: kosiew

python/datafusion/context.py

@@ -731,12 +731,11 @@ def from_polars(self, data: pl.DataFrame, name: str | None = None) -> DataFrame:
         """
         return DataFrame(self.ctx.from_polars(data, name))
 
+    # https://github.com/apache/datafusion-python/pull/1016#discussion_r1983239116
+    # is the discussion on how we arrived at adding register_view
     def register_view(self, name: str, df: DataFrame) -> None:
         """Register a :py:class: `~datafusion.detaframe.DataFrame` as a view.
 
-        The DataFrame is converted into a view before registration so it can be
-        referenced from SQL without materializing results immediately.
-
         Args:
             name (str): The name to register the view under.
             df (DataFrame): The DataFrame to be converted into a view and registered.

src/catalog.rs

@@ -496,6 +496,8 @@ impl CatalogProvider for RustWrappedPyCatalogProvider {
         name: &str,
         schema: Arc<dyn SchemaProvider>,
     ) -> datafusion::common::Result<Option<Arc<dyn SchemaProvider>>> {
+        // JRIGHT HERE
+        // let py_schema: PySchema = schema.into();
         Python::with_gil(|py| {
             let py_schema = match schema
                 .as_any()

src/dataframe.rs

@@ -430,7 +430,11 @@ impl PyDataFrame {
 
     /// Convert this DataFrame into a Table that can be used in register_table
     /// By convention, into_... methods consume self and return the new object.
-    /// Here we intentionally borrow to avoid invalidating the Python wrapper.
+    /// Disabling the clippy lint, so we can use &self
+    /// because we're working with Python bindings
+    /// where objects are shared
+    /// https://github.com/apache/datafusion-python/pull/1016#discussion_r1983239116
+    /// - we have not decided on the table_provider approach yet
     #[allow(clippy::wrong_self_convention)]
     fn into_view(&self) -> PyDataFusionResult<PyTable> {
         // Call the underlying Rust DataFrame::into_view method.