Skip to content

Commit 82cf803

Browse files
committed
doc: clarify borrowing rationale in into_view method for Python bindings
1 parent 0821679 commit 82cf803

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/dataframe.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -430,11 +430,7 @@ impl PyDataFrame {
430430

431431
/// Convert this DataFrame into a Table that can be used in register_table
432432
/// By convention, into_... methods consume self and return the new object.
433-
/// Disabling the clippy lint, so we can use &self
434-
/// because we're working with Python bindings
435-
/// where objects are shared
436-
/// https://github.com/apache/datafusion-python/pull/1016#discussion_r1983239116
437-
/// - we have not decided on the table_provider approach yet
433+
/// Here we intentionally borrow to avoid invalidating the Python wrapper.
438434
#[allow(clippy::wrong_self_convention)]
439435
fn into_view(&self) -> PyDataFusionResult<PyTable> {
440436
// Call the underlying Rust DataFrame::into_view method.

0 commit comments

Comments
 (0)