fix(json-api-nestjs): fix check if field exist and camelcase transform

Author: Alexander Kharkovey

libs/json-api-nestjs/src/lib/helper/utils/index.spec.ts

@@ -19,9 +19,11 @@ describe('Test utils', () => {
     const result = snakeToCamel('test_test');
     const result1 = snakeToCamel('test-test');
     const result2 = snakeToCamel('testTest');
+    const result3 = snakeToCamel('event_incident_typeFK');
     expect(result).toBe('testTest');
     expect(result1).toBe('testTest');
     expect(result2).toBe('testTest');
+    expect(result3).toBe('eventIncidentTypeFK');
   });
 
   it('isString', () => {

libs/json-api-nestjs/src/lib/helper/utils/index.ts

@@ -35,11 +35,9 @@ export function snakeToCamel(str: string): string {
   if (!str.match(/[\s_-]/g)) {
     return str;
   }
-  return str
-    .toLowerCase()
-    .replace(/([-_][a-z])/g, (group) =>
-      group.toUpperCase().replace('-', '').replace('_', '')
-    );
+  return str.replace(/([-_][a-z])/g, (group) =>
+    group.toUpperCase().replace('-', '').replace('_', '')
+  );
 }
 
 export function camelToKebab(str: string): string {

libs/json-api-nestjs/src/lib/mixin/service/transform/transform.mixin.ts

@@ -122,7 +122,7 @@ export class TransformMixinService<T> {
           this.commonColumnsForRelation.has(tableName) &&
           this.commonColumnsForRelation.get(tableName).has(fieldName)
         ) {
-          if (!currentItem[field]) {
+          if (!(field in currentItem)) {
             continue;
           }
           relationObject[tableName] = relationObject[tableName] || {};
@@ -181,6 +181,7 @@ export class TransformMixinService<T> {
         const propsData = data[field];
         const typeName = getEntityName(this.relationTarget.get(field));
         if (Array.isArray(propsData)) {
+          console.log(propsData, this.relationPrimaryField.get(field));
           builtData.data = propsData.map((i) => ({
             type: camelToKebab(typeName),
             id: i[this.relationPrimaryField.get(field)].toString(),

libs/json-api-nestjs/src/lib/mixin/service/typeorm/methods/get-one/get-one.spec.ts

@@ -3,7 +3,12 @@ import { getDataSourceToken, getRepositoryToken } from '@nestjs/typeorm';
 import { BadRequestException, NotFoundException } from '@nestjs/common';
 
 import { TypeormMixinService } from '../../typeorm.mixin';
-import { mockDBTestModule, Users, Addresses } from '../../../../../mock-utils';
+import {
+  mockDBTestModule,
+  Users,
+  Addresses,
+  Roles,
+} from '../../../../../mock-utils';
 import { ConfigParam, QueryField, QueryParams } from '../../../../../types';
 import { DataSource, Repository } from 'typeorm';
 import {
@@ -84,11 +89,19 @@ describe('GetOne methode test', () => {
       })
     );
 
+    const roles = await repository.manager.getRepository(Roles).save(
+      Object.assign(new Roles(), {
+        name: 'test',
+        key: 'test',
+      })
+    );
+    console.log(roles);
     const user = {
       login: 'login',
       lastName: 'lastName',
       isActive: true,
       addresses: addresses,
+      roles: [roles],
     };
     await repository.save(Object.assign(new Users(), user));
   });