Merge pull request #39 from ringcentral/fix-test-and-release

Fix test and release

Author: klerick

libs/json-api/src/lib/mixins/pipes/query-need-attribute/query-need-attribute.ts

@@ -1,4 +1,5 @@
-import { Entity, mixin, PipeTransformMixin } from 'json-api-nestjs';
+import { mixin } from '../../../helpers/mixin';
+import { Entity, PipeTransformMixin } from '../../../types';
 import { Injectable, PipeTransform } from '@nestjs/common';
 
 export function queryNeedAttributeMixin(entity: Entity): PipeTransformMixin {

libs/json-api/src/lib/mixins/service/service.mixin.ts

@@ -35,7 +35,7 @@ export function serviceMixin(entity: Entity, transform: TransformMixin, connecti
     public async getRelationship(options: ServiceOptions<void>): Promise<ResponseRelationshipsObject> {
       const mainResourceName = paramCase(this.repository.metadata.name);
       const { relName, id } = options.route;
-      const { needAttribute } = options.query;
+      const { needAttribute } = (options.query || {needAttribute: false});
       const returnAttr: {[key: string]: Record<string, any>} = {};
       const result = await this.repository
         .createQueryBuilder(mainResourceName)
@@ -477,7 +477,7 @@ export function serviceMixin(entity: Entity, transform: TransformMixin, connecti
 
         await builderDeleteRelationships.addAndRemove(idsToAdd, idsToDelete);
 
-        if (relationObject.relationType === 'many-to-many') {
+        if (relationObject.relationType === 'many-to-many' && (body as BaseData[]).some(i => i.attributes)) {
           const repoTarget = this.repository.manager.getRepository<EntitySchema>(relationObject.junctionEntityMetadata.target);
           const currentData = await repoTarget.find({
             where: {
@@ -590,7 +590,7 @@ export function serviceMixin(entity: Entity, transform: TransformMixin, connecti
         const { id } = Array.isArray(body) ? body.shift() : body;
         await postBuilder.set(id);
       }
-      if (relations.relationType === 'many-to-many') {
+      if (relations.relationType === 'many-to-many' && (body as BaseData[]).some(item => item.attributes)) {
         const repoTarget = this.repository.manager.getRepository<EntitySchema>(relations.junctionEntityMetadata.target);
         const currentData = await repoTarget.find({
           where: {