Fix Qt bootstrap handling of non-back key events#3343
Open
lazycat11 wants to merge 1 commit into
Open
Conversation
kuzeyron
reviewed
Jun 7, 2026
| public boolean onKeyDown(int keyCode, KeyEvent event) { | ||
| // If it wasn't the Back key or there's no web page history, bubble up to the default | ||
| // system behavior (probably exit the activity) | ||
| if (keyCode != KeyEvent.KEYCODE_BACK) { |
Contributor
There was a problem hiding this comment.
This seems not to be the best approach as it's colliding with the rest of its code and its purpose. Instead of doing this you should try another approach from the app itself on how it handles the back key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super.onKeyDownTesting
git diff --checkUnit tests & build appsrun 26929233140 completed successfully, including Flake8, Java Spotless, pytest matrix, recipe tests, emulator run, and Qt app build