Automatically set rule ID to filename if not in frontmatter

- Modified rule loading to auto-set ID from filename (without extension)
- Simplified MCPServers() since ID is now always set
- Updated tests to reflect auto-generated IDs
- Added integration test to verify ID auto-generation behavior

Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>

Author: Copilot

pkg/codingcontext/context.go

@@ -516,6 +516,13 @@ func (cc *Context) findExecuteRuleFiles(ctx context.Context, homeDir string) err
 			return fmt.Errorf("failed to parse markdown file %s: %w", path, err)
 		}
 
+		// Automatically set ID to filename (without extension) if not set in frontmatter
+		if frontmatter.ID == "" {
+			baseName := filepath.Base(path)
+			ext := filepath.Ext(baseName)
+			frontmatter.ID = strings.TrimSuffix(baseName, ext)
+		}
+
 		// Expand parameters only if expand is not explicitly set to false
 		var processedContent string
 		if shouldExpandParams(frontmatter.ExpandParams) {

pkg/codingcontext/context_test.go

@@ -699,6 +699,46 @@ func TestContext_Run_Rules(t *testing.T) {
 				}
 			},
 		},
+		{
+			name: "rule IDs automatically set from filename",
+			setup: func(t *testing.T, dir string) {
+				createTask(t, dir, "id-task", "", "Task")
+				createRule(t, dir, ".agents/rules/my-rule.md", "", "Rule without ID in frontmatter")
+				createRule(t, dir, ".agents/rules/another-rule.md", "id: explicit-id", "Rule with explicit ID")
+			},
+			taskName: "id-task",
+			wantErr:  false,
+			check: func(t *testing.T, result *Result) {
+				if len(result.Rules) != 2 {
+					t.Fatalf("expected 2 rules, got %d", len(result.Rules))
+				}
+
+				// Check that one rule has auto-generated ID from filename
+				foundMyRule := false
+				foundAnotherRule := false
+				for _, rule := range result.Rules {
+					if rule.FrontMatter.ID == "my-rule" {
+						foundMyRule = true
+						if !strings.Contains(rule.Content, "Rule without ID") {
+							t.Error("my-rule should contain 'Rule without ID'")
+						}
+					}
+					if rule.FrontMatter.ID == "explicit-id" {
+						foundAnotherRule = true
+						if !strings.Contains(rule.Content, "Rule with explicit ID") {
+							t.Error("explicit-id should contain 'Rule with explicit ID'")
+						}
+					}
+				}
+
+				if !foundMyRule {
+					t.Error("expected to find rule with auto-generated ID 'my-rule'")
+				}
+				if !foundAnotherRule {
+					t.Error("expected to find rule with explicit ID 'explicit-id'")
+				}
+			},
+		},
 	}
 
 	for _, tt := range tests {

pkg/codingcontext/result.go

@@ -1,8 +1,6 @@
 package codingcontext
 
 import (
-	"fmt"
-
 	"github.com/kitproj/coding-context-cli/pkg/codingcontext/markdown"
 	"github.com/kitproj/coding-context-cli/pkg/codingcontext/mcp"
 	"github.com/kitproj/coding-context-cli/pkg/codingcontext/skills"
@@ -22,21 +20,17 @@ type Result struct {
 // Each rule can specify one MCP server configuration.
 // Returns a map from rule ID to MCP server configuration.
 // Empty/zero-value MCP server configurations are filtered out.
-// Rules without an ID field are included with a generated key "rule-<index>".
+// The rule ID is automatically set to the filename (without extension) if not
+// explicitly provided in the frontmatter.
 func (r *Result) MCPServers() map[string]mcp.MCPServerConfig {
 	servers := make(map[string]mcp.MCPServerConfig)
 
 	// Add server from each rule, filtering out empty configs
-	for i, rule := range r.Rules {
+	for _, rule := range r.Rules {
 		server := rule.FrontMatter.MCPServer
 		// Skip empty MCP server configs (no command and no URL means empty)
 		if server.Command != "" || server.URL != "" {
-			// Use the rule's ID as the key, or generate one if not present
-			key := rule.FrontMatter.ID
-			if key == "" {
-				key = fmt.Sprintf("rule-%d", i)
-			}
-			servers[key] = server
+			servers[rule.FrontMatter.ID] = server
 		}
 	}
 

pkg/codingcontext/result_test.go

@@ -111,16 +111,18 @@ func TestResult_MCPServers(t *testing.T) {
 			},
 		},
 		{
-			name: "MCP servers from rules without IDs",
+			name: "MCP servers from rules without explicit IDs in frontmatter",
 			result: Result{
 				Rules: []markdown.Markdown[markdown.RuleFrontMatter]{
 					{
 						FrontMatter: markdown.RuleFrontMatter{
+							ID:        "rule-file-1", // ID is auto-set to filename during loading
 							MCPServer: mcp.MCPServerConfig{Type: mcp.TransportTypeStdio, Command: "server1"},
 						},
 					},
 					{
 						FrontMatter: markdown.RuleFrontMatter{
+							ID:        "rule-file-2", // ID is auto-set to filename during loading
 							MCPServer: mcp.MCPServerConfig{Type: mcp.TransportTypeStdio, Command: "server2"},
 						},
 					},
@@ -130,8 +132,8 @@ func TestResult_MCPServers(t *testing.T) {
 				},
 			},
 			want: map[string]mcp.MCPServerConfig{
-				"rule-0": {Type: mcp.TransportTypeStdio, Command: "server1"},
-				"rule-1": {Type: mcp.TransportTypeStdio, Command: "server2"},
+				"rule-file-1": {Type: mcp.TransportTypeStdio, Command: "server1"},
+				"rule-file-2": {Type: mcp.TransportTypeStdio, Command: "server2"},
 			},
 		},
 		{
@@ -185,23 +187,24 @@ func TestResult_MCPServers(t *testing.T) {
 			},
 		},
 		{
-			name: "mixed rules with and without IDs",
+			name: "mixed rules with explicit and auto-generated IDs",
 			result: Result{
 				Rules: []markdown.Markdown[markdown.RuleFrontMatter]{
 					{
 						FrontMatter: markdown.RuleFrontMatter{
-							ID:        "explicit-id",
+							ID:        "explicit-id", // Explicit ID in frontmatter
 							MCPServer: mcp.MCPServerConfig{Type: mcp.TransportTypeStdio, Command: "server1"},
 						},
 					},
 					{
 						FrontMatter: markdown.RuleFrontMatter{
+							ID:        "some-rule", // ID auto-set to filename during loading
 							MCPServer: mcp.MCPServerConfig{Type: mcp.TransportTypeStdio, Command: "server2"},
 						},
 					},
 					{
 						FrontMatter: markdown.RuleFrontMatter{
-							ID:        "another-id",
+							ID:        "another-id", // Explicit ID in frontmatter
 							MCPServer: mcp.MCPServerConfig{Type: mcp.TransportTypeHTTP, URL: "https://example.com"},
 						},
 					},
@@ -212,7 +215,7 @@ func TestResult_MCPServers(t *testing.T) {
 			},
 			want: map[string]mcp.MCPServerConfig{
 				"explicit-id": {Type: mcp.TransportTypeStdio, Command: "server1"},
-				"rule-1":      {Type: mcp.TransportTypeStdio, Command: "server2"},
+				"some-rule":   {Type: mcp.TransportTypeStdio, Command: "server2"},
 				"another-id":  {Type: mcp.TransportTypeHTTP, URL: "https://example.com"},
 			},
 		},