From 12a7f0957cca7c06653e5e5da073b86e56fcb90b Mon Sep 17 00:00:00 2001 From: CarlosGamero Date: Thu, 19 Feb 2026 13:30:05 +0100 Subject: [PATCH 1/8] Trigger CI --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 13690df4..3298b417 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,9 @@ Useful utilities, interfaces and base classes for message queue handling. ## Overview -`message-queue-toolkit ` is an abstraction over several different queue systems, which implements common deserialization, validation and error handling logic. The library provides utilities, interfaces and base classes to build the support for any queue system you may need in your service. +`message-queue-toolkit ` is an abstraction over several different queue systems, which implements common deserialization, +validation and error handling logic. The library provides utilities, interfaces and base classes to build the support for +any queue system you may need in your service. It consists of the following submodules: From 31c73a9cf074c60ccd2ca31805da5c499eabed1c Mon Sep 17 00:00:00 2001 From: CarlosGamero Date: Thu, 19 Feb 2026 14:48:55 +0100 Subject: [PATCH 2/8] Fixing tests --- packages/kafka/lib/AbstractKafkaConsumer.ts | 16 ++++++++++++---- .../kafka/test/consumer/PermissionConsumer.ts | 1 + 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/packages/kafka/lib/AbstractKafkaConsumer.ts b/packages/kafka/lib/AbstractKafkaConsumer.ts index cc69a009..c7ba0fc0 100644 --- a/packages/kafka/lib/AbstractKafkaConsumer.ts +++ b/packages/kafka/lib/AbstractKafkaConsumer.ts @@ -217,11 +217,19 @@ export abstract class AbstractKafkaConsumer< stream: MessagesStream, ): Promise { for await (const message of stream) { - await this.consume( - message.topic, - message as DeserializedMessage>, - ) + try { + await this.consume( + message.topic, + message as DeserializedMessage>, + ) + } catch (e) { + console.log(e) + } } + //stream.on('data', (message) => { + // console.log(message) + //}) + //return } async close(): Promise { diff --git a/packages/kafka/test/consumer/PermissionConsumer.ts b/packages/kafka/test/consumer/PermissionConsumer.ts index aa040e54..b5ef9f4f 100644 --- a/packages/kafka/test/consumer/PermissionConsumer.ts +++ b/packages/kafka/test/consumer/PermissionConsumer.ts @@ -75,6 +75,7 @@ export class PermissionConsumer extends AbstractKafkaConsumer< handlerSpy: options.handlerSpy ?? true, headerRequestIdField: options.headerRequestIdField, messageIdField: options.messageIdField, + maxWaitTime: 5, }, { incrementAmount: 0, From 8d9df0b81c1cfe71481f595c92f06da110b89388 Mon Sep 17 00:00:00 2001 From: CarlosGamero Date: Thu, 19 Feb 2026 14:55:47 +0100 Subject: [PATCH 3/8] version bump --- packages/kafka/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kafka/package.json b/packages/kafka/package.json index 64df6fb3..dd1ddcc4 100644 --- a/packages/kafka/package.json +++ b/packages/kafka/package.json @@ -53,7 +53,7 @@ "dependencies": { "@lokalise/node-core": "^14.2.0", "@lokalise/universal-ts-utils": "^4.5.1", - "@platformatic/kafka": "^1.23.0" + "@platformatic/kafka": "^1.26.0" }, "peerDependencies": { "@message-queue-toolkit/core": ">=23.0.0", From b56a51254beb1174519950028fc159e2482dc69e Mon Sep 17 00:00:00 2001 From: CarlosGamero Date: Thu, 19 Feb 2026 15:04:11 +0100 Subject: [PATCH 4/8] test concurrency --- packages/kafka/vitest.config.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/kafka/vitest.config.ts b/packages/kafka/vitest.config.ts index 10d14e3c..7e799f72 100644 --- a/packages/kafka/vitest.config.ts +++ b/packages/kafka/vitest.config.ts @@ -6,6 +6,7 @@ export default defineConfig({ globals: true, watch: false, mockReset: true, + maxConcurrency: 1, pool: 'threads', maxWorkers: 1, coverage: { From 812d706d51857b66c4c1282277de62a64f59c8fc Mon Sep 17 00:00:00 2001 From: CarlosGamero Date: Thu, 19 Feb 2026 15:08:18 +0100 Subject: [PATCH 5/8] Revert concurrency --- packages/kafka/test/utils/testContext.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/kafka/test/utils/testContext.ts b/packages/kafka/test/utils/testContext.ts index 44e48c1a..c8576817 100644 --- a/packages/kafka/test/utils/testContext.ts +++ b/packages/kafka/test/utils/testContext.ts @@ -6,7 +6,7 @@ import { type TransactionObservabilityManager, } from '@lokalise/node-core' import type { MessageMetricsManager } from '@message-queue-toolkit/core' -import { adminClient } from '@platformatic/kafka' +import { Admin } from '@platformatic/kafka' import { type AwilixContainer, asFunction, @@ -26,7 +26,7 @@ export type TestContext = AwilixContainer type Dependencies = { awilixManager: AwilixManager kafkaConfig: KafkaConfig - kafkaAdmin: adminClient.Admin + kafkaAdmin: Admin errorReporter: ErrorReporter logger: CommonLogger transactionObservabilityManager: TransactionObservabilityManager @@ -60,7 +60,7 @@ const resolveDIConfig = (awilixManager: AwilixManager): DiConfig => ({ kafkaConfig: asFunction(getKafkaConfig, SINGLETON_CONFIG), kafkaAdmin: asFunction( ({ kafkaConfig }) => - new adminClient.Admin({ + new Admin({ clientId: randomUUID(), bootstrapBrokers: kafkaConfig.bootstrapBrokers, }), From 4b269ea78b534a382b8f0ed59d4d6369f1965109 Mon Sep 17 00:00:00 2001 From: CarlosGamero Date: Thu, 19 Feb 2026 15:08:30 +0100 Subject: [PATCH 6/8] Fix tests --- packages/kafka/vitest.config.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/kafka/vitest.config.ts b/packages/kafka/vitest.config.ts index 7e799f72..10d14e3c 100644 --- a/packages/kafka/vitest.config.ts +++ b/packages/kafka/vitest.config.ts @@ -6,7 +6,6 @@ export default defineConfig({ globals: true, watch: false, mockReset: true, - maxConcurrency: 1, pool: 'threads', maxWorkers: 1, coverage: { From 8ced1968a1c6a8e05d2f8f1838c716af76cbaa96 Mon Sep 17 00:00:00 2001 From: CarlosGamero Date: Thu, 19 Feb 2026 15:18:05 +0100 Subject: [PATCH 7/8] Coverage fix --- packages/kafka/vitest.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kafka/vitest.config.ts b/packages/kafka/vitest.config.ts index 10d14e3c..00c6ebbb 100644 --- a/packages/kafka/vitest.config.ts +++ b/packages/kafka/vitest.config.ts @@ -16,7 +16,7 @@ export default defineConfig({ lines: 93, functions: 91, branches: 85, - statements: 93, + statements: 92, }, }, }, From c4b5dbe1d35882b88e49d8e68bbac8917e520edd Mon Sep 17 00:00:00 2001 From: CarlosGamero Date: Thu, 19 Feb 2026 15:21:53 +0100 Subject: [PATCH 8/8] Revert wrong change --- packages/kafka/lib/AbstractKafkaConsumer.ts | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/packages/kafka/lib/AbstractKafkaConsumer.ts b/packages/kafka/lib/AbstractKafkaConsumer.ts index 519fd2b9..c632669a 100644 --- a/packages/kafka/lib/AbstractKafkaConsumer.ts +++ b/packages/kafka/lib/AbstractKafkaConsumer.ts @@ -217,19 +217,11 @@ export abstract class AbstractKafkaConsumer< stream: MessagesStream, ): Promise { for await (const message of stream) { - try { - await this.consume( - message.topic, - message as DeserializedMessage>, - ) - } catch (e) { - console.log(e) - } + await this.consume( + message.topic, + message as DeserializedMessage>, + ) } - //stream.on('data', (message) => { - // console.log(message) - //}) - //return } async close(): Promise {