chore: add PR template enforcing tenet citation + Foundry compatibility + mockup fields#51
Merged
Merged
Conversation
…ty + mockup fields
Lands mechanism M-O5.1 (tenet citation field on every PR) on the
chronicle-foundry-module side. Mirrors the Chronicle PR template
(chronicle#328) with Foundry-specific tweaks: Foundry version
compatibility field, Foundry-runtime test-plan checkbox, T-B2
plugin-isolation self-check phrased from the consumer side ("this module
IS the foundry-vtt plugin half").
Convention-only enforcement; a contributor can blank-fill fields. CI-side
validation of required fields is future M-O5.1 work.
Cites: 2026-05-21-core-tenets §T-O5 (lands M-O5.1)
2026-05-21-core-tenets §T-B1 §T-B3 §T-O2 (referenced from the template's self-check)
2026-05-19-dispatch-workflow.md §amendment-2026-05-21
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cites: 2026-05-21-core-tenets §T-O5 (lands mechanism M-O5.1); §T-B1, §T-B3, §T-O2 (referenced from the template's self-check); 2026-05-19-dispatch-workflow.md §amendment-2026-05-21; dispatches/foundry/FM-PR-TEMPLATE.md
Security implication: none — pure convention; the template is markdown-only with no runtime effect
Consumer-verified: n/a — no wire surface
Foundry compatibility: n/a — not Foundry-runtime-touching (docs file)
Mockup: n/a — no UI change
What this changes
Adds
.github/pull_request_template.mdto chronicle-foundry-module so every PR opened against this repo surfaces the binding tenets, security implication, Foundry version compatibility, and mockup status up front. Mirrors the Chronicle PR template (chronicle#328) with Foundry-specific tweaks. This PR's own description follows the template format (self-demonstrating).Why
Lands mechanism M-O5.1 (
decisions/2026-05-21-core-tenets.md §3) — the convention-side enforcement of T-O5 tenet citation discipline. Without a template the citation field is easy to forget; with the template the field is friction-bearing to omit.The Foundry-specific variations over chronicle#328:
_parsePartHTMLbehavior.foundry-vttliterals outside the owning plugin).Test plan
node --test tools/test-*.mjspasses locally (250/250)node tools/check-package-descriptor.mjspasses (descriptor unchanged but ran for hygiene).github/pull_request_template.md.github/markdown)Tenet self-check
Stop-and-flag
None encountered during execution.
Status report at
cordinator/reports/foundry/2026-05-22-fm-pr-template.md(separate commit onclaude/setup-working-memory-vROh3).🤖 Cites
dispatches/foundry/FM-PR-TEMPLATE.md. Generated by Claude Code.Generated by Claude Code