Use lightweight fixtures for standby compression tests

Author: sjmiller609

lib/instances/snapshot_compression_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/kernel/hypeman/lib/hypervisor"
+	"github.com/kernel/hypeman/lib/paths"
 	snapshotstore "github.com/kernel/hypeman/lib/snapshot"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -405,10 +406,22 @@ func assertCompressionJobCanceled(t *testing.T, mgr *manager, target *compressio
 	}, time.Second, 10*time.Millisecond)
 }
 
+func newSnapshotCompressionTestManager(t *testing.T) *manager {
+	t.Helper()
+
+	p := paths.New(t.TempDir())
+	return &manager{
+		paths:            p,
+		now:              time.Now,
+		compressionJobs:  make(map[string]*compressionJob),
+		stateSubscribers: newSubscribers(),
+	}
+}
+
 func TestStartCompressionJobDelayedCancellationRecordsSkipped(t *testing.T) {
 	t.Parallel()
 
-	mgr, _ := setupTestManager(t)
+	mgr := newSnapshotCompressionTestManager(t)
 	delay := 45 * time.Second
 	timer := newFakeCompressionTimer()
 	mgr.compressionTimerFactory = func(got time.Duration) compressionTimer {
@@ -455,7 +468,9 @@ func TestStartCompressionJobDelayedCancellationRecordsSkipped(t *testing.T) {
 }
 
 func TestRecoverPendingStandbyCompressionJobsRequeuesDelayedJob(t *testing.T) {
-	mgr, _ := setupTestManager(t)
+	t.Parallel()
+
+	mgr := newSnapshotCompressionTestManager(t)
 	now := time.Date(2026, time.April, 6, 12, 0, 0, 0, time.UTC)
 	mgr.now = func() time.Time { return now }
 
@@ -519,7 +534,9 @@ func TestRecoverPendingStandbyCompressionJobsRequeuesDelayedJob(t *testing.T) {
 }
 
 func TestRecoverPendingStandbyCompressionJobsStartsImmediateCompression(t *testing.T) {
-	mgr, _ := setupTestManager(t)
+	t.Parallel()
+
+	mgr := newSnapshotCompressionTestManager(t)
 	now := time.Date(2026, time.April, 6, 12, 5, 0, 0, time.UTC)
 	mgr.now = func() time.Time { return now }
 
@@ -565,6 +582,8 @@ func TestRecoverPendingStandbyCompressionJobsStartsImmediateCompression(t *testi
 }
 
 func TestRecoverPendingStandbyCompressionJobsClearsStalePlans(t *testing.T) {
+	t.Parallel()
+
 	tests := []struct {
 		name    string
 		prepare func(t *testing.T, mgr *manager, instanceID string, now time.Time)
@@ -622,7 +641,9 @@ func TestRecoverPendingStandbyCompressionJobsClearsStalePlans(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			mgr, _ := setupTestManager(t)
+			t.Parallel()
+
+			mgr := newSnapshotCompressionTestManager(t)
 			now := time.Date(2026, time.April, 6, 12, 10, 0, 0, time.UTC)
 			mgr.now = func() time.Time { return now }
 			instanceID := "recover-stale-" + tt.name

skills/test-agent/agents/test-agent/NOTES.md

@@ -218,6 +218,47 @@
 - `TestVolumeMultiAttachReadOnly`
   - `exec-agent not ready for instance ... within 15s (last state: Initializing)`
 - `TestVolumeFromArchive`
+
+## 2026-04-06 - PR #184 standby compression delay branch (`codex/standby-compression-delay`)
+
+### CI red signature
+- Linux `test` job on PR [#184](https://github.com/kernel/hypeman/pull/184) failed while the other checks passed.
+- Observed failures from the GitHub Actions log:
+  - `TestQEMUStandbyRestoreCompressionScenarios`
+  - `TestQEMUStandbyAndRestore`
+  - `TestBasicEndToEnd`
+  - `TestForkCloudHypervisorFromRunningNetwork`
+- Failure shapes were integration stalls, not deterministic assertion failures:
+  - `instance ... did not reach Running within 20s (last state: Initializing)`
+  - `rpc error: code = DeadlineExceeded desc = stream terminated by RST_STREAM with error code: CANCEL`
+
+### Investigation
+- Initial stopgap of removing `t.Parallel()` from the new restart-recovery tests was rejected; that was the wrong direction and was not kept.
+- Reproduced the branch on `deft-kernel-dev` using the CI-like Linux/root flow with correct prewarm env:
+  - `go mod download`
+  - `make oapi-generate`
+  - `make build`
+  - `go run ./cmd/test-prewarm`
+  - `sudo env ... go test -count=1 -tags containers_image_openpgp -timeout=20m ./...`
+- Tight loop on the exact CI-failing tests did not reproduce a flake once the command shape matched CI and prewarm settings were correct.
+
+### Root cause and fix
+- The new standby compression recovery tests were unit-style tests but used `setupTestManager`, which pulls in much heavier integration-style manager setup than needed.
+- That extra setup was unnecessary for these tests and added avoidable load to an already heavy `lib/instances` package.
+- Fix:
+  - Added a lightweight `newSnapshotCompressionTestManager` helper in `lib/instances/snapshot_compression_test.go`
+  - Moved the new delayed-job and restart-recovery tests to that lightweight fixture
+  - Restored `t.Parallel()` on the new recovery tests and subtests
+- This keeps coverage and parallelism intact while removing needless setup cost.
+
+### Validation
+- Targeted stress loop after the fixture change:
+  - `go test -count=20 -run '^(TestRecoverPendingStandbyCompressionJobs|TestStartCompressionJobDelayedCancellationRecordsSkipped)$' ./lib/instances`
+  - Result: pass
+- Deft full fresh-cache CI-like runs after the fix:
+  - Run 1: pass (`lib/instances` 193.279s)
+  - Run 2: pass (`lib/instances` 261.633s)
+  - Run 3: pass (`lib/instances` 173.573s)
   - `exec-agent not ready for instance ... within 15s (last state: Initializing)`
 
 ### Additional flakes reproduced during Deft full-suite verification