kcd-scripts version: 11.2.0node version: anynpm (or yarn) version: any
Relevant code or config
https://github.com/testing-library/user-event/pull/706/files#diff-79de2fcdb58def5d2000c20beddc4bb5a30488589e20c207181967dd0e75aa72R28
What you did:
Run CI with "kcd-scripts": "^11.1.0".
What happened:
After release of v11.2.0 CI fails due to uncovered lines.
Turns out istanbul expects the /* istanbul ignore else */ right in between else if now.
The pre-commit hook reverts the change and therefore commits fixing this have to be committed with --no-verify.
Reproduction repository:
testing-library/user-event#706
Problem description:
kcd-scripts lint does not flag /* istanbul ignore else */ else if.
kcd-scripts/husky adds a pre-commit hook that changes the (now) correct else /* istanbul ignore else */ if back to /* istanbul ignore else */ else if.
Suggested solution:
Report a lint error for /* istanbul ignore else */ else if.
Lint-fix to else /* istanbul ignore else */ if.
kcd-scriptsversion: 11.2.0nodeversion: anynpm(oryarn) version: anyRelevant code or config
https://github.com/testing-library/user-event/pull/706/files#diff-79de2fcdb58def5d2000c20beddc4bb5a30488589e20c207181967dd0e75aa72R28
What you did:
Run CI with
"kcd-scripts": "^11.1.0".What happened:
After release of
v11.2.0CI fails due to uncovered lines.Turns out istanbul expects the
/* istanbul ignore else */right in betweenelse ifnow.The pre-commit hook reverts the change and therefore commits fixing this have to be committed with
--no-verify.Reproduction repository:
testing-library/user-event#706
Problem description:
kcd-scripts lintdoes not flag/* istanbul ignore else */ else if.kcd-scripts/huskyadds a pre-commit hook that changes the (now) correctelse /* istanbul ignore else */ ifback to/* istanbul ignore else */ else if.Suggested solution:
Report a lint error for
/* istanbul ignore else */ else if.Lint-fix to
else /* istanbul ignore else */ if.