Skip to content

Commit f07bcae

Browse files
committed
Remove trash
1 parent 2a8230a commit f07bcae

File tree

4 files changed

+3
-97
lines changed

4 files changed

+3
-97
lines changed

core/src/main/java/io/grpc/internal/CallExecutors.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ private CallExecutors() {}
3131
* Wraps an executor with safeguarding (serialization) if not already safeguarded.
3232
*/
3333
static Executor safeguard(Executor executor) {
34+
// If we know that the executor is a direct executor, we don't need to wrap it with a
35+
// SerializingExecutor. This is purely for performance reasons.
36+
// See https://github.com/grpc/grpc-java/issues/368
3437
if (executor instanceof SerializingExecutor
3538
|| executor instanceof SerializeReentrantCallsDirectExecutor) {
3639
return executor;

core/src/main/java/io/grpc/internal/ClientCallImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,6 @@ final class ClientCallImpl<ReqT, RespT> extends ClientCall<ReqT, RespT> {
104104
this.method = method;
105105
// TODO(carl-mastrangelo): consider moving this construction to ManagedChannelImpl.
106106
this.tag = PerfMark.createTag(method.getFullMethodName(), System.identityHashCode(this));
107-
// If we know that the executor is a direct executor, we don't need to wrap it with a
108-
// SerializingExecutor. This is purely for performance reasons.
109-
// See https://github.com/grpc/grpc-java/issues/368
110107
this.callExecutor = CallExecutors.safeguard(executor);
111108
callExecutorIsDirect = (this.callExecutor instanceof SerializeReentrantCallsDirectExecutor);
112109
this.channelCallsTracer = channelCallsTracer;

examples/example-xds/xds-client.Dockerfile

Lines changed: 0 additions & 47 deletions
This file was deleted.

examples/example-xds/xds-server.Dockerfile

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)