trigger GHA

Author: root

.github/workflows/tests.yml

@@ -49,17 +49,19 @@ jobs:
         if: runner.os == 'Linux'
         run: |
           sudo apt-get update
-          sudo apt-get install -y cppcheck
+          sudo apt-get install -y cppcheck clang-format
 
       - name: Install system dependencies (macOS)
         if: runner.os == 'macOS'
         run: |
           brew install cppcheck
+          brew install clang-format
 
       - name: Install system dependencies (Windows)
         if: runner.os == 'Windows'
         run: |
           choco install cppcheck
+          choco install llvm --yes # This includes clang-format
 
       - name: Cache $HOME/.local # Significantly speeds up Poetry Install
         uses: actions/cache@v4

newtype/extensions/newtype_init.c

@@ -206,7 +206,7 @@ static void NewTypeInit_dealloc(NewTypeInitObject* self)
 static PyMethodDef NewTypeInit_methods[] = {{NULL, NULL, 0, NULL}};
 
 static PyTypeObject NewTypeInitType = {
-    PyVarObject_HEAD_INIT(NULL, 0).tp_name = "NewTypeInit.NewTypeInit",
+    PyVarObject_HEAD_INIT(NULL, 0).tp_name = "newtypeinit.NewTypeInit",
     .tp_doc = "Descriptor class that wraps methods for instantiating subtypes.",
     .tp_basicsize = sizeof(NewTypeInitObject),
     .tp_itemsize = 0,
@@ -223,18 +223,18 @@ static PyTypeObject NewTypeInitType = {
 
 static struct PyModuleDef NewTypeInitmodule = {
     PyModuleDef_HEAD_INIT,
-    .m_name = "NewTypeInit",
+    .m_name = "newtypeinit",
     .m_doc = "A module containing `NewTypeInit` descriptor class.",
     .m_size = -1,
+    .m_methods = NewTypeInit_methods,
 };
 
 PyMODINIT_FUNC PyInit_newtypeinit(void)
 {
-  PyObject* m;
   if (PyType_Ready(&NewTypeInitType) < 0)
     return NULL;
 
-  m = PyModule_Create(&NewTypeInitmodule);
+  PyObject* m = PyModule_Create(&NewTypeInitmodule);
   if (m == NULL)
     return NULL;
 
@@ -244,15 +244,28 @@ PyMODINIT_FUNC PyInit_newtypeinit(void)
     Py_DECREF(m);
     return NULL;
   }
-  PyModule_AddObject(m, "NEWTYPE_INIT_KWARGS_STR", PY_NEWTYPE_INIT_KWARGS_STR);
+  if (PyModule_AddObject(
+          m, "NEWTYPE_INIT_KWARGS_STR", PY_NEWTYPE_INIT_KWARGS_STR)
+      < 0)
+  {
+    Py_DECREF(PY_NEWTYPE_INIT_KWARGS_STR);
+    Py_DECREF(m);
+    return NULL;
+  }
 
   PyObject* PY_NEWTYPE_INIT_ARGS_STR =
       PyUnicode_FromString(NEWTYPE_INIT_ARGS_STR);
   if (PY_NEWTYPE_INIT_ARGS_STR == NULL) {
     Py_DECREF(m);
     return NULL;
   }
-  PyModule_AddObject(m, "NEWTYPE_INIT_ARGS_STR", PY_NEWTYPE_INIT_ARGS_STR);
+  if (PyModule_AddObject(m, "NEWTYPE_INIT_ARGS_STR", PY_NEWTYPE_INIT_ARGS_STR)
+      < 0)
+  {
+    Py_DECREF(PY_NEWTYPE_INIT_ARGS_STR);
+    Py_DECREF(m);
+    return NULL;
+  }
 
   Py_INCREF(&NewTypeInitType);
   if (PyModule_AddObject(m, "NewTypeInit", (PyObject*)&NewTypeInitType) < 0) {

newtype/extensions/newtype_meth.c

@@ -262,8 +262,7 @@ static PyMemberDef newtypemethodobject_members[] = {
 
 // Type definition
 PyTypeObject NewTypeMethodType = {
-    PyVarObject_HEAD_INIT(&PyType_Type, 0).tp_name =
-        "newtypemethod.NewTypeMethod",
+    PyVarObject_HEAD_INIT(NULL, 0).tp_name = "newtypemethod.NewTypeMethod",
     .tp_doc =
         "A descriptor class that wraps around regular methods of a class "
         "to allow instantiation of the subtype if the method returns an "
@@ -292,16 +291,16 @@ static struct PyModuleDef newtypemethodmodule = {
         "that wraps around regular methods of a class to allow instantiation "
         "of the subtype if the method returns an instance of the supertype.",
     .m_size = -1,
+    .m_methods = NewTypeMethod_methods,
 };
 
 // Module initialization function
 PyMODINIT_FUNC PyInit_newtypemethod(void)
 {
-  PyObject* m;
   if (PyType_Ready(&NewTypeMethodType) < 0)
     return NULL;
 
-  m = PyModule_Create(&newtypemethodmodule);
+  PyObject* m = PyModule_Create(&newtypemethodmodule);
   if (m == NULL)
     return NULL;
 

pyproject.toml

@@ -65,6 +65,7 @@ optional = true
 
 [tool.poetry.group.profiling.dependencies]
 memray = { version = "^1.11.0", markers = "sys_platform != 'win32'" }
+pytest-memray = { version = "*", markers = "sys_platform != 'win32'" }
 
 [tool.poetry.group.debug]
 optional = true
@@ -74,7 +75,6 @@ line_profiler = "*"
 
 [tool.poetry.group.tests.dependencies]
 coverage = { extras = ["toml"], version = "*" }
-pytest-memray = "*"
 pytest = "*"
 pytest-cov = "*"
 pytest-mock = "*"