chore: add new tests for edge cases and remove redundant error handling

Author: Anonymous Committer

justoneapi/_transport.py

@@ -53,11 +53,6 @@ def get(self, path: str, params: dict[str, Any]) -> ApiResponse[Any]:
                 f"JustOneAPI Python SDK version {__version__} is deprecated. Please update to the latest version."
             )
 
-        if response.status_code >= 400:
-            raise TransportError(
-                f"Server returned HTTP {response.status_code} for GET {path}"
-            )
-
         try:
             payload = response.json()
         except ValueError as exc:
@@ -84,7 +79,7 @@ def get(self, path: str, params: dict[str, Any]) -> ApiResponse[Any]:
 
     @staticmethod
     def _is_success_code(code: Any) -> bool:
-        return code == 0 or code == "0"
+        return code == 0
 
     @staticmethod
     def _clean_params(params: dict[str, Any]) -> dict[str, Any]:

tests/test_runtime.py

@@ -61,6 +61,21 @@ def handler(request: httpx.Request) -> httpx.Response:
     assert response.message == "not ok"
 
 
+def test_http_error_with_json_payload_returns_api_response(make_client):
+    def handler(request: httpx.Request) -> httpx.Response:
+        return httpx.Response(
+            401,
+            json={"code": 100, "message": "invalid token", "data": None},
+        )
+
+    client = make_client(handler)
+    response = client.search.search_v1(keyword="deepseek")
+
+    assert response.success is False
+    assert response.code == 100
+    assert response.message == "invalid token"
+
+
 def test_raise_on_business_error(make_client):
     def handler(request: httpx.Request) -> httpx.Response:
         return httpx.Response(
@@ -87,6 +102,17 @@ def handler(request: httpx.Request) -> httpx.Response:
         client.search.search_v1(keyword="deepseek")
 
 
+def test_string_zero_is_not_treated_as_success(make_client):
+    def handler(request: httpx.Request) -> httpx.Response:
+        return httpx.Response(200, json={"code": "0", "message": "ok", "data": {}})
+
+    client = make_client(handler)
+    response = client.search.search_v1(keyword="deepseek")
+
+    assert response.success is False
+    assert response.code == "0"
+
+
 def test_optional_none_is_omitted_and_bool_is_lowercase(make_client):
     captured: dict[str, str] = {}