-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
Description: A lot of CPU or Memory is being spent in IEnumerable<T>.ToList().
Current condition: 68.3734377722759 of your Memory was spent in Enumerable.ToList called from Store.Reviews.ReviewValidation.StringValidation. We expected this value to be <13%.
Recommendations: Consider using List<T> from the start to avoid expensive calls to ToList(). Also, verify that IEnumerable<T>.ToList() isn't being...
Instructions for performance issue
Fix the perf issue by changing only non-test files.
Steps:
- Review repo, understand structure.
- Create Benchmark Tests - Use BenchmarkDotNet + MemoryDiagnoser. Create .csproj, run with latest .NET.
- Fix & optimize problematic method, cover edge cases.
- Rerun benchmark + unit tests to verify perf and correctness.
- In PR Explain fix - what you considered, implemented, and why.
- Post performance results as table in PR comment before/after fix. Add a short description of code changes into PR.
- Rename PR – Format: 'method
Metadata
Metadata
Assignees
Labels
No labels