From 4a177eb3cf9fbdf6fd5c10c8cc650b3e63e68d29 Mon Sep 17 00:00:00 2001
From: David Collom <david.collom@jetstack.io>
Date: Fri, 11 Apr 2025 08:08:20 +0000
Subject: [PATCH] Fix up Dashboard labels

---
 .../charts/version-checker/templates/dashboards.yaml   |  2 +-
 .../charts/version-checker/tests/dashboards_test.yaml  | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/deploy/charts/version-checker/templates/dashboards.yaml b/deploy/charts/version-checker/templates/dashboards.yaml
index 7b01be80..96a31e01 100644
--- a/deploy/charts/version-checker/templates/dashboards.yaml
+++ b/deploy/charts/version-checker/templates/dashboards.yaml
@@ -8,7 +8,7 @@ metadata:
   labels:
     {{- include "version-checker.labels" . | nindent 4 }}
     {{- if .Values.dashboards.labels }}
-    {{- .Values.dashboards.labels | toYaml }}
+    {{ .Values.dashboards.labels | toYaml | nindent 4}}
     {{- end }}
 data:
   internal.json: |-
diff --git a/deploy/charts/version-checker/tests/dashboards_test.yaml b/deploy/charts/version-checker/tests/dashboards_test.yaml
index 6bf1f038..46b1ba09 100644
--- a/deploy/charts/version-checker/tests/dashboards_test.yaml
+++ b/deploy/charts/version-checker/tests/dashboards_test.yaml
@@ -21,6 +21,16 @@ tests:
       - isNotEmpty:
           path: .data["internal.json"]
 
+  - it: works w/ custom labels
+    set:
+      dashboards.labels:
+        grafana: "123"
+    asserts:
+      - isKind:
+          of: ConfigMap
+      - hasDocuments:
+          count: 1
+
   - it: Works w/ GrafanaDashboard
     capabilities:
       apiVersions: