Merge pull request #15 from it-shark-pro/check-lines-of-code

Check lines of code

Author: EduardTrutsyk

.eslintrc

@@ -4,8 +4,7 @@
   },
   "env": {
     "es6": true,
-    "node": true,
-    "mocha": true
+    "node": true
   },
   "extends": ["eslint:recommended"],
   "rules": {
@@ -17,7 +16,10 @@
     "eqeqeq": 2,
     "func-names": 0,
     "indent": [2, 2],
-    "max-len": 0,
+    "max-len": ["error", { 
+      "code": 80,
+      "ignoreComments": true
+    }],
     "no-console": [ 1, {"allow": ["info", "error", "warn"]}],
     "no-new-wrappers": 0,
     "no-proto": 0,
@@ -36,6 +38,21 @@
         "allowTemplateLiterals": true
       }
     ],
-    "require-yield": 1
-  }
+    "require-yield": 1,
+    "prefer-const": 2
+  },
+  "overrides": [
+    {
+      "files": [
+        "**/test/**",
+        "**/extensions/**"
+      ],
+      "env": {
+        "mocha": true
+      },
+      "rules": {
+        "max-len": 0
+      }
+    }
+  ]
 }

extensions/assert-linesOfCode.js

@@ -0,0 +1,17 @@
+import assert from 'assert';
+
+function linesOfCode(fn, expected, recommended) {
+  const actualLinesOfCode = fn.toString().split('\n').filter(s => s.trim()).length - 2;
+  const isValid = actualLinesOfCode <= expected;
+  if (actualLinesOfCode <= expected && actualLinesOfCode > recommended) {
+    console.log(`Recommended lines of code for ${fn.name} is ${recommended}`); 
+  }
+  const message = `
+        "${fn.name}" should have maximum ${expected} line(s) of code but it ${actualLinesOfCode}.
+        Recommended lines of code for ${fn.name} is ${recommended}
+  `;
+
+  assert.ok(isValid, message);
+}
+
+assert.linesOfCode = linesOfCode;

task/01-strings-tasks.js

@@ -20,7 +20,6 @@
  *   '',  'bb'  => 'bb'
  */
 export function concatenateStrings(value1, value2) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -36,7 +35,6 @@ export function concatenateStrings(value1, value2) {
  *   ''      => 0
  */
 export function getStringLength(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -54,7 +52,6 @@ export function getStringLength(value) {
  *   'Chuck','Norris'  => 'Hello, Chuck Norris!'
  */
 export function getStringFromTemplate(firstName, lastName) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -69,7 +66,6 @@ export function getStringFromTemplate(firstName, lastName) {
  *   'Hello, Chuck Norris!' => 'Chuck Norris'
  */
 export function  extractNameFromTemplate(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -85,7 +81,6 @@ export function  extractNameFromTemplate(value) {
  *   'cat'       => 'c'
  */
 export function getFirstChar(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -101,7 +96,6 @@ export function getFirstChar(value) {
  *   '\tHello, World! ' => 'Hello, World!'
  */
 export function removeLeadingAndTrailingWhitespaces(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -117,7 +111,6 @@ export function removeLeadingAndTrailingWhitespaces(value) {
  *   'cat', 3 => 'catcatcat'
  */
 export function repeatString(value, count) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -134,7 +127,6 @@ export function repeatString(value, count) {
  *   'ABABAB','BA' => 'ABAB'
  */
 export function removeFirstOccurrences(str, value)  {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -150,7 +142,6 @@ export function removeFirstOccurrences(str, value)  {
  *   '<a>' => 'a'
  */
 export function unbracketTag(str) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -166,7 +157,6 @@ export function unbracketTag(str) {
  *  'abcdefghijklmnopqrstuvwxyz' => 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'
  */
 export function convertToUpperCase(str) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -182,7 +172,6 @@ export function convertToUpperCase(str) {
  *   'info@gmail.com' => ['info@gmail.com']
  */
 export function extractEmails(str) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -210,7 +199,6 @@ export function extractEmails(str) {
  *
  */
 export function getRectangleString(width, height) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -232,7 +220,6 @@ export function getRectangleString(width, height) {
  *
  */
 export function encodeToRot13(str) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -250,7 +237,6 @@ export function encodeToRot13(str) {
  *   isString(new String('test')) => true
  */
 export function isString(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -280,6 +266,5 @@ export function isString(value) {
  *   'K♠' => 51
  */
 export function getCardId(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }

task/02-numbers-tasks.js

@@ -21,7 +21,6 @@
  *   5, 5  => 25
  */
 export function getRectangleArea(width, height) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -38,7 +37,6 @@ export function getRectangleArea(width, height) {
  *   0    => 0
  */
 export function getCicleCircumference(radius) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -55,7 +53,6 @@ export function getCicleCircumference(radius) {
  *  -3, 3  => 0
  */
 export function getAverage(value1, value2) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -75,7 +72,6 @@ export function getAverage(value1, value2) {
  *   (-5,0) (10,-10) => 18.027756377319946
  */
 export function getDistanceBetweenPoints(x1, y1, x2, y2) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -92,7 +88,6 @@ export function getDistanceBetweenPoints(x1, y1, x2, y2) {
  *   5*x = 0         => 0
  */
 export function getLinearEquationRoot(a, b) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -116,7 +111,6 @@ export function getLinearEquationRoot(a, b) {
  *   (0,1) (1,2)     => 0
  */
 export function getAngleBetweenVectors(x1, y1, x2, y2) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -133,7 +127,6 @@ export function getAngleBetweenVectors(x1, y1, x2, y2) {
  *     0     => 0
  */
 export function getLastDigit(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -150,7 +143,6 @@ export function getLastDigit(value) {
  * '-525.5'     => -525.5
  */
 export function parseNumberFromString(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -168,7 +160,6 @@ export function parseNumberFromString(value) {
  *   1,2,3   => 3.741657386773941
  */
 export function getParallelipidedDiagonal(a, b, c) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -190,7 +181,6 @@ export function getParallelipidedDiagonal(a, b, c) {
  *   1678, 3  => 2000
  */
 export function roundToPowerOfTen(num, pow) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -212,7 +202,6 @@ export function roundToPowerOfTen(num, pow) {
  *   17 => true
  */
 export function isPrime(n) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -232,6 +221,5 @@ export function isPrime(n) {
  *   toNumber(new Number(42), 0) => 42
  */
 export function toNumber(value, def) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }

task/03-date-tasks.js

@@ -21,7 +21,6 @@
  *    'Sun, 17 May 1998 03:00:00 GMT+01' => Date()
  */
 export function parseDataFromRfc2822(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -37,7 +36,6 @@ export function parseDataFromRfc2822(value) {
  *    '2016-01-19T08:07:37Z' => Date()
  */
 export function parseDataFromIso8601(value) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -57,7 +55,6 @@ export function parseDataFromIso8601(value) {
  *    Date(2015,1,1)    => false
  */
 export function isLeapYear(date) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -78,7 +75,6 @@ export function isLeapYear(date) {
  *    Date(2000,1,1,10,0,0),  Date(2000,1,1,15,20,10,453)   => "05:20:10.453"
  */
 export function timeSpanToString(startDate, endDate) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }
 
@@ -98,6 +94,5 @@ export function timeSpanToString(startDate, endDate) {
  *    Date.UTC(2016,3,5,21, 0) => Math.PI/2
  */
 export function angleBetweenClockHands(date) {
-  /* implement your code here */
   throw new Error('Not implemented');
 }