Skip to content

Commit 73e206d

Browse files
felix-kaestnerfelix-kaestner
committed
Replace go-makefile-maker workflows with manually maintained ones
Stop using go-makefile-maker for GitHub Actions workflow generation. With recent additions of custom workflows, maintaining consistency between auto-generated and manually written pipelines became impractical. The effort to update all workflows already requires reviewing each one, so auto-generation provides diminishing value. Additionally, some generated workflows like CodeQL are redundant (enabled at repo level) while others like test-chart required manual modifications anyway. Going forward, all workflows will be manually maintained for this project, providing full control over CI/CD configuration.
1 parent 729ba0e commit 73e206d

9 files changed

Lines changed: 216 additions & 140 deletions

File tree

‎.github/workflows/lint.yml‎

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
# SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company and IronCore contributors
2+
# SPDX-License-Identifier: Apache-2.0
3+
4+
name: Lint
5+
6+
on:
7+
pull_request:
8+
branches:
9+
- main
10+
paths-ignore:
11+
- 'docs/**'
12+
- '**/*.md'
13+
14+
jobs:
15+
lint:
16+
name: Check Go Code
17+
runs-on: ubuntu-latest
18+
steps:
19+
- uses: actions/checkout@v6
20+
- uses: actions/setup-go@v6
21+
with:
22+
go-version-file: 'go.mod'
23+
- name: Run golangci-lint
24+
uses: golangci/golangci-lint-action@v9
25+
with:
26+
version: latest
27+
vulnerabilities:
28+
name: Check Vulnerabilities
29+
runs-on: ubuntu-latest
30+
steps:
31+
- uses: actions/checkout@v6
32+
- uses: actions/setup-go@v6
33+
with:
34+
go-version: 'stable'
35+
- name: Install govulncheck
36+
run: go install golang.org/x/vuln/cmd/govulncheck@latest
37+
- name: Run govulncheck
38+
run: govulncheck -format text ./...
39+
spelling:
40+
name: Check Spelling Errors
41+
runs-on: ubuntu-latest
42+
steps:
43+
- uses: actions/checkout@v6
44+
- name: Run typos
45+
uses: crate-ci/typos@v1
46+
env:
47+
CLICOLOR: "1"
48+
shellcheck:
49+
name: Check Shell Scripts
50+
runs-on: ubuntu-latest
51+
steps:
52+
- uses: actions/checkout@v6
53+
- name: Run shellcheck
54+
uses: reviewdog/action-shellcheck@v1
55+
license:
56+
name: Check Licenses
57+
runs-on: ubuntu-latest
58+
steps:
59+
- uses: actions/checkout@v6
60+
- uses: actions/setup-go@v6
61+
with:
62+
go-version-file: 'go.mod'
63+
- name: Dependency Licenses Review
64+
run: make check-dependency-licenses
65+
- name: Check if source code files have license header
66+
run: make check-addlicense

‎.github/workflows/publish-docs.yml‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,21 @@ name: Documentation
55

66
on:
77
push:
8-
branches: [main]
8+
branches:
9+
- main
910
pull_request:
10-
types: [ assigned, opened, synchronize, reopened ]
11-
workflow_dispatch:
12-
13-
permissions:
14-
contents: read
15-
pages: write
16-
id-token: write
11+
branches:
12+
- main
1713

1814
concurrency:
1915
group: pages
2016
cancel-in-progress: false
2117

18+
permissions:
19+
contents: read
20+
id-token: write
21+
pages: write
22+
2223
jobs:
2324
build:
2425
name: Build VitePress Site

.github/workflows/goreleaser.yaml renamed to .github/workflows/release.yaml

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,26 @@
1-
################################################################################
2-
# This file is AUTOGENERATED with <https://github.com/sapcc/go-makefile-maker> #
3-
# Edit Makefile.maker.yaml instead. #
4-
################################################################################
5-
6-
# SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company
1+
# SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company
72
# SPDX-License-Identifier: Apache-2.0
83

9-
name: goreleaser
10-
"on":
4+
name: Release
5+
6+
on:
117
push:
128
tags:
13-
- '*'
9+
- 'v*'
10+
1411
permissions:
1512
contents: write
1613
packages: write
14+
1715
jobs:
1816
release:
19-
name: goreleaser
17+
name: Publish Release
2018
runs-on: ubuntu-latest
2119
steps:
22-
- name: Check out code
23-
uses: actions/checkout@v6
24-
with:
25-
fetch-depth: 0
26-
- name: Set up Go
27-
uses: actions/setup-go@v6
20+
- uses: actions/checkout@v6
21+
- uses: actions/setup-go@v6
2822
with:
29-
check-latest: true
30-
go-version: 1.25.7
23+
go-version-file: 'go.mod'
3124
- name: Run prepare make target
3225
run: make generate
3326
- name: Install syft

‎.github/workflows/reuse.yaml‎

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,27 @@
1-
# SPDX-FileCopyrightText: 2025 SAP SE or an SAP affiliate company and IronCore contributors
1+
# SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company and IronCore contributors
22
# SPDX-License-Identifier: Apache-2.0
33

4-
name: REUSE Compliance
4+
name: REUSE
5+
56
on:
67
push:
78
branches:
89
- main
10+
paths-ignore:
11+
- 'docs/**'
12+
- '**/*.md'
913
pull_request:
1014
branches:
11-
- '*'
12-
workflow_dispatch: {}
13-
permissions:
14-
contents: read
15+
- main
16+
paths-ignore:
17+
- 'docs/**'
18+
- '**/*.md'
19+
1520
jobs:
16-
test:
17-
name: Check
21+
compliance-check:
22+
name: Compliance Check
1823
runs-on: ubuntu-latest
1924
steps:
20-
- uses: actions/checkout@v4
21-
- name: REUSE Compliance Check
22-
uses: fsfe/reuse-action@v5
25+
- uses: actions/checkout@v6
26+
- name: Compliance Check
27+
uses: fsfe/reuse-action@v5

‎.github/workflows/stale.yaml‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
1-
# SPDX-FileCopyrightText: 2025 SAP SE or an SAP affiliate company and IronCore contributors
1+
# SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company and IronCore contributors
22
# SPDX-License-Identifier: Apache-2.0
33

4-
name: Close inactive issues
4+
name: Stale
5+
56
on:
67
schedule:
78
- cron: "35 1 * * *"
89

10+
permissions:
11+
contents: read
12+
issues: write
13+
pull-requests: write
14+
915
jobs:
1016
close-issues:
17+
name: Close Inactive Issues and PRs
1118
runs-on: ubuntu-latest
12-
permissions:
13-
issues: write
14-
pull-requests: write
1519
steps:
1620
- uses: actions/stale@v9
1721
with:

‎.github/workflows/test-chart.yml‎

Lines changed: 22 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -1,62 +1,43 @@
1-
# SPDX-FileCopyrightText: 2025 SAP SE or an SAP affiliate company and IronCore contributors
1+
# SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company and IronCore contributors
22
# SPDX-License-Identifier: Apache-2.0
33

4-
name: Test
4+
name: Test Chart
5+
56
on:
6-
push:
7-
branches:
8-
- main
9-
paths-ignore:
10-
- '**.md'
117
pull_request:
128
branches:
13-
- '*'
9+
- main
1410
paths-ignore:
15-
- '**.md'
16-
workflow_dispatch: {}
17-
permissions:
18-
contents: read
11+
- 'docs/**'
12+
- '**/*.md'
13+
1914
jobs:
2015
test-chart:
21-
name: Chart
16+
name: Run Chart Tests
2217
runs-on: ubuntu-latest
2318
steps:
24-
- name: Check out code
25-
uses: actions/checkout@v4
26-
- name: Set up Go
27-
uses: actions/setup-go@v5
19+
- uses: actions/checkout@v6
20+
- uses: actions/setup-go@v6
2821
with:
29-
check-latest: true
30-
go-version: 1.25.5
31-
- name: Fetch latest kubectl version
32-
id: kubectl
33-
run: |
34-
KUBECTL_VERSION=$(curl -sL https://dl.k8s.io/release/stable.txt)
35-
echo "version=$KUBECTL_VERSION" >> $GITHUB_OUTPUT
36-
- name: Fetch latest kind version
37-
id: kind
22+
go-version-file: 'go.mod'
23+
- name: Set up Helm
24+
uses: azure/setup-helm@v4
25+
with:
26+
version: latest
27+
- name: Lint Helm Chart
3828
run: |
39-
KIND_VERSION=$(curl -s https://api.github.com/repos/kubernetes-sigs/kind/releases/latest | grep '"tag_name":' | cut -d'"' -f4)
40-
echo "version=$KIND_VERSION" >> $GITHUB_OUTPUT
41-
- name: Create k8s kind cluster
29+
helm lint ./charts/network-operator
30+
- name: Create kind cluster
4231
uses: helm/kind-action@v1
4332
with:
44-
version: ${{ steps.kind.outputs.version }}
33+
version: v0.31.0
34+
kubectl_version: v1.35.0
4535
cluster_name: kind
46-
kubectl_version: ${{ steps.kubectl.outputs.version }}
4736
- name: Prepare network-operator
4837
run: |
49-
go mod tidy
38+
go mod download
5039
make docker-build IMG=network-operator:v0.1.0
5140
kind load docker-image network-operator:v0.1.0
52-
- name: Install Helm
53-
run: |
54-
curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
55-
- name: Verify Helm installation
56-
run: helm version
57-
- name: Lint Helm Chart
58-
run: |
59-
helm lint ./charts/network-operator
6041
- name: Install cert-manager via Helm
6142
run: |
6243
helm repo add jetstack https://charts.jetstack.io
@@ -67,28 +48,10 @@ jobs:
6748
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager
6849
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager-cainjector
6950
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager-webhook
70-
# TODO: Uncomment if Prometheus is enabled
71-
# - name: Install Prometheus Operator CRDs
72-
# run: |
73-
# helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
74-
# helm repo update
75-
# helm install prometheus-crds prometheus-community/prometheus-operator-crds
76-
# - name: Install Prometheus via Helm
77-
# run: |
78-
# helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
79-
# helm repo update
80-
# helm install prometheus prometheus-community/prometheus --namespace monitoring --create-namespace
81-
# - name: Wait for Prometheus to be ready
82-
# run: |
83-
# kubectl wait --namespace monitoring --for=condition=available --timeout=300s deployment/prometheus-server
84-
- name: Install Helm chart for project
51+
- name: Install Helm Chart
8552
run: |
8653
helm dependency build ./charts/network-operator
8754
helm install network-operator ./charts/network-operator --create-namespace --namespace network-operator-system
8855
- name: Check Helm release status
8956
run: |
9057
helm status network-operator --namespace network-operator-system
91-
# TODO: Uncomment if prometheus.enabled is set to true to confirm that the ServiceMonitor gets created
92-
# - name: Check Presence of ServiceMonitor
93-
# run: |
94-
# kubectl wait --namespace network-operator-system --for=jsonpath='{.kind}'=ServiceMonitor servicemonitor/network-operator-controller-manager-metrics-monitor

‎.github/workflows/test-e2e.yml‎

Lines changed: 15 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,32 @@
1-
# SPDX-FileCopyrightText: 2025 SAP SE or an SAP affiliate company and IronCore contributors
1+
# SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company and IronCore contributors
22
# SPDX-License-Identifier: Apache-2.0
33

4-
name: Test
4+
name: Test E2E
5+
56
on:
6-
push:
7-
branches:
8-
- main
9-
paths-ignore:
10-
- '**.md'
117
pull_request:
128
branches:
13-
- '*'
9+
- main
1410
paths-ignore:
15-
- '**.md'
16-
workflow_dispatch: {}
17-
permissions:
18-
contents: read
11+
- 'docs/**'
12+
- '**/*.md'
13+
1914
jobs:
2015
test-e2e:
21-
name: E2E
16+
name: Run E2E Tests
2217
runs-on: ubuntu-latest
2318
steps:
24-
- name: Check out code
25-
uses: actions/checkout@v4
26-
- name: Set up Go
27-
uses: actions/setup-go@v5
19+
- uses: actions/checkout@v6
20+
- uses: actions/setup-go@v6
2821
with:
29-
check-latest: true
30-
go-version: 1.25.5
31-
- name: Fetch latest kubectl version
32-
id: kubectl
33-
run: |
34-
KUBECTL_VERSION=$(curl -sL https://dl.k8s.io/release/stable.txt)
35-
echo "version=$KUBECTL_VERSION" >> $GITHUB_OUTPUT
36-
- name: Fetch latest kind version
37-
id: kind
38-
run: |
39-
KIND_VERSION=$(curl -s https://api.github.com/repos/kubernetes-sigs/kind/releases/latest | grep '"tag_name":' | cut -d'"' -f4)
40-
echo "version=$KIND_VERSION" >> $GITHUB_OUTPUT
41-
- name: Create k8s kind cluster
22+
go-version-file: 'go.mod'
23+
- name: Create kind cluster
4224
uses: helm/kind-action@v1
4325
with:
44-
version: ${{ steps.kind.outputs.version }}
26+
version: v0.31.0
27+
kubectl_version: v1.35.0
4528
cluster_name: network
46-
kubectl_version: ${{ steps.kubectl.outputs.version }}
4729
- name: Running E2E Tests
4830
run: |
49-
go mod tidy
31+
go mod download
5032
make test-e2e

0 commit comments

Comments
 (0)