[BUG]: Panic in expandConditions when conditions.ref_name is nil/empty

[milagrofrost]

Expected Behavior

When applying a github_repository_ruleset resource with an empty array conditions.ref_name, the provider should either produce a validation error or treat it as empty (not panic).

Actual Behavior

Terraform plan/apply fails with a panic:

panic: interface conversion: interface {} is nil, not map[string]interface {}

Stack trace:
by using the github.com/integrations/terraform-provider-github/v6/github.expandConditions function (util_rules.go:194) when conditions.ref_name is empty array or contains nil, the provider panics rather than failing gracefully.

Terraform Version

Terraform v1.9.5
provider registry.terraform.io/integrations/github v6.11.1

Affected Resource(s)

• github_repository_ruleset

Terraform Configuration Files

resource "github_repository_ruleset" "test" {
  repository = "some-repo"
  name = "test"
  target = "branch"
  enforcement = "disabled"

  conditions {
    ref_name {
      # No include/exclude specified or empty arrays
    }
  }
  rules {
    creation = true
  }
}

Steps to Reproduce

1. Write the above github_repository_ruleset resource with an empty array conditions.ref_name block
2. Run terraform apply

Debug Output

Panic Output

panic: interface conversion: interface {} is nil, not map[string]interface {}

github.com/integrations/terraform-provider-github/v6/github.expandConditions({0xc00067d2e0, ...}, 0x0)
	github.com/integrations/terraform-provider-github/v6/github/util_rules.go:194 +0xb6b
...
Error: The terraform-provider-github_v6.11.1 plugin crashed!

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[majiayu000]

Hi, I've been looking into this and traced the root cause.

Proposed approach: 1. Comment on the issue to confirm it's available despite the assignment. 2. Add nil check in expandConditions (util_rules.go:194) before the type assertion map[string]interface{}. 3. Handle nil case gracefully — return empty conditions or skip the ref_name block. 4. Add acceptance test case with empty ref_name block in github_repository_ruleset to prevent regression. 5. Follow CONTRIBUTING.md: fork, branch, test, focused PR to main.

I'll open a draft PR shortly. Happy to adjust based on your preference.

[majiayu000]

Hi, I'd like to work on this.

Problem: expandConditions at line 194 panics with interface conversion: interface {} is nil, not map[string]interface {} when ref_name contains a nil element (e.g. []any{nil}). The existing guard checks len(v) != 0 but not whether v[0] itself is nil.

Proposed fix: Add && v[0] != nil to the condition on line 193, so the type assertion on line 194 is only reached when v[0] is actually a map.

Will open a PR shortly.