The code formatting of assignments and double-slash comments is not aligned

[tianpan2024]

The code formatting of assignments and double-slash comments is not aligned

// Python4Delphi Demo
function PyPoint_getattr(obj: PPyObject; Key: PAnsiChar): PPyObject; cdecl;
begin
with GetPythonEngine, PPyPoint(obj)^ do begin
if Key = 'x' then
Result :=
PyLong_FromLong(po_x)
// code format error!
else if Key = 'y' then
Result := PyLong_FromLong(po_y)
else if Key = 'z' then
Result := PyLong_FromLong(po_z)
else begin
Result := PyObject_GenericGetAttr(obj, PyUnicodeFromString(Key));
if not Assigned(Result) then
PyErr_SetString(PyExc_AttributeError^, PAnsiChar(Utf8Encode(Format('Unknown attribute "%s"', [Key]))));
end;
end;
end;

[tianpan2024]

This bug is very common in Python 4Delphi demos.

[zaneduffield]

The minimal version of this issue is

if A then
  A := B
//
else 
  F;

which is formatted as

if A then
  A :=
      B
          //
else
  F;

but when you manually unwrap the comment it's fine

if A then
  A := B //
else
  F;

This weird formatting arises because

1. a line comment on its 'own' line will never be unwrapped onto the previous line
2. the line inside the if block doesn't end until the else is found (or a semicolon), so the line comment is parsed as part of the statement inside the if block.

In this case I do wonder what the best formatting is. Maybe it's for the line comment to be aligned with the statement inside the if block, much like we do for a comment at the end of a begin-end block

if A then
  A := B 
  //
else
  F;

[jgardn3r]

Following on from point 2: When parsing the comment, it isn't known whether the nested line is completed or not. There will have to be a form of look-ahead or similar to determine if the comment line is part of the statement.