From 56b21555cb8f71af403e71e94c528d79217f02c5 Mon Sep 17 00:00:00 2001 From: Charlie Doern Date: Fri, 31 Jan 2025 16:08:03 -0500 Subject: [PATCH] amend merge criteria the rule that the Oversight Committee needs to merge every dev-doc PR has not scaled with the project. We now write dev-docs for most design changes for any instructlab repo. This rule has also not regularly been followed. Amend this rule such that 2 maintainers of any instructlab can approve a PR and a third maintainer of any instructlab repo can verify that sufficient reviews have been given and merge a PR Signed-off-by: Charlie Doern --- README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 660711e1..881210d3 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,11 @@ please ping the Oversight Committee for help. out from maintainers of relevant components. The broader the scope or more controversial the change, the more broad the consensus should be required for merging. The final approval and merge (or action, e.g. deleting a repo) - falls to a member of the Oversight Committee. This final review is to ensure that + falls to two maintainers of any InstructLab Organization repository as well as + an additional third maintainer of any InstructLab Organization repository to + merge the PR after verifying that sufficient reviews have been given. If there are + disputes on the design document that cannot be resolved, an Oversight Committee + member can be consulted as an arbitrator. These approvals ensure that adequate opportunity and attention has been given by the affected parties. * Examples of non-trivial changes include approving proposal for new repositories, creation of new repositories, changes to organization level GitHub settings, archiving