JCL-322: added a Objects.requireNonNull (#402)

* added a Objects.requireNonNull
* moved session null check to the constructor
* added http client null check to the constructor

Author: timea-solid

access-grant/src/main/java/com/inrupt/client/accessgrant/AccessGrantClient.java

@@ -133,6 +133,7 @@ private AccessGrantClient(final Client client, final AccessGrantConfiguration co
      * @return the scoped access grant client
      */
     public AccessGrantClient session(final Session session) {
+        Objects.requireNonNull(session, "Session may not be null!");
         return new AccessGrantClient(client.session(session), config);
     }
 

core/src/main/java/com/inrupt/client/core/DefaultClient.java

@@ -32,6 +32,7 @@
 import com.inrupt.client.spi.ServiceProvider;
 
 import java.util.List;
+import java.util.Objects;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
 
@@ -57,6 +58,8 @@ public final class DefaultClient implements Client {
     }
 
     DefaultClient(final HttpService httpClient, final Session session) {
+        Objects.requireNonNull(httpClient, "Http client may not be null!");
+        Objects.requireNonNull(session, "Session may not be null!");
         this.httpClient = httpClient;
         this.clientSession = session;
     }

core/src/test/java/com/inrupt/client/core/DefaultClientTest.java

@@ -368,6 +368,12 @@ void testOfStringPublisherUmaAnonSession() throws IOException, InterruptedExcept
         assertEquals(401, response.statusCode());
     }
 
+    @Test
+    void testNullSession() {
+        assertThrows(NullPointerException.class, () ->
+                client.session(null));
+    }
+
     @Test
     void testUmaSessionExpiredIdToken() throws Exception {
         final Map<String, Object> claims = new HashMap<>();

openid/src/main/java/com/inrupt/client/openid/OpenIdSession.java

@@ -144,7 +144,7 @@ public static Session ofClientCredentials(final URI issuer, final String clientI
      * @param clientId the client id value
      * @param clientSecret the client secret value
      * @param authMethod the authentication mechanism (e.g. {@code client_secret_post} or {@code client_secret_basic})
-     * @param config the ID token verifification config
+     * @param config the ID token verification config
      * @return the session
      */
     public static Session ofClientCredentials(final OpenIdProvider provider,

solid/src/main/java/com/inrupt/client/solid/SolidClient.java

@@ -78,6 +78,7 @@ public class SolidClient {
      * @return a session-scoped client
      */
     public SolidClient session(final Session session) {
+        Objects.requireNonNull(session, "Session may not be null!");
         return new SolidClient(client.session(session), defaultHeaders, fetchAfterWrite);
     }
 

solid/src/main/java/com/inrupt/client/solid/SolidSyncClient.java

@@ -29,6 +29,7 @@
 import com.inrupt.client.auth.Session;
 
 import java.net.URI;
+import java.util.Objects;
 import java.util.concurrent.CompletionException;
 import java.util.concurrent.CompletionStage;
 
@@ -54,6 +55,7 @@ public class SolidSyncClient {
      * @return a session-scoped client
      */
     public SolidSyncClient session(final Session session) {
+        Objects.requireNonNull(session, "Session may not be null!");
         return new SolidSyncClient(client.session(session));
     }