Fixing unreachable-code-return in react-native-github (facebook#56093)

ingridwang · facebook-github-bot · commit 6defeae9dc8c · 2026-03-17T14:33:53.000-07:00
Summary:

## Changelog

[iOS][Fixed] - Addressing -Wunreachable-code-return issues.

Reviewed By: javache

Differential Revision: D96507093
diff --git a/packages/react-native/React/Profiler/RCTProfile.m b/packages/react-native/React/Profiler/RCTProfile.m
@@ -315,6 +315,7 @@ void RCTProfileHookModules(RCTBridge *bridge)
 
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wtautological-pointer-compare"
+#pragma clang diagnostic ignored "-Wunreachable-code-return"
   if (RCTProfileTrampoline == NULL) {
     return;
   }
diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm
@@ -156,7 +156,6 @@ static int32_t getUniqueId()
   return ^(NSArray *args) {
     if (!callback) {
       LOG(FATAL) << "Callback arg cannot be called more than once";
-      return;
     }
 
     callback->call([args](jsi::Runtime &rt, jsi::Function &jsFunction) {

Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,7 @@ void RCTProfileHookModules(RCTBridge *bridge)`
`315`	`315`
`316`	`316`	`#pragma clang diagnostic push`
`317`	`317`	`#pragma clang diagnostic ignored "-Wtautological-pointer-compare"`
	`318`	`+#pragma clang diagnostic ignored "-Wunreachable-code-return"`
`318`	`319`	`if (RCTProfileTrampoline == NULL) {`
`319`	`320`	`return;`
`320`	`321`	`}`
Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,6 @@ static int32_t getUniqueId()`
`156`	`156`	`return ^(NSArray *args) {`
`157`	`157`	`if (!callback) {`
`158`	`158`	`LOG(FATAL) << "Callback arg cannot be called more than once";`
`159`		`- return;`
`160`	`159`	`}`
`161`	`160`
`162`	`161`	`callback->call([args](jsi::Runtime &rt, jsi::Function &jsFunction) {`