Skip to content

Commit 3f848dc

Browse files
alexfiklinducer
authored andcommitted
ci: pin jax<0.4.31 for mypy on gitlab
1 parent a2683ea commit 3f848dc

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

.gitlab-ci.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,14 @@ Pylint:
107107

108108
Mypy:
109109
script: |
110-
EXTRA_INSTALL="jax[cpu]"
110+
# NOTE: jax>=0.4.31 requires python 3.10 and uses pattern matching
111+
# which conflicts with our mypy.python_version = '3.8' setting
112+
EXTRA_INSTALL="mypy pytest jax[cpu]<0.4.31"
113+
111114
curl -L -O https://tiker.net/ci-support-v0
112115
. ./ci-support-v0
116+
113117
build_py_project_in_venv
114-
python -m pip install mypy pytest
115118
./run-mypy.sh
116119
tags:
117120
- python3

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ known-local-folder = [
119119
lines-after-imports = 2
120120

121121
[tool.mypy]
122+
# TODO: unpin jax version on CI when this gets bumped to 3.10
122123
python_version = "3.8"
123124
warn_unused_ignores = true
124125
# TODO: enable this

0 commit comments

Comments
 (0)