Merge pull request #20 from rx-ts/feat/resolve_dts

resolve .ts/.tsx/.d.ts first, and then fallback to @types/*

Author: alexgorbatchev

index.js

@@ -25,10 +25,8 @@ function resolveFile(source, file, config) {
   }
 
   let foundTsPath = null;
-  const extensions = Object.keys(require.extensions).concat(
-    '.ts',
-    '.tsx',
-    '.d.ts',
+  const extensions = ['.ts', '.tsx', '.d.ts'].concat(
+    Object.keys(require.extensions),
   );
 
   // setup tsconfig-paths
@@ -64,6 +62,25 @@ function resolveFile(source, file, config) {
     foundNodePath = null;
   }
 
+  // naive attempt at @types/* resolution,
+  // if path is neither absolute nor relative
+  if (
+    (/\.jsx?$/.test(foundNodePath) ||
+      (config.alwaysTryTypes && !foundNodePath)) &&
+    !/^@types[/\\]/.test(source) &&
+    !path.isAbsolute(source) &&
+    source[0] !== '.'
+  ) {
+    const definitelyTyped = resolveFile(
+      '@types' + path.sep + mangleScopedPackage(source),
+      file,
+      config,
+    );
+    if (definitelyTyped.found) {
+      return definitelyTyped;
+    }
+  }
+
   if (foundNodePath) {
     log('matched node path:', foundNodePath);
 
@@ -73,19 +90,35 @@ function resolveFile(source, file, config) {
     };
   }
 
-  log('didnt find', source);
+  log("didn't find", source);
 
   return {
     found: false,
   };
 }
+
 function packageFilter(pkg) {
-  if (pkg['jsnext:main']) {
-    pkg['main'] = pkg['jsnext:main'];
-  }
+  pkg.main =
+    pkg.types || pkg.typings || pkg.module || pkg['jsnext:main'] || pkg.main;
   return pkg;
 }
 
+/**
+ * For a scoped package, we must look in `@types/foo__bar` instead of `@types/@foo/bar`.
+ *
+ * @param {string} moduleName
+ * @returns {string}
+ */
+function mangleScopedPackage(moduleName) {
+  if (moduleName[0] === '@') {
+    const replaceSlash = moduleName.replace(path.sep, '__');
+    if (replaceSlash !== moduleName) {
+      return replaceSlash.slice(1); // Take off the "@"
+    }
+  }
+  return moduleName;
+}
+
 module.exports = {
   interfaceVersion: 2,
   resolve: resolveFile,

package-lock.json

@@ -29,6 +29,7 @@
     "eslint-plugin-import": "*"
   },
   "devDependencies": {
+    "@types/unist": "^2.0.3",
     "dummy.js": "file:dummy.js",
     "eslint": "^5.6.1",
     "eslint-plugin-import": "^2.14.0",

package.json

@@ -26,6 +26,7 @@ module.exports = dirname => ({
     'import/resolver': {
       [path.resolve(`${__dirname}/../index.js`)]: {
         directory: dirname,
+        alwaysTryTypes: true
       },
     },
   },

tests/baseEslintConfig.js

@@ -0,0 +1,3 @@
+declare const content : 'yes';
+
+export default content;

tests/withoutPaths/dtsImportee.d.ts

@@ -1,9 +1,17 @@
 // import relative
 import './tsImportee'
 import './tsxImportee'
+import './dtsImportee'
+import './subfolder/dtsImportee'
 import './subfolder/tsImportee'
 import './subfolder/tsxImportee'
 
 // import from node_module
 import 'typescript'
 import 'dummy.js'
+
+// import from `@types/`
+import 'json5'
+
+// enable alwaysTryTypes 
+import 'unist'

tests/withoutPaths/index.ts

@@ -0,0 +1,3 @@
+declare const content : 'yes';
+
+export default content;