-
Notifications
You must be signed in to change notification settings - Fork 3
Labels
conventionsIssue with formatting / naming / ...Issue with formatting / naming / ...documentationMissing documentation, docstring conventions, ...Missing documentation, docstring conventions, ...next-releaseIssues blocking the next releaseIssues blocking the next release
Milestone
Description
Since we're now having automatic ruff linting enabled through a GitHub Action, it's much easier to follow the conventions.
Particularly the recent changes in the bdv module and the related tests are triggering complaints.
Docstrings should be added or fixed, making sure that:
- the summary line is concise and allows to understand the idea
- more details are given in the followup section, if necessary
- especially for tests-docstrings it is important to explain the test-flow (i.e. the idea of what the test does) properly, as this is sometimes extremely difficult to guess and understand from the test code itself
Current complaints can be seen in the details of the lint workflow, for example from run 13853569840.
Metadata
Metadata
Assignees
Labels
conventionsIssue with formatting / naming / ...Issue with formatting / naming / ...documentationMissing documentation, docstring conventions, ...Missing documentation, docstring conventions, ...next-releaseIssues blocking the next releaseIssues blocking the next release
Type
Projects
Status
Done