diactric fix

Author: ANKUR DWIVEDI

imagekitio/url.py

@@ -3,7 +3,7 @@
 import sys
 from datetime import datetime as dt
 from typing import Any, Dict, List
-from urllib.parse import ParseResult, urlparse, urlunparse, parse_qsl, urlencode
+from urllib.parse import ParseResult, urlparse, urlunparse, parse_qsl, urlencode, quote
 
 from .constants.defaults import Default
 from .constants.supported_transform import SUPPORTED_TRANS
@@ -85,6 +85,7 @@ def build_url(self, options: dict) -> str:
             private_key = options.get("private_key")
             expiry_timestamp = self.get_signature_timestamp(expire_seconds)
             url_signature = self.get_signature(
+                self,
                 private_key=private_key,
                 url=url_object.geturl(),
                 url_endpoint=url_endpoint,
@@ -129,7 +130,14 @@ def get_signature_timestamp(expiry_seconds: int = None) -> int:
         return current_timestamp + expiry_seconds
 
     @staticmethod
-    def get_signature(private_key, url, url_endpoint, expiry_timestamp: int) -> str:
+    def get_signature(self, private_key, url, url_endpoint, expiry_timestamp: int) -> str:
+        last_slash_pos = url.rfind('/')
+        question_mark_pos = url.find('?', last_slash_pos)
+        path = url[last_slash_pos + 1:question_mark_pos] if question_mark_pos != -1 else url[last_slash_pos + 1:]
+        encoded_path = self.encode_string_if_required(self,path)
+        encoded_url = url[:last_slash_pos + 1] + encoded_path + url[question_mark_pos:] if question_mark_pos != -1 else url[:last_slash_pos + 1] + encoded_path
+        url = encoded_url
+        print(url)
         """ "
         create signature(hashed hex key) from
         private_key, url, url_endpoint and expiry_timestamp
@@ -211,3 +219,11 @@ def transformation_to_str(transformation):
             )
 
         return Default.CHAIN_TRANSFORM_DELIMITER.value.join(parsed_transforms)
+
+    @staticmethod
+    def has_more_than_ascii(s):
+        return any(ord(char) > 127 for char in s)
+        
+    @staticmethod
+    def encode_string_if_required(self,s):
+        return quote(s) if self.has_more_than_ascii(s) else s

setup.py

@@ -8,7 +8,7 @@
 
 setuptools.setup(
     name="imagekitio",
-    version="4.0.0",
+    version="4.0.1",
     description="Python wrapper for the ImageKit API",
     long_description=long_description,
     long_description_content_type="text/markdown",

tests/test_generate_url.py

@@ -325,6 +325,20 @@ def test_url_signed_with_expire_in_seconds(self):
         }
         url = self.client.url(options)
         self.assertIn("ik-t", url)
+    
+    def test_url_signed_with_expire_in_seconds_with_diacritic(self):
+        options = {
+            "path": "/four-penguins-with-é.webp",
+            "transformation": [
+                {
+                    "width": "400",
+                },
+            ],
+            "signed": True,
+            "expire_seconds": 100,
+        }
+        url = self.client.url(options)
+        self.assertIn("ik-t", url)
 
     def test_generate_url_with_path_and_src_uses_path(self):
         """