From 4ed27ea381fa0f44ecb6c7a6d120ea6b66a13ff1 Mon Sep 17 00:00:00 2001 From: Ugo Date: Wed, 5 Mar 2025 12:20:36 +0100 Subject: [PATCH 1/2] fix(docker-build): secrets --- .github/workflows/docker-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index db26645..6ea803d 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -69,8 +69,8 @@ jobs: - name: Login to Docker Hub uses: docker/login-action@v3 with: - username: ${{ inputs.dockerhub-username }} - password: ${{ inputs.dockerhub-pat }} + username: ${{ secrets.DOCKERHUB_USERNAME }} + password: ${{ secrets.DOCKERHUB_PAT }} - name: Set up QEMU uses: docker/setup-qemu-action@v3 From 5e50380ce55cec9619c05fae5683e31718d191c8 Mon Sep 17 00:00:00 2001 From: Ugo Date: Wed, 5 Mar 2025 12:29:39 +0100 Subject: [PATCH 2/2] fix(docker-build): docker secrets instead inputs --- .github/workflows/docker-build.yml | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index 6ea803d..7fe5781 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -3,22 +3,19 @@ name: Build and Push Docker Image on: workflow_call: inputs: - dockerhub-username: - description: 'DockerHub username' - required: true - type: string - dockerhub-pat: - description: 'DockerHub personal access token' - required: true - type: string dockerfile: description: 'Path to Dockerfile' - required: true + default: 'Dockerfile' type: string image-name: - description: 'Docker image name' - required: true + description: 'Name of Docker Image' type: string + required: true + secrets: + dockerhub-username: + required: true + dockerhub-pat: + required: true jobs: build-and-push: @@ -69,8 +66,8 @@ jobs: - name: Login to Docker Hub uses: docker/login-action@v3 with: - username: ${{ secrets.DOCKERHUB_USERNAME }} - password: ${{ secrets.DOCKERHUB_PAT }} + username: ${{ secrets.dockerhub-username }} + password: ${{ secrets.dockerhub-pat }} - name: Set up QEMU uses: docker/setup-qemu-action@v3