fix: Ensure configType is set correctly within the form

Author: pulpdrew

packages/app/src/components/ChartEditor/types.ts

@@ -23,6 +23,7 @@ export type SavedChartConfigWithSelectArray = Omit<
  * arrays. `series` stores the array `select` data for the form.
  **/
 export type ChartEditorFormState = Partial<BuilderSavedChartConfig> &
-  Partial<RawSqlSavedChartConfig> & {
+  Partial<Omit<RawSqlSavedChartConfig, 'configType'>> & {
     series: SavedChartConfigWithSelectArray['select'];
+    configType?: 'sql' | 'builder';
   };

packages/app/src/components/ChartEditor/utils.ts

@@ -135,7 +135,7 @@ export function convertSavedChartConfigToFormState(
 ): ChartEditorFormState {
   return {
     ...config,
-    configType: isRawSqlSavedChartConfig(config) ? 'sql' : undefined,
+    configType: isRawSqlSavedChartConfig(config) ? 'sql' : 'builder',
     series:
       isBuilderSavedChartConfig(config) && Array.isArray(config.select)
         ? config.select.map(s => ({

packages/app/src/components/DBEditTimeChartForm.tsx

@@ -16,7 +16,6 @@ import { zodResolver } from '@hookform/resolvers/zod';
 import { tcFromSource } from '@hyperdx/common-utils/dist/core/metadata';
 import {
   isBuilderChartConfig,
-  isBuilderSavedChartConfig,
   isRawSqlChartConfig,
   isRawSqlSavedChartConfig,
 } from '@hyperdx/common-utils/dist/guards';
@@ -1063,7 +1062,7 @@ export default function EditTimeChartForm({
                 <SegmentedControl
                   value={value === 'sql' ? 'sql' : 'builder'}
                   onChange={(value: string) => {
-                    onChange(value == 'sql' ? 'sql' : undefined);
+                    onChange(value == 'sql' ? 'sql' : 'builder');
                   }}
                   data={[
                     { label: 'Builder', value: 'builder' },