Which area(s) of Hypercerts are affected? (leave empty if unsure)
No response
To Reproduce
.
Describe the Bug
Reported by CodeRabbit:
packages/sdk-core/src/auth/permissions.ts (2)
1148-1151: hasAllPermissions should use hasPermission for wildcard support.
This function uses exact string matching via permissions.includes(required), which doesn't leverage the wildcard matching implemented in hasPermission. A user with repo:* scope won't be recognized as having repo:app.bsky.feed.post permission.
🔧 Proposed fix
1167-1170: hasAnyPermission should use hasPermission for wildcard support.
Same issue as hasAllPermissions — uses exact matching instead of wildcard-aware hasPermission. This creates inconsistent behavior across the permission-checking API.
🔧 Proposed fix
Expected Behavior
.
Which area(s) of Hypercerts are affected? (leave empty if unsure)
No response
To Reproduce
.
Describe the Bug
Reported by CodeRabbit:
packages/sdk-core/src/auth/permissions.ts (2)
1148-1151: hasAllPermissions should use hasPermission for wildcard support.
This function uses exact string matching via permissions.includes(required), which doesn't leverage the wildcard matching implemented in hasPermission. A user with repo:* scope won't be recognized as having repo:app.bsky.feed.post permission.
🔧 Proposed fix
1167-1170: hasAnyPermission should use hasPermission for wildcard support.
Same issue as hasAllPermissions — uses exact matching instead of wildcard-aware hasPermission. This creates inconsistent behavior across the permission-checking API.
🔧 Proposed fix
Expected Behavior
.