set proper filename when downloading

Author: globalworming

TODO.md

@@ -29,7 +29,7 @@
 
 - [x] send 404 for unknown links and don't log
 - [x] generate preview page as blurry jpeg. extracting the first page from the PDF does not reduce file size much
-- [ ] set proper filename for download
+- [x] set proper filename for download
 
 - [ ] circle e2e test
 

src/main/java/com/headissue/servlet/SeePdfs.java

@@ -63,12 +63,13 @@ public SeePdfs(
   }
 
   @Override
-  protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException, ServletException {
+  protected void doGet(HttpServletRequest req, HttpServletResponse resp)
+      throws IOException, ServletException {
     String accessId = getAccessId(req);
     Path accessYaml = getAccessYaml(accessId);
     if (Files.notExists(accessYaml)) {
-       req.getRequestDispatcher("/404").forward(req, resp);
-       return;
+      req.getRequestDispatcher("/404").forward(req, resp);
+      return;
     }
     AccessRule accessRule = yaml.loadAs(new FileInputStream(accessYaml.toFile()), AccessRule.class);
     if (isExpired(accessYaml)) {
@@ -147,6 +148,7 @@ private void writePdfFileResponse(
     reportDownload(accessRule, visitor);
     byte[] buffer = new byte[1024];
     resp.setContentType("application/pdf");
+    resp.setHeader("Content-Disposition", String.format("filename=\"%s\"", pdfPath.getFileName()));
     try (InputStream in = Files.newInputStream(pdfPath)) {
       OutputStream output = resp.getOutputStream();
       for (int length; (length = in.read(buffer)) > 0; ) {