Silence compilation warnings for github library

- remove unused imports
- disable star-is-type warning while we are supporting GHC 7

Author: andreasabel

github.cabal

@@ -58,7 +58,13 @@ flag openssl
 
 library
   default-language:   Haskell2010
-  ghc-options:        -Wall
+  ghc-options:
+    -Wall
+  if impl(ghc >= 8.0)
+    ghc-options:
+      -Wcompat
+      -Wno-star-is-type
+        -- The star-is-type warning cannot be sensiblity addressed while supporting GHC 7.
   hs-source-dirs:     src
   default-extensions:
     DataKinds

src/GitHub/Data/Content.hs

@@ -13,7 +13,6 @@ import GitHub.Internal.Prelude
 import Prelude ()
 
 import Data.Aeson.Types (Pair)
-import Data.Maybe (maybe)
 import qualified Data.Text as T
 
 #if MIN_VERSION_aeson(2,0,0)

src/GitHub/Data/Deployments.hs

@@ -19,9 +19,6 @@ import Prelude ()
 import Control.Arrow (second)
 
 import Data.ByteString (ByteString)
-import Data.Maybe      (catMaybes)
-import Data.Text       (Text)
-import Data.Vector     (Vector)
 
 import GitHub.Data.Definitions (SimpleUser)
 import GitHub.Data.Id          (Id)

src/GitHub/Data/Reviews.hs

@@ -6,7 +6,6 @@ import GitHub.Data.URL (URL)
 import GitHub.Internal.Prelude
 import Prelude ()
 
-import Data.Text (Text)
 import qualified Data.Text as T
 
 data ReviewState

src/GitHub/Endpoints/PullRequests/Reviews.hs

@@ -12,7 +12,6 @@ module GitHub.Endpoints.PullRequests.Reviews
     ) where
 
 import GitHub.Data
-import GitHub.Data.Id (Id)
 import GitHub.Internal.Prelude
 import Prelude ()
 

src/GitHub/Endpoints/Repos/Deployments.hs

@@ -11,8 +11,6 @@ module GitHub.Endpoints.Repos.Deployments
 
 import Control.Arrow (second)
 
-import Data.Vector (Vector)
-
 import GitHub.Data
 import GitHub.Internal.Prelude
 

src/GitHub/Request.hs

@@ -80,8 +80,7 @@ import Control.Monad.Catch        (MonadCatch (..), MonadThrow)
 import Control.Monad.Trans.Class  (lift)
 import Control.Monad.Trans.Except (ExceptT (..), runExceptT)
 import Data.Aeson                 (eitherDecode)
-import Data.List                  (find, intercalate)
-import Data.String                (fromString)
+import Data.List                  (find)
 import Data.Tagged                (Tagged (..))
 import Data.Version               (showVersion)