Skip to content

Commit ff442d7

Browse files
committed
update
1 parent 4ddcc09 commit ff442d7

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

content/en/contributing-to-harmony.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,13 @@ Please write clear commit messages:
288288
1. Structure your commit messages clearly and include the purpose of the change.
289289
2. Use issue numbers for tracking, e.g., `Fix bug in NLP model (#54)`. Github will detect the # in the message and automatically display your commit under the corresponding issue, which means that anyone can easily see that a particular issue has related commits, and vice versa.
290290

291+
#### What is not a good pull request
292+
293+
Sometimes we receive pull requests which modify 18 files and look like they're rewriting the entire project. On looking through, often the contributor has accidentally committed files that were just part of their experimentation, or absolute paths within their computer. Or they rewrite a part of the project unrelated to what they're working on.
294+
295+
It is very hard to review a pull request like this. With so many changes, we cannot easily identify if any changes have a side effect. In addition, if anyone else is working on a part of the project affected by your changes, it will be hard to resolve conflicts.
296+
297+
Please avoid using commands like `git add *` which adds all files in the directory - try to ensure that every file is added individually. You can always reach out to the Harmony team for a discussion.
291298

292299
#### Help on Git and pull requests
293300

0 commit comments

Comments
 (0)