-
-
Notifications
You must be signed in to change notification settings - Fork 859
Improve testing instructions in "How to Review Pull Requests" page #8552
Copy link
Copy link
Open
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueFeature: Onboarding/Contributing.mdFeature: WikiReady for Prioritizationrole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.25ptCan be done in 0.5 to 1.5 hoursCan be done in 0.5 to 1.5 hours
Milestone
Metadata
Metadata
Assignees
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueFeature: Onboarding/Contributing.mdFeature: WikiReady for Prioritizationrole: back end/devOpsTasks for back-end developersTasks for back-end developersrole: front endTasks for front end developersTasks for front end developerssize: 0.25ptCan be done in 0.5 to 1.5 hoursCan be done in 0.5 to 1.5 hours
Type
Projects
Status
Ready for Prioritization
Overview
In How to Review Pull Requests documentation, the Step 3: View the changes in the browser section mentions opening up the branch in your browser's
localhost:4000but does not mention Docker or link to the Docker instructions in the contributing guide. Without any mention of Docker, onboarded users reviewing their first pull request may have trouble following documentation or properly testing code, resulting in delays.Action Items
With this revised version:
Resources/Instructions
Additional Notes
Since we want to make sure any edits to existing wiki pages end up in the new website-wiki, please follow the instructions in https://github.com/hackforla/website/wiki/How-to-Contribute-to-the-Wiki
To make changes to the wiki directly, follow the instructions in this section of GitHub's documentation on Editing wiki pages.