suggestion_list: change threshold to be coefficient of input length

Replicates graphql/graphql-js@4c10844

Author: Cito

docs/usage/queries.rst

@@ -70,7 +70,7 @@ Let's see what happens when we make a mistake in the query, by querying a non-ex
         {
           human(id: "1000") {
             name
-            homeTown
+            homePlace
           }
         }
         """)
@@ -79,7 +79,7 @@ Let's see what happens when we make a mistake in the query, by querying a non-ex
 You will get the following result as output::
 
     ExecutionResult(data=None, errors=[GraphQLError(
-        "Cannot query field 'homeTown' on type 'Human'. Did you mean 'homePlanet'?",
+        "Cannot query field 'homePlace' on type 'Human'. Did you mean 'homePlanet'?",
         locations=[SourceLocation(line=5, column=9)])])
 
 This is very helpful. Not only do we get the exact location of the mistake in the query,

docs/usage/validator.rst

@@ -14,7 +14,7 @@ GraphQL specification. You can also run the validation step manually by calling
         {
           human(id: NEWHOPE) {
             name
-            homeTown
+            homePlace
             friends
           }
         }
@@ -27,7 +27,7 @@ In this case, we will get::
         'String cannot represent a non string value: NEWHOPE',
         locations=[SourceLocation(line=3, column=17)]),
      GraphQLError(
-        "Cannot query field 'homeTown' on type 'Human'."
+        "Cannot query field 'homePlace' on type 'Human'."
          " Did you mean 'homePlanet'?",
          locations=[SourceLocation(line=5, column=9)]),
      GraphQLError(

src/graphql/pyutils/suggestion_list.py

@@ -12,9 +12,8 @@ def suggestion_list(input_: str, options: Collection[str]) -> List[str]:
     options_by_distance = {}
     lexical_distance = LexicalDistance(input_)
 
-    input_threshold = len(input_) // 2
+    threshold = int(len(input_) * 0.4) + 1
     for option in options:
-        threshold = max(input_threshold, len(option) // 2, 1)
         distance = lexical_distance.measure(option, threshold)
         if distance is not None:
             options_by_distance[option] = distance

tests/benchmarks/test_validate_invalid_gql.py

@@ -27,10 +27,7 @@ def test_validate_invalid_query(benchmark, big_schema_sdl):  # noqa: F811
             "message": "Cannot query field 'unknownField' on type 'Query'.",
             "locations": [(3, 11)],
         },
-        {
-            "message": "Unknown type 'unknownType'. Did you mean 'UnknownSignature'?",
-            "locations": [(4, 18)],
-        },
+        {"message": "Unknown type 'unknownType'.", "locations": [(4, 18)]},
         {"message": "Unknown fragment 'unknownFragment'.", "locations": [(6, 16)]},
         {"message": "Unknown type 'anotherUnknownType'.", "locations": [(10, 34)]},
         {"message": "Fragment 'TestFragment' is never used.", "locations": [(10, 9)]},

tests/pyutils/test_suggestion_list.py

@@ -38,7 +38,7 @@ def returns_options_with_transpositions():
         expect_suggestions("214365879", ["123456789"], ["123456789"])
 
     def returns_options_sorted_based_on_lexical_distance():
-        expect_suggestions("abc", ["a", "ab", "abc"], ["abc", "ab"])
+        expect_suggestions("abc", ["a", "ab", "abc"], ["abc", "ab", "a"])
 
         expect_suggestions(
             "GraphQl",

tests/test_docs.py

@@ -149,7 +149,7 @@ def executing_queries(capsys):
         assert out == expected_result(queries)
 
         bad_query = queries.pop(0)
-        assert "homeTown" in bad_query
+        assert "homePlace" in bad_query
         exec(bad_query, scope)
         out, err = capsys.readouterr()
         assert not err

tests/type/test_definition.py

@@ -1154,14 +1154,14 @@ def parses_an_enum():
             enum_type.parse_literal(StringValueNode(value="BAR"))
         assert exc_info.value.message == (
             "Enum 'SomeEnum' cannot represent non-enum value: \"BAR\"."
-            " Did you mean the enum value 'BAR'?"
+            " Did you mean the enum value 'BAR' or 'BAZ'?"
         )
         assert enum_type.parse_literal(EnumValueNode(value="BAZ")) is None
         with raises(GraphQLError) as exc_info:
             enum_type.parse_literal(StringValueNode(value="BAZ"))
         assert exc_info.value.message == (
             "Enum 'SomeEnum' cannot represent non-enum value: \"BAZ\"."
-            " Did you mean the enum value 'BAZ'?"
+            " Did you mean the enum value 'BAZ' or 'BAR'?"
         )
 
     def accepts_an_enum_type_with_ast_node_and_extension_ast_nodes():

tests/type/test_enum.py

@@ -175,7 +175,7 @@ def does_not_accept_values_with_incorrect_casing():
             [
                 {
                     "message": "Value 'green' does not exist in 'Color' enum."
-                    " Did you mean the enum value 'GREEN'?",
+                    " Did you mean the enum value 'GREEN' or 'RED'?",
                     "locations": [(1, 23)],
                 }
             ],

tests/validation/test_values_of_correct_type.py

@@ -997,16 +997,16 @@ def partial_object_unknown_field_arg():
                   complicatedArgs {
                     complexArgField(complexArg: {
                       requiredField: true,
-                      unknownField: "value"
+                      invalidField: "value"
                     })
                   }
                 }
                 """,
                 [
                     {
-                        "message": "Field 'unknownField'"
+                        "message": "Field 'invalidField'"
                         " is not defined by type 'ComplexInput'."
-                        " Did you mean 'booleanField', 'intField', or 'nonNullField'?",
+                        " Did you mean 'intField'?",
                         "locations": [(6, 23)],
                     },
                 ],