find_breaking_changes: add check for removing repeatable from directive

Replicates graphql/graphql-js@69c4a09

Author: Cito

src/graphql/utilities/find_breaking_changes.py

@@ -56,7 +56,8 @@ class BreakingChangeType(Enum):
     DIRECTIVE_REMOVED = 50
     DIRECTIVE_ARG_REMOVED = 51
     REQUIRED_DIRECTIVE_ARG_ADDED = 52
-    DIRECTIVE_LOCATION_REMOVED = 53
+    DIRECTIVE_REPEATABLE_REMOVED = 53
+    DIRECTIVE_LOCATION_REMOVED = 54
 
 
 class DangerousChangeType(Enum):
@@ -154,6 +155,14 @@ def find_directive_changes(
                 )
             )
 
+        if old_directive.is_repeatable and not new_directive.is_repeatable:
+            schema_changes.append(
+                BreakingChange(
+                    BreakingChangeType.DIRECTIVE_REPEATABLE_REMOVED,
+                    f"Repeatable flag was removed from {old_directive.name}.",
+                )
+            )
+
         for location in old_directive.locations:
             if location not in new_directive.locations:
                 schema_changes.append(

tests/utilities/test_find_breaking_changes.py

@@ -661,6 +661,8 @@ def should_detect_all_breaking_changes():
 
             directive @NonNullDirectiveAdded on FIELD_DEFINITION
 
+            directive @DirectiveThatWasRepeatable repeatable on FIELD_DEFINITION
+
             directive @DirectiveName on FIELD_DEFINITION | QUERY
 
             type ArgThatChanges {
@@ -697,6 +699,8 @@ def should_detect_all_breaking_changes():
 
             directive @NonNullDirectiveAdded(arg1: Boolean!) on FIELD_DEFINITION
 
+            directive @DirectiveThatWasRepeatable on FIELD_DEFINITION
+
             directive @DirectiveName on FIELD_DEFINITION
 
             type ArgThatChanges {
@@ -773,6 +777,10 @@ def should_detect_all_breaking_changes():
                 BreakingChangeType.REQUIRED_DIRECTIVE_ARG_ADDED,
                 "A required arg arg1 on directive NonNullDirectiveAdded was added.",
             ),
+            (
+                BreakingChangeType.DIRECTIVE_REPEATABLE_REMOVED,
+                "Repeatable flag was removed from DirectiveThatWasRepeatable.",
+            ),
             (
                 BreakingChangeType.DIRECTIVE_LOCATION_REMOVED,
                 "QUERY was removed from DirectiveName.",
@@ -858,6 +866,26 @@ def should_detect_if_an_optional_directive_argument_was_added():
             )
         ]
 
+    def should_detect_removal_of_repeatable_flag():
+        old_schema = build_schema(
+            """
+            directive @DirectiveName repeatable on OBJECT
+            """
+        )
+
+        new_schema = build_schema(
+            """
+            directive @DirectiveName on OBJECT
+            """
+        )
+
+        assert find_breaking_changes(old_schema, new_schema) == [
+            (
+                BreakingChangeType.DIRECTIVE_REPEATABLE_REMOVED,
+                "Repeatable flag was removed from DirectiveName.",
+            )
+        ]
+
     def should_detect_locations_removed_from_a_directive():
         old_schema = build_schema(
             """