Skip to content

Commit 7492d2a

Browse files
committed
Minor review comments
1 parent 5e42344 commit 7492d2a

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/main/java/org/dataloader/strategy/BreadthFirstChainedDispatchStrategy.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import org.dataloader.DataLoaderRegistry;
44
import org.dataloader.DispatchStrategy;
5+
import org.dataloader.impl.Assertions;
56
import org.jspecify.annotations.Nullable;
67

78
import java.time.Duration;
@@ -115,11 +116,11 @@ public static class Builder {
115116
private final ScheduledExecutorService scheduledExecutorService;
116117

117118
public Builder(ScheduledExecutorService scheduledExecutorService) {
118-
this.scheduledExecutorService = scheduledExecutorService;
119+
this.scheduledExecutorService = Assertions.nonNull(scheduledExecutorService);
119120
}
120121

121122
public Builder setFallbackTimeout(Duration fallbackTimeout) {
122-
this.fallbackTimeout = fallbackTimeout;
123+
this.fallbackTimeout = Assertions.nonNull(fallbackTimeout);
123124
return this;
124125
}
125126

src/test/java/org/dataloader/strategy/BreadthFirstChainedDispatchStrategyTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public void setUp() {
3131

3232
@AfterEach
3333
public void cleanUp() {
34-
this.scheduledExecutorService.shutdown();
34+
this.scheduledExecutorService.shutdownNow();
3535
}
3636

3737
@Test

0 commit comments

Comments
 (0)