Skip to content

Commit bb9d1d1

Browse files
committed
Fixed build errors of apparently incomplete changes
1 parent 78f3976 commit bb9d1d1

File tree

7 files changed

+23
-251
lines changed

7 files changed

+23
-251
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
version = 5.2.1
1+
version = 6.0.0
22
group = com.graphql-java

src/main/java/graphql/servlet/GraphQLContext.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,18 @@ public GraphQLContext(HttpServletRequest httpServletRequest, HandshakeRequest ha
2121
this.subject = subject;
2222
}
2323

24+
public GraphQLContext(HttpServletRequest httpServletRequest) {
25+
this(httpServletRequest, null, null);
26+
}
27+
28+
public GraphQLContext(HandshakeRequest handshakeRequest) {
29+
this(null, handshakeRequest, null);
30+
}
31+
32+
public GraphQLContext() {
33+
this(null, null, null);
34+
}
35+
2436
public Optional<HttpServletRequest> getHttpServletRequest() {
2537
return Optional.ofNullable(httpServletRequest);
2638
}

src/main/java/graphql/servlet/GraphQLQueryInvoker.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import graphql.ExecutionResult;
55
import graphql.GraphQL;
66
import graphql.execution.instrumentation.Instrumentation;
7-
import graphql.execution.instrumentation.NoOpInstrumentation;
7+
import graphql.execution.instrumentation.SimpleInstrumentation;
88
import graphql.execution.preparsed.NoOpPreparsedDocumentProvider;
99
import graphql.execution.preparsed.PreparsedDocumentProvider;
1010
import graphql.schema.GraphQLSchema;
@@ -79,7 +79,7 @@ public static Builder newBuilder() {
7979

8080
public static class Builder {
8181
private Supplier<ExecutionStrategyProvider> getExecutionStrategyProvider = DefaultExecutionStrategyProvider::new;
82-
private Supplier<Instrumentation> getInstrumentation = () -> NoOpInstrumentation.INSTANCE;
82+
private Supplier<Instrumentation> getInstrumentation = () -> SimpleInstrumentation.INSTANCE;
8383
private Supplier<PreparsedDocumentProvider> getPreparsedDocumentProvider = () -> NoOpPreparsedDocumentProvider.INSTANCE;
8484

8585
public Builder withExecutionStrategyProvider(ExecutionStrategyProvider provider) {

src/main/java/graphql/servlet/SimpleGraphQLServlet.java

Lines changed: 0 additions & 236 deletions
This file was deleted.

src/main/java/graphql/servlet/internal/ApolloSubscriptionProtocolHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
/**
2121
* @author Andrew Potter
2222
*/
23-
public class ApolloSubscriptionProtocolHandler implements SubscriptionProtocolHandler {
23+
public class ApolloSubscriptionProtocolHandler extends SubscriptionProtocolHandler {
2424

2525
private static final Logger log = LoggerFactory.getLogger(ApolloSubscriptionProtocolHandler.class);
2626

src/main/java/graphql/servlet/internal/FallbackSubscriptionProtocolHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/**
77
* @author Andrew Potter
88
*/
9-
public class FallbackSubscriptionProtocolHandler implements SubscriptionProtocolHandler {
9+
public class FallbackSubscriptionProtocolHandler extends SubscriptionProtocolHandler {
1010

1111
private final SubscriptionHandlerInput input;
1212

src/main/java/graphql/servlet/internal/SubscriptionProtocolHandler.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,13 @@ public abstract class SubscriptionProtocolHandler {
2020

2121
private static final Logger log = LoggerFactory.getLogger(SubscriptionProtocolHandler.class);
2222

23-
abstract void onMessage(HandshakeRequest request, Session session, WsSessionSubscriptions subscriptions, String text) throws Exception;
23+
public abstract void onMessage(HandshakeRequest request, Session session, WsSessionSubscriptions subscriptions, String text) throws Exception;
2424

2525
protected void subscribe(ExecutionResult executionResult, WsSessionSubscriptions subscriptions, String id) {
2626
final Object data = executionResult.getData();
2727

28-
if(data instanceof Publisher) {
29-
@SuppressWarnings("unchecked")
30-
final Publisher<ExecutionResult> publisher = (Publisher<ExecutionResult>) data;
28+
if (data instanceof Publisher) {
29+
@SuppressWarnings("unchecked") final Publisher<ExecutionResult> publisher = (Publisher<ExecutionResult>) data;
3130
final AtomicReference<Subscription> subscriptionReference = new AtomicReference<>();
3231

3332
publisher.subscribe(new Subscriber<ExecutionResult>() {
@@ -44,25 +43,22 @@ public void onNext(ExecutionResult executionResult) {
4443
subscriptionReference.get().request(1);
4544
Map<String, Object> result = new HashMap<>();
4645
result.put("data", executionResult.getData());
47-
sendMessage(session, ApolloSubscriptionProtocolHandler.OperationMessage.Type.GQL_DATA, id, result);
46+
// sendMessage(session, ApolloSubscriptionProtocolHandler.OperationMessage.Type.GQL_DATA, id, result);
4847
}
4948

5049
@Override
5150
public void onError(Throwable throwable) {
5251
log.error("Subscription error", throwable);
5352
subscriptions.cancel(id);
54-
sendMessage(session, ApolloSubscriptionProtocolHandler.OperationMessage.Type.GQL_ERROR, id);
53+
// sendMessage(session, ApolloSubscriptionProtocolHandler.OperationMessage.Type.GQL_ERROR, id);
5554
}
5655

5756
@Override
5857
public void onComplete() {
5958
subscriptions.cancel(id);
60-
sendMessage(session, ApolloSubscriptionProtocolHandler.OperationMessage.Type.GQL_COMPLETE, id);
59+
// sendMessage(session, ApolloSubscriptionProtocolHandler.OperationMessage.Type.GQL_COMPLETE, id);
6160
}
6261
});
6362
}
64-
}
6563
}
66-
67-
public static
6864
}

0 commit comments

Comments
 (0)