From 2b7b27e21159288682fdce021350664dec192665 Mon Sep 17 00:00:00 2001 From: Manav Sharma Date: Sun, 1 Feb 2026 13:38:59 +0530 Subject: [PATCH 1/5] Modified test files --- .golangci.yml | 2 ++ github/pulls_test.go | 7 +++++ github/repos_releases_test.go | 7 +++++ github/search_test.go | 56 +++++++++++++++++++++++++++++++++++ scrape/apps_test.go | 8 +++-- 5 files changed, 78 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 1525db660ce..95ededfcabe 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -51,6 +51,8 @@ linters: - commentFormatting - deprecatedComment - paramTypeCombine + unparam: + check-exported: true goheader: values: regexp: diff --git a/github/pulls_test.go b/github/pulls_test.go index ea724cd5d6e..503b887ce3f 100644 --- a/github/pulls_test.go +++ b/github/pulls_test.go @@ -511,6 +511,13 @@ func TestPullRequestsService_Edit(t *testing.T) { _, _, err = client.PullRequests.Edit(ctx, "\n", "\n", -i, tt.input) return err }) + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.PullRequests.Edit(ctx, "o", "r", i, tt.input) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } } diff --git a/github/repos_releases_test.go b/github/repos_releases_test.go index 9eb0f6f03c2..66d754f2f59 100644 --- a/github/repos_releases_test.go +++ b/github/repos_releases_test.go @@ -778,6 +778,13 @@ func TestRepositoriesService_UploadReleaseAsset(t *testing.T) { _, _, err = client.Repositories.UploadReleaseAsset(ctx, "\n", "\n", int64(key), test.uploadOpts, file) return err }) + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Repositories.UploadReleaseAsset(ctx, "o", "r", int64(key), test.uploadOpts, file) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } } diff --git a/github/search_test.go b/github/search_test.go index 91a2bab401e..52c6f88946e 100644 --- a/github/search_test.go +++ b/github/search_test.go @@ -46,6 +46,14 @@ func TestSearchService_Repositories(t *testing.T) { if !cmp.Equal(result, want) { t.Errorf("Search.Repositories returned %+v, want %+v", result, want) } + const methodName = "Repositories" + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Search.Repositories(ctx, "blah", opts) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } func TestSearchService_Repositories_coverage(t *testing.T) { @@ -171,6 +179,14 @@ func TestSearchService_Topics(t *testing.T) { if !cmp.Equal(result, want) { t.Errorf("Search.Topics returned %+v, want %+v", result, want) } + const methodName = "Topics" + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Search.Topics(ctx, "blah", opts) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } func TestSearchService_Topics_coverage(t *testing.T) { @@ -216,6 +232,14 @@ func TestSearchService_Commits(t *testing.T) { if !cmp.Equal(result, want) { t.Errorf("Search.Commits returned %+v, want %+v", result, want) } + const methodName = "Commits" + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Search.Commits(ctx, "blah", opts) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } func TestSearchService_Commits_coverage(t *testing.T) { @@ -263,6 +287,14 @@ func TestSearchService_Issues(t *testing.T) { if !cmp.Equal(result, want) { t.Errorf("Search.Issues returned %+v, want %+v", result, want) } + const methodName = "Issues" + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Search.Issues(ctx, "blah", opts) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } func TestSearchService_Issues_advancedSearch(t *testing.T) { @@ -422,6 +454,14 @@ func TestSearchService_Users(t *testing.T) { if !cmp.Equal(result, want) { t.Errorf("Search.Users returned %+v, want %+v", result, want) } + const methodName = "Users" + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Search.Users(ctx, "blah", opts) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } func TestSearchService_Users_coverage(t *testing.T) { @@ -469,6 +509,14 @@ func TestSearchService_Code(t *testing.T) { if !cmp.Equal(result, want) { t.Errorf("Search.Code returned %+v, want %+v", result, want) } + const methodName = "Code" + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Search.Code(ctx, "blah", opts) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } func TestSearchService_Code_coverage(t *testing.T) { @@ -583,6 +631,14 @@ func TestSearchService_Labels(t *testing.T) { if !cmp.Equal(result, want) { t.Errorf("Search.Labels returned %+v, want %+v", result, want) } + const methodName = "Labels" + testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { + got, resp, err := client.Search.Labels(ctx, 1234, "blah", opts) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) + } + return resp, err + }) } func TestSearchService_Labels_coverage(t *testing.T) { diff --git a/scrape/apps_test.go b/scrape/apps_test.go index 07fcfd4960b..16426eab261 100644 --- a/scrape/apps_test.go +++ b/scrape/apps_test.go @@ -98,14 +98,18 @@ func Test_CreateApp(t *testing.T) { w.WriteHeader(http.StatusCreated) }) - if _, err := client.CreateApp(&AppManifest{ + resp, err := client.CreateApp(&AppManifest{ URL: github.Ptr("https://example.com"), HookAttributes: map[string]string{ "url": "https://example.com/hook", }, - }, ""); err != nil { + }, "") + if err != nil { t.Fatalf("CreateApp: %v", err) } + if got, want := resp.StatusCode, http.StatusCreated; got != want { + t.Errorf("CreateApp returned status code %d, want %d", got, want) + } } func Test_CreateAppWithOrg(t *testing.T) { From 0583d6e4817d6e76799f5935bfd3b7fbc141323d Mon Sep 17 00:00:00 2001 From: Manav Sharma Date: Sun, 1 Feb 2026 14:56:05 +0530 Subject: [PATCH 2/5] Used %v instead of %d --- scrape/apps_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scrape/apps_test.go b/scrape/apps_test.go index 16426eab261..ead09a79ac5 100644 --- a/scrape/apps_test.go +++ b/scrape/apps_test.go @@ -108,7 +108,7 @@ func Test_CreateApp(t *testing.T) { t.Fatalf("CreateApp: %v", err) } if got, want := resp.StatusCode, http.StatusCreated; got != want { - t.Errorf("CreateApp returned status code %d, want %d", got, want) + t.Errorf("CreateApp returned status code %v, want %v", got, want) } } From 17eff3fbca76837b0f86126500ffb4f20683803b Mon Sep 17 00:00:00 2001 From: Manav Sharma Date: Sun, 1 Feb 2026 19:25:44 +0530 Subject: [PATCH 3/5] Corrected Link --- scrape/apps_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scrape/apps_test.go b/scrape/apps_test.go index ead09a79ac5..18046c9760a 100644 --- a/scrape/apps_test.go +++ b/scrape/apps_test.go @@ -94,7 +94,7 @@ func Test_CreateApp(t *testing.T) { t.Parallel() client, mux := setup(t) - mux.HandleFunc("/apps/settings/new", func(w http.ResponseWriter, _ *http.Request) { + mux.HandleFunc("/settings/apps/new", func(w http.ResponseWriter, _ *http.Request) { w.WriteHeader(http.StatusCreated) }) From 00bf325a2258cbb2223dd554a7a0b1e12881a9b7 Mon Sep 17 00:00:00 2001 From: Manav Sharma Date: Sun, 1 Feb 2026 20:43:58 +0530 Subject: [PATCH 4/5] Moved test functtion out of for loop --- github/repos_releases_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/github/repos_releases_test.go b/github/repos_releases_test.go index 66d754f2f59..ba73826c8b1 100644 --- a/github/repos_releases_test.go +++ b/github/repos_releases_test.go @@ -778,14 +778,14 @@ func TestRepositoriesService_UploadReleaseAsset(t *testing.T) { _, _, err = client.Repositories.UploadReleaseAsset(ctx, "\n", "\n", int64(key), test.uploadOpts, file) return err }) - testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { - got, resp, err := client.Repositories.UploadReleaseAsset(ctx, "o", "r", int64(key), test.uploadOpts, file) - if got != nil { - t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) - } - return resp, err - }) } + testNewRequestAndDoFailure(t, "UploadReleaseAsset", client, func() (*Response, error) { + got, resp, err := client.Repositories.UploadReleaseAsset(t.Context(), "o", "r", 1, defaultUploadOptions, openTestFile(t, "upload.txt", "Upload me !\n")) + if got != nil { + t.Errorf("testNewRequestAndDoFailure UploadReleaseAsset = %#v, want nil", got) + } + return resp, err + }) } func TestRepositoryReleaseRequest_Marshal(t *testing.T) { From d8adb5d97dd65d2d12a333f7a136ff16533b3f36 Mon Sep 17 00:00:00 2001 From: Manav Sharma Date: Sun, 1 Feb 2026 22:22:20 +0530 Subject: [PATCH 5/5] Moved test function outside the loop --- github/pulls_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/github/pulls_test.go b/github/pulls_test.go index 503b887ce3f..b34140f8c71 100644 --- a/github/pulls_test.go +++ b/github/pulls_test.go @@ -511,14 +511,14 @@ func TestPullRequestsService_Edit(t *testing.T) { _, _, err = client.PullRequests.Edit(ctx, "\n", "\n", -i, tt.input) return err }) - testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { - got, resp, err := client.PullRequests.Edit(ctx, "o", "r", i, tt.input) - if got != nil { - t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) - } - return resp, err - }) } + testNewRequestAndDoFailure(t, "Edit", client, func() (*Response, error) { + got, resp, err := client.PullRequests.Edit(t.Context(), "o", "r", 1, &PullRequest{}) + if got != nil { + t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", "Edit", got) + } + return resp, err + }) } func TestPullRequestsService_Edit_invalidOwner(t *testing.T) {