From 52dba4d68fb3519e1cbfbc41e85c95708ef75ab7 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:26:18 -0500 Subject: [PATCH 01/31] link: Auth Code grant / flow type Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/authn-adk-all-in-one/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/authn-adk-all-in-one/README.md b/contributing/samples/authn-adk-all-in-one/README.md index fa5db4e772..e70278de04 100644 --- a/contributing/samples/authn-adk-all-in-one/README.md +++ b/contributing/samples/authn-adk-all-in-one/README.md @@ -28,7 +28,7 @@ This folder comes with - ### Details -You can read about the Auth Code grant / flow type in detail [here](https://developer.okta.com/blog/2018/04/10/oauth-authorization-code-grant-type). But for the purpose of this demo, following steps take place +You can read about the [Auth Code grant / flow type](https://developer.okta.com/blog/2018/04/10/oauth-authorization-code-grant-type) in detail. But for the purpose of this demo, following steps take place 1. The user asks the agent to find hotels in "New York". 2. Agent realizes (based on LLM response) that it needs to call a tool and that the tool needs authentication. From 418a2ff3f369651e21ef0053be4c86e8f42fe452 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:17:58 -0500 Subject: [PATCH 02/31] spelling: ; otherwise, Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/adk_answering_agent/agent.py | 2 +- .../samples/adk_documentation/adk_docs_updater/agent.py | 4 ++-- contributing/samples/agent_engine_code_execution/README | 2 +- contributing/samples/hello_world_apigeellm/README.md | 2 +- .../multi_agent_loop_config/writer_agents/critic_agent.yaml | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/contributing/samples/adk_answering_agent/agent.py b/contributing/samples/adk_answering_agent/agent.py index 59abeb8c57..1f9c58d71a 100644 --- a/contributing/samples/adk_answering_agent/agent.py +++ b/contributing/samples/adk_answering_agent/agent.py @@ -61,7 +61,7 @@ 3. **Decide whether to respond**: * If all the following conditions are met, try to add a comment to the - discussion, otherwise, do not respond: + discussion; otherwise, do not respond: - The discussion is not closed. - The latest comment is not from you or other agents (marked as "Response from XXX Agent"). diff --git a/contributing/samples/adk_documentation/adk_docs_updater/agent.py b/contributing/samples/adk_documentation/adk_docs_updater/agent.py index afa5565127..d61e4e5a93 100644 --- a/contributing/samples/adk_documentation/adk_docs_updater/agent.py +++ b/contributing/samples/adk_documentation/adk_docs_updater/agent.py @@ -69,13 +69,13 @@ # 3. Workflow 1. Always call the `clone_or_pull_repo` tool to make sure the ADK docs and codebase repos exist in the local folder {LOCAL_REPOS_DIR_PATH}/repo_name and are the latest version. 2. Read and analyze the issue specified by user. - - If user only specified the issue number, call the `get_issue` tool to get the issue details, otherwise use the issue details provided by user directly. + - If user only specified the issue number, call the `get_issue` tool to get the issue details; otherwise, use the issue details provided by user directly. 3. If the issue contains instructions about how to update the ADK docs, follow the instructions to update the ADK docs. 4. Understand the doc update instructions. - Ignore and skip the instructions about updating API reference docs, since it will be automatically generated by the ADK team. 5. Read the doc to update using the `read_local_git_repo_file_content` tool from the local ADK docs repo under {LOCAL_REPOS_DIR_PATH}/{DOC_REPO}. 6. Find the related Python files in the ADK Python codebase. - - If the doc update instructions specify paths to the Python files, use them directly, otherwise use a list of regex search patterns to find the related Python files through the `search_local_git_repo` tool. + - If the doc update instructions specify paths to the Python files, use them directly; otherwise, use a list of regex search patterns to find the related Python files through the `search_local_git_repo` tool. - You should focus on the main ADK Python codebase, ignore the changes in tests or other auxiliary files. - You should find all the related Python files, not only the most relevant one. 7. Read the specified or found Python files using the `read_local_git_repo_file_content` tool to find all the related code. diff --git a/contributing/samples/agent_engine_code_execution/README b/contributing/samples/agent_engine_code_execution/README index f593c5849f..8d5a444237 100644 --- a/contributing/samples/agent_engine_code_execution/README +++ b/contributing/samples/agent_engine_code_execution/README @@ -9,7 +9,7 @@ This sample data science agent uses Agent Engine Code Execution Sandbox to execu * 1. Follow https://cloud.google.com/vertex-ai/generative-ai/docs/agent-engine/code-execution/overview to create a code execution sandbox environment. -* 2. Replace the SANDBOX_RESOURCE_NAME with the one you just created. If you dont want to create a new sandbox environment directly, the Agent Engine Code Execution Sandbox will create one for you by default using the AGENT_ENGINE_RESOURCE_NAME you specified, however, please ensure to clean up sandboxes after use, otherwise, it will consume quotas. +* 2. Replace the SANDBOX_RESOURCE_NAME with the one you just created. If you dont want to create a new sandbox environment directly, the Agent Engine Code Execution Sandbox will create one for you by default using the AGENT_ENGINE_RESOURCE_NAME you specified, however, please ensure to clean up sandboxes after use; otherwise, it will consume quotas. ## Sample prompt diff --git a/contributing/samples/hello_world_apigeellm/README.md b/contributing/samples/hello_world_apigeellm/README.md index 41cfa50aaf..33fc3eeb32 100644 --- a/contributing/samples/hello_world_apigeellm/README.md +++ b/contributing/samples/hello_world_apigeellm/README.md @@ -61,7 +61,7 @@ Here are some examples of how to configure the model string in `agent.py` to ach - `model="apigee/gemini-2.5-flash"` - Uses the default API version. - - Provider is Vertex AI if `GOOGLE_GENAI_USE_VERTEXAI` is true, otherwise Gemini. + - Provider is Vertex AI if `GOOGLE_GENAI_USE_VERTEXAI` is true; otherwise, Gemini. - `model="apigee/v1/gemini-2.5-flash"` - Uses API version `v1`. diff --git a/contributing/samples/multi_agent_loop_config/writer_agents/critic_agent.yaml b/contributing/samples/multi_agent_loop_config/writer_agents/critic_agent.yaml index b11b0ac518..9e7a3bf062 100644 --- a/contributing/samples/multi_agent_loop_config/writer_agents/critic_agent.yaml +++ b/contributing/samples/multi_agent_loop_config/writer_agents/critic_agent.yaml @@ -2,7 +2,7 @@ agent_class: LlmAgent name: CriticAgent model: gemini-2.5-pro -description: Reviews the current draft, providing critique if clear improvements are needed, otherwise signals completion. +description: Reviews the current draft, providing critique if clear improvements are needed; otherwise, signals completion. instruction: | You are a Constructive Critic AI reviewing a document draft (typically at least 10 sentences). Your goal is balanced feedback. From 42ee9664de42f7d360f7f80cc1a25703d57ff336 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:48:56 -0500 Subject: [PATCH 03/31] spelling: agents Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/live_agent_api_server_example/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/live_agent_api_server_example/readme.md b/contributing/samples/live_agent_api_server_example/readme.md index de5b0b5e92..0e524b37bd 100644 --- a/contributing/samples/live_agent_api_server_example/readme.md +++ b/contributing/samples/live_agent_api_server_example/readme.md @@ -16,7 +16,7 @@ the response is always audio. - Please ensure you grant the right mic/sound device permission to the terminal that runs the script. Sometimes, terminal inside VSCode etc dones't really work well. So try native terminals if you have permission issue. -- start api server first for your agent folder. For example, my anents are +- start api server first for your agent folder. For example, my agents are locoated in contributing/samples. So I will run `adk api_server contributing/samples/`. Keep this running. - then in a separate window, run `python3 live_agent_example.py` From 0d9803495cfbbc04243f086aa5d973b406268f0b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:18:21 -0500 Subject: [PATCH 04/31] spelling: an Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/adk_answering_agent/utils.py | 2 +- contributing/samples/adk_pr_triaging_agent/agent.py | 2 +- contributing/samples/adk_triaging_agent/agent.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contributing/samples/adk_answering_agent/utils.py b/contributing/samples/adk_answering_agent/utils.py index 9393d9c85a..dafebed272 100644 --- a/contributing/samples/adk_answering_agent/utils.py +++ b/contributing/samples/adk_answering_agent/utils.py @@ -128,7 +128,7 @@ def convert_gcs_to_https(gcs_uri: str) -> Optional[str]: base_url = "https://google.github.io/adk-docs/" if os.path.basename(path_after_docs) == "index.md": - # Use the directory path if it is a index file + # Use the directory path if it is an index file final_path_segment = os.path.dirname(path_after_docs) else: # Otherwise, use the file name without extension diff --git a/contributing/samples/adk_pr_triaging_agent/agent.py b/contributing/samples/adk_pr_triaging_agent/agent.py index 90f6b7cdc1..2203078f10 100644 --- a/contributing/samples/adk_pr_triaging_agent/agent.py +++ b/contributing/samples/adk_pr_triaging_agent/agent.py @@ -248,7 +248,7 @@ def add_comment_to_pr(pr_number: int, comment: str) -> dict[str, Any]: - If it's about tracing, label it with "tracing". - If it's agent orchestration, agent definition, label it with "core". - If it's about Model Context Protocol (e.g. MCP tool, MCP toolset, MCP session management etc.), label it with "mcp". - - If you can't find a appropriate labels for the PR, follow the previous instruction that starts with "IMPORTANT:". + - If you can't find an appropriate labels for the PR, follow the previous instruction that starts with "IMPORTANT:". Here is the contribution guidelines: `{CONTRIBUTING_MD}` diff --git a/contributing/samples/adk_triaging_agent/agent.py b/contributing/samples/adk_triaging_agent/agent.py index 4f5679c969..c4939371e9 100644 --- a/contributing/samples/adk_triaging_agent/agent.py +++ b/contributing/samples/adk_triaging_agent/agent.py @@ -185,7 +185,7 @@ def change_issue_type(issue_number: int, issue_type: str) -> dict[str, Any]: - If it's about agent engine, label it with "agent engine". - If it's about Model Context Protocol (e.g. MCP tool, MCP toolset, MCP session management etc.), label it with both "mcp" and "tools". - If it's about A2A integrations or workflows, label it with "a2a". - - If you can't find a appropriate labels for the issue, follow the previous instruction that starts with "IMPORTANT:". + - If you can't find an appropriate labels for the issue, follow the previous instruction that starts with "IMPORTANT:". Call the `add_label_and_owner_to_issue` tool to label the issue, which will also assign the issue to the owner of the label. From 42a8dd4a368180c6c7f25be54c33af68460024aa Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:27:35 -0500 Subject: [PATCH 05/31] spelling: at Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/agent_engine_code_execution/agent.py | 2 +- contributing/samples/custom_code_execution/agent.py | 2 +- contributing/samples/vertex_code_execution/agent.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contributing/samples/agent_engine_code_execution/agent.py b/contributing/samples/agent_engine_code_execution/agent.py index c626067e26..ae58ec8dc4 100644 --- a/contributing/samples/agent_engine_code_execution/agent.py +++ b/contributing/samples/agent_engine_code_execution/agent.py @@ -31,7 +31,7 @@ def base_system_instruction(): **Statefulness:** All code snippets are executed and the variables stays in the environment. You NEVER need to re-initialize variables. You NEVER need to reload files. You NEVER need to re-import libraries. **Output Visibility:** Always print the output of code execution to visualize results, especially for data exploration and analysis. For example: - - To look a the shape of a pandas.DataFrame do: + - To look at the shape of a pandas.DataFrame do: ```tool_code print(df.shape) ``` diff --git a/contributing/samples/custom_code_execution/agent.py b/contributing/samples/custom_code_execution/agent.py index b62a9717ba..5dbadcf53a 100644 --- a/contributing/samples/custom_code_execution/agent.py +++ b/contributing/samples/custom_code_execution/agent.py @@ -109,7 +109,7 @@ def base_system_instruction(): ``` **Output Visibility:** Always print the output of code execution to visualize results, especially for data exploration and analysis. For example: - - To look a the shape of a pandas.DataFrame do: + - To look at the shape of a pandas.DataFrame do: ```tool_code print(df.shape) ``` diff --git a/contributing/samples/vertex_code_execution/agent.py b/contributing/samples/vertex_code_execution/agent.py index 39ad65d3ac..573827c0ac 100644 --- a/contributing/samples/vertex_code_execution/agent.py +++ b/contributing/samples/vertex_code_execution/agent.py @@ -43,7 +43,7 @@ def base_system_instruction(): ``` **Output Visibility:** Always print the output of code execution to visualize results, especially for data exploration and analysis. For example: - - To look a the shape of a pandas.DataFrame do: + - To look at the shape of a pandas.DataFrame do: ```tool_code print(df.shape) ``` From eeb92ec158ef6337d2ccb1de29d2e61400cd0537 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:30:59 -0500 Subject: [PATCH 06/31] spelling: case-sensitive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../adk_agent_builder_assistant/tools/search_adk_source.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/adk_agent_builder_assistant/tools/search_adk_source.py b/contributing/samples/adk_agent_builder_assistant/tools/search_adk_source.py index b2bdf9b959..9d3a3a9397 100644 --- a/contributing/samples/adk_agent_builder_assistant/tools/search_adk_source.py +++ b/contributing/samples/adk_agent_builder_assistant/tools/search_adk_source.py @@ -46,7 +46,7 @@ async def search_adk_source( max_results: Maximum number of results to return (default: 20) context_lines: Number of context lines to include around matches (default: 3) - case_sensitive: Whether search should be case sensitive (default: False) + case_sensitive: Whether search should be case-sensitive (default: False) Returns: Dict containing search results: From 33b1743c9ae353276a59acde060f6f34ad25af7c Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:07:00 -0500 Subject: [PATCH 07/31] spelling: computer Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/computer_use/playwright.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/computer_use/playwright.py b/contributing/samples/computer_use/playwright.py index 1df542cc4f..89b216adf3 100644 --- a/contributing/samples/computer_use/playwright.py +++ b/contributing/samples/computer_use/playwright.py @@ -72,7 +72,7 @@ class PlaywrightComputer(BaseComputer): - """Conputer that controls Chromium via Playwright.""" + """Computer that controls Chromium via Playwright.""" def __init__( self, From a35592be391e9e4dfac4fa0794ac4ab688547101 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 20:53:28 -0500 Subject: [PATCH 08/31] spelling: config Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/core_basic_config/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/core_basic_config/README.md b/contributing/samples/core_basic_config/README.md index cde68d244a..2d4eea192d 100644 --- a/contributing/samples/core_basic_config/README.md +++ b/contributing/samples/core_basic_config/README.md @@ -1,4 +1,4 @@ -# Basic Confg-based Agent +# Basic Config-based Agent This sample only covers: From fd720f348051f3ae8641a2a0e7766b8e8a24e8c3 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 20:55:23 -0500 Subject: [PATCH 09/31] spelling: criteria Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../multi_agent_loop_config/writer_agents/critic_agent.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/multi_agent_loop_config/writer_agents/critic_agent.yaml b/contributing/samples/multi_agent_loop_config/writer_agents/critic_agent.yaml index 9e7a3bf062..a8594ecceb 100644 --- a/contributing/samples/multi_agent_loop_config/writer_agents/critic_agent.yaml +++ b/contributing/samples/multi_agent_loop_config/writer_agents/critic_agent.yaml @@ -12,7 +12,7 @@ instruction: | ``` **Task:** - Review the document for the following cretiria: + Review the document for the following criteria: - content length: at least 10 sentences; - clarity: the content must be clear; From 15dfd19c215e289fd59d1c38eaf15bba539de0c8 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 20:56:02 -0500 Subject: [PATCH 10/31] spelling: custom Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/core_custom_agent_config/my_agents.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/core_custom_agent_config/my_agents.py b/contributing/samples/core_custom_agent_config/my_agents.py index 64dbd38f70..750fcc6c47 100644 --- a/contributing/samples/core_custom_agent_config/my_agents.py +++ b/contributing/samples/core_custom_agent_config/my_agents.py @@ -34,7 +34,7 @@ class MyCustomAgentConfig(BaseAgentConfig): model_config = ConfigDict( extra="forbid", ) - agent_class: str = "core_cutom_agent_config.my_agents.MyCustomAgent" + agent_class: str = "core_custom_agent_config.my_agents.MyCustomAgent" my_field: str = "" From f8e7e364b016d6e76c3d38f7662cbb65c6778bb2 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:48:48 -0500 Subject: [PATCH 11/31] spelling: doesn't Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/live_agent_api_server_example/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/live_agent_api_server_example/readme.md b/contributing/samples/live_agent_api_server_example/readme.md index 0e524b37bd..73f7f9ede1 100644 --- a/contributing/samples/live_agent_api_server_example/readme.md +++ b/contributing/samples/live_agent_api_server_example/readme.md @@ -14,7 +14,7 @@ the response is always audio. may feed back to the model. You can use headset to avoid this or tune down voice volume, or implement your own noise cancellation logic. - Please ensure you grant the right mic/sound device permission to the terminal - that runs the script. Sometimes, terminal inside VSCode etc dones't really work + that runs the script. Sometimes, terminal inside VSCode etc doesn't really work well. So try native terminals if you have permission issue. - start api server first for your agent folder. For example, my agents are locoated in contributing/samples. So I will run From 1e576ffe33dca72ba9d41ab333957380cf42b2ba Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:32:30 -0500 Subject: [PATCH 12/31] spelling: especially Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../samples/adk_documentation/adk_docs_updater/agent.py | 2 +- .../samples/adk_documentation/adk_release_analyzer/agent.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contributing/samples/adk_documentation/adk_docs_updater/agent.py b/contributing/samples/adk_documentation/adk_docs_updater/agent.py index d61e4e5a93..0267bc3fef 100644 --- a/contributing/samples/adk_documentation/adk_docs_updater/agent.py +++ b/contributing/samples/adk_documentation/adk_docs_updater/agent.py @@ -57,7 +57,7 @@ You are a helper bot that updates ADK docs in Github Repository {DOC_OWNER}/{DOC_REPO} based on the code in the ADK Python codebase in Github Repository {CODE_OWNER}/{CODE_REPO} according to the instructions in the ADK docs issues. - You are very familiar with Github, expecially how to search for files in a Github repository using git grep. + You are very familiar with Github, especially how to search for files in a Github repository using git grep. # 2. Responsibilities Your core responsibility includes: diff --git a/contributing/samples/adk_documentation/adk_release_analyzer/agent.py b/contributing/samples/adk_documentation/adk_release_analyzer/agent.py index 6a25642198..2d2bc19d60 100644 --- a/contributing/samples/adk_documentation/adk_release_analyzer/agent.py +++ b/contributing/samples/adk_documentation/adk_release_analyzer/agent.py @@ -59,7 +59,7 @@ You are a helper bot that checks if ADK docs in Github Repository {DOC_REPO} owned by {DOC_OWNER} should be updated based on the changes in the ADK Python codebase in Github Repository {CODE_REPO} owned by {CODE_OWNER}. - You are very familiar with Github, expecially how to search for files in a Github repository using git grep. + You are very familiar with Github, especially how to search for files in a Github repository using git grep. # 2. Responsibilities Your core responsibility includes: From a456d7522e75c579fd8cd9890e863a724bdc6d6d Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:03:50 -0500 Subject: [PATCH 13/31] spelling: expensive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/multi_agent_seq_config/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/multi_agent_seq_config/README.md b/contributing/samples/multi_agent_seq_config/README.md index a60d9af488..a2cd462465 100644 --- a/contributing/samples/multi_agent_seq_config/README.md +++ b/contributing/samples/multi_agent_seq_config/README.md @@ -5,7 +5,7 @@ A multi-agent setup with a sequential workflow. The whole process is: 1. An agent backed by a cheap and fast model to write initial version. -2. An agent backed by a smarter and a little more expenstive to review the code. +2. An agent backed by a smarter and a little more expensive to review the code. 3. An final agent backed by the smartest and slowest model to write the final revision. Sample queries: From 28a5706736048eb8e1d871b516233b66b400eaee Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:04:03 -0500 Subject: [PATCH 14/31] spelling: explanation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../samples/adk_documentation/adk_docs_updater/agent.py | 2 +- .../samples/adk_documentation/adk_release_analyzer/agent.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contributing/samples/adk_documentation/adk_docs_updater/agent.py b/contributing/samples/adk_documentation/adk_docs_updater/agent.py index 0267bc3fef..3c31d67493 100644 --- a/contributing/samples/adk_documentation/adk_docs_updater/agent.py +++ b/contributing/samples/adk_documentation/adk_docs_updater/agent.py @@ -102,7 +102,7 @@ - **File Paths:** Always use absolute paths when calling the tools to read files, list directories, or search the codebase. - **Tool Call Parallelism:** Execute multiple independent tool calls in parallel when feasible (i.e. searching the codebase). - **Avoid deletion:** Do not delete any existing content unless specifically directed to do so. - - **Explaination:** Provide concise explanations for your actions and reasoning for each step. + - **Explanation:** Provide concise explanations for your actions and reasoning for each step. - **Minimize changes:** When making updates to documentation pages, make the minimum amount of changes to achieve the communication goal. Only make changes that are necessary, and leave everything else as-is. - **Avoid trivial code sample changes:** Update code samples only when adding or modifying functionality. Do not reformat code samples, change variable names, or change code syntax unless you are specifically directed to make those updates. diff --git a/contributing/samples/adk_documentation/adk_release_analyzer/agent.py b/contributing/samples/adk_documentation/adk_release_analyzer/agent.py index 2d2bc19d60..0c77134431 100644 --- a/contributing/samples/adk_documentation/adk_release_analyzer/agent.py +++ b/contributing/samples/adk_documentation/adk_release_analyzer/agent.py @@ -112,7 +112,7 @@ # 4. Guidelines & Rules - **File Paths:** Always use absolute paths when calling the tools to read files, list directories, or search the codebase. - **Tool Call Parallelism:** Execute multiple independent tool calls in parallel when feasible (i.e. searching the codebase). - - **Explaination:** Provide concise explanations for your actions and reasoning for each step. + - **Explanation:** Provide concise explanations for your actions and reasoning for each step. - **Reference:** For each recommended change, reference the code changes (i.e. links to the commits) **AND** the code files (i.e. relative paths to the code files in the codebase). - **Sorting:** Sort the recommended changes by the importance of the changes, from the most important to the least important. - Here are the importance groups: Feature changes > Bug fixes > Other changes. From 689379fb7faf41efc262250a94baa91e87087d4d Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:05:44 -0500 Subject: [PATCH 15/31] spelling: feature Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/adk_issue_formatting_agent/agent.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contributing/samples/adk_issue_formatting_agent/agent.py b/contributing/samples/adk_issue_formatting_agent/agent.py index d2f040ed56..f2450b3240 100644 --- a/contributing/samples/adk_issue_formatting_agent/agent.py +++ b/contributing/samples/adk_issue_formatting_agent/agent.py @@ -29,7 +29,7 @@ BUG_REPORT_TEMPLATE = read_file( Path(__file__).parent / "../../../../.github/ISSUE_TEMPLATE/bug_report.md" ) -FREATURE_REQUEST_TEMPLATE = read_file( +FEATURE_REQUEST_TEMPLATE = read_file( Path(__file__).parent / "../../../../.github/ISSUE_TEMPLATE/feature_request.md" ) @@ -145,7 +145,7 @@ def list_comments_on_issue(issue_number: int) -> dict[str, any]: # 2. CONTEXT & RESOURCES * **Repository:** You are operating on the GitHub repository `{OWNER}/{REPO}`. * **Bug Report Template:** (`{BUG_REPORT_TEMPLATE}`) - * **Feature Request Template:** (`{FREATURE_REQUEST_TEMPLATE}`) + * **Feature Request Template:** (`{FEATURE_REQUEST_TEMPLATE}`) # 3. CORE MISSION Your goal is to check if a GitHub issue, identified as either a "bug" or a "feature request," From 5f13ec61970f8394e7c8414c3ef18f1beff4d8ea Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:32:13 -0500 Subject: [PATCH 16/31] spelling: github Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../adk_documentation/adk_docs_updater/agent.py | 6 +++--- .../adk_documentation/adk_release_analyzer/agent.py | 10 +++++----- contributing/samples/adk_documentation/tools.py | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/contributing/samples/adk_documentation/adk_docs_updater/agent.py b/contributing/samples/adk_documentation/adk_docs_updater/agent.py index 3c31d67493..a30f90f6cd 100644 --- a/contributing/samples/adk_documentation/adk_docs_updater/agent.py +++ b/contributing/samples/adk_documentation/adk_docs_updater/agent.py @@ -54,10 +54,10 @@ ), instruction=f""" # 1. Identity - You are a helper bot that updates ADK docs in Github Repository {DOC_OWNER}/{DOC_REPO} - based on the code in the ADK Python codebase in Github Repository {CODE_OWNER}/{CODE_REPO} according to the instructions in the ADK docs issues. + You are a helper bot that updates ADK docs in GitHub Repository {DOC_OWNER}/{DOC_REPO} + based on the code in the ADK Python codebase in GitHub Repository {CODE_OWNER}/{CODE_REPO} according to the instructions in the ADK docs issues. - You are very familiar with Github, especially how to search for files in a Github repository using git grep. + You are very familiar with GitHub, especially how to search for files in a GitHub repository using git grep. # 2. Responsibilities Your core responsibility includes: diff --git a/contributing/samples/adk_documentation/adk_release_analyzer/agent.py b/contributing/samples/adk_documentation/adk_release_analyzer/agent.py index 0c77134431..a559bd7d47 100644 --- a/contributing/samples/adk_documentation/adk_release_analyzer/agent.py +++ b/contributing/samples/adk_documentation/adk_release_analyzer/agent.py @@ -56,17 +56,17 @@ ), instruction=f""" # 1. Identity - You are a helper bot that checks if ADK docs in Github Repository {DOC_REPO} owned by {DOC_OWNER} - should be updated based on the changes in the ADK Python codebase in Github Repository {CODE_REPO} owned by {CODE_OWNER}. + You are a helper bot that checks if ADK docs in GitHub Repository {DOC_REPO} owned by {DOC_OWNER} + should be updated based on the changes in the ADK Python codebase in GitHub Repository {CODE_REPO} owned by {CODE_OWNER}. - You are very familiar with Github, especially how to search for files in a Github repository using git grep. + You are very familiar with GitHub, especially how to search for files in a GitHub repository using git grep. # 2. Responsibilities Your core responsibility includes: - Find all the code changes between the two ADK releases. - Find **all** the related docs files in ADK Docs repository under the "/docs/" directory. - Compare the code changes with the docs files and analyze the differences. - - Write the instructions about how to update the ADK docs in markdown format and create a Github issue in the Github Repository {DOC_REPO} with the instructions. + - Write the instructions about how to update the ADK docs in markdown format and create a GitHub issue in the GitHub Repository {DOC_REPO} with the instructions. # 3. Workflow 1. Always call the `clone_or_pull_repo` tool to make sure the ADK docs and codebase repos exist in the local folder {LOCAL_REPOS_DIR_PATH}/repo_name and are the latest version. @@ -103,7 +103,7 @@ Reference to the code file (e.g. src/google/adk/tools/spanner/metadata_tool.py). ``` - When referncing doc file, use the full relative path of the doc file in the ADK Docs repository (e.g. docs/sessions/memory.md). - 9. Create or recommend to create a Github issue in the Github Repository {DOC_REPO} with the instructions using the `create_issue` tool. + 9. Create or recommend to create a GitHub issue in the GitHub Repository {DOC_REPO} with the instructions using the `create_issue` tool. - The title of the issue should be "Found docs updates needed from ADK python release to ", where start_tag and end_tag are the release tags. - The body of the issue should be the instructions about how to update the ADK docs. - Include the compare link between the two ADK releases in the issue body, e.g. https://github.com/google/adk-python/compare/v1.14.0...v1.14.1. diff --git a/contributing/samples/adk_documentation/tools.py b/contributing/samples/adk_documentation/tools.py index 16ef82459c..bc3b8d8c42 100644 --- a/contributing/samples/adk_documentation/tools.py +++ b/contributing/samples/adk_documentation/tools.py @@ -392,7 +392,7 @@ def get_issue( Args: repo_owner: The name of the repository owner. repo_name: The name of the repository. - issue_number: issue number of the Github issue. + issue_number: issue number of the GitHub issue. Returns: The status of this request, with the issue details when successful. From 96a329b921c7dd7ffd3a74646b9e7b6315f90b83 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:11:12 -0500 Subject: [PATCH 17/31] spelling: information Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/oauth_calendar_agent/agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/oauth_calendar_agent/agent.py b/contributing/samples/oauth_calendar_agent/agent.py index a33ea2b942..db24b99805 100644 --- a/contributing/samples/oauth_calendar_agent/agent.py +++ b/contributing/samples/oauth_calendar_agent/agent.py @@ -56,7 +56,7 @@ # call right after a function call that request auth # see https://github.com/google/adk-python/issues/1944 for details def redact_event_content(event_content: str) -> str: - """Redact confidential informaiton in the calendar event content + """Redact confidential information in the calendar event content Args: event_content: the content of the calendar event to redact From b3b03b8cd5d0bda630d4226d3b1067ee01304afc Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:11:25 -0500 Subject: [PATCH 18/31] spelling: initialize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/bigtable/agent.py | 2 +- contributing/samples/spanner/agent.py | 2 +- contributing/samples/spanner_rag_agent/agent.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contributing/samples/bigtable/agent.py b/contributing/samples/bigtable/agent.py index 37cf802507..d79a640ba3 100644 --- a/contributing/samples/bigtable/agent.py +++ b/contributing/samples/bigtable/agent.py @@ -29,7 +29,7 @@ tool_settings = BigtableToolSettings() if CREDENTIALS_TYPE == AuthCredentialTypes.OAUTH2: - # Initiaze the tools to do interactive OAuth + # Initialize the tools to do interactive OAuth # The environment variables OAUTH_CLIENT_ID and OAUTH_CLIENT_SECRET # must be set credentials_config = BigtableCredentialsConfig( diff --git a/contributing/samples/spanner/agent.py b/contributing/samples/spanner/agent.py index d0f570cdda..631fb45bfb 100644 --- a/contributing/samples/spanner/agent.py +++ b/contributing/samples/spanner/agent.py @@ -37,7 +37,7 @@ tool_settings = SpannerToolSettings(capabilities=[Capabilities.DATA_READ]) if CREDENTIALS_TYPE == AuthCredentialTypes.OAUTH2: - # Initiaze the tools to do interactive OAuth + # Initialize the tools to do interactive OAuth # The environment variables OAUTH_CLIENT_ID and OAUTH_CLIENT_SECRET # must be set credentials_config = SpannerCredentialsConfig( diff --git a/contributing/samples/spanner_rag_agent/agent.py b/contributing/samples/spanner_rag_agent/agent.py index b9bbfe96bc..58ec95294e 100644 --- a/contributing/samples/spanner_rag_agent/agent.py +++ b/contributing/samples/spanner_rag_agent/agent.py @@ -41,7 +41,7 @@ tool_settings = SpannerToolSettings(capabilities=[Capabilities.DATA_READ]) if CREDENTIALS_TYPE == AuthCredentialTypes.OAUTH2: - # Initiaze the tools to do interactive OAuth + # Initialize the tools to do interactive OAuth # The environment variables OAUTH_CLIENT_ID and OAUTH_CLIENT_SECRET # must be set credentials_config = SpannerCredentialsConfig( From e89339e830c3c6a21e9917790c3bfbbb4e1cc0ca Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:11:42 -0500 Subject: [PATCH 19/31] spelling: invalid Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/authn-adk-all-in-one/idp/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/authn-adk-all-in-one/idp/app.py b/contributing/samples/authn-adk-all-in-one/idp/app.py index 86388efc1e..50db9a57c5 100644 --- a/contributing/samples/authn-adk-all-in-one/idp/app.py +++ b/contributing/samples/authn-adk-all-in-one/idp/app.py @@ -344,7 +344,7 @@ def generate_token(): client = CLIENT_REGISTRY.get(client_id) if not client: - logging.error(f"invlid client {client_id}") + logging.error(f"invalid client {client_id}") return ( jsonify( {"error": "invalid_client", "error_description": "Client not found"} From 5ee9a01c02cd73c47fb6825ee746123675ed1216 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:49:03 -0500 Subject: [PATCH 20/31] spelling: located Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/live_agent_api_server_example/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/live_agent_api_server_example/readme.md b/contributing/samples/live_agent_api_server_example/readme.md index 73f7f9ede1..3f01912188 100644 --- a/contributing/samples/live_agent_api_server_example/readme.md +++ b/contributing/samples/live_agent_api_server_example/readme.md @@ -17,7 +17,7 @@ the response is always audio. that runs the script. Sometimes, terminal inside VSCode etc doesn't really work well. So try native terminals if you have permission issue. - start api server first for your agent folder. For example, my agents are - locoated in contributing/samples. So I will run + located in contributing/samples. So I will run `adk api_server contributing/samples/`. Keep this running. - then in a separate window, run `python3 live_agent_example.py` From 5a98aedb083e570bf43c833888c06d554350a550 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:39:42 -0500 Subject: [PATCH 21/31] spelling: otherwise, Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/adk_answering_agent/agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/adk_answering_agent/agent.py b/contributing/samples/adk_answering_agent/agent.py index 1f9c58d71a..69513bace3 100644 --- a/contributing/samples/adk_answering_agent/agent.py +++ b/contributing/samples/adk_answering_agent/agent.py @@ -102,7 +102,7 @@ * You **should always** use the `convert_gcs_links_to_https` tool to convert GCS links (e.g. "gs://...") to HTTPS links. * **Do not** use the `convert_gcs_links_to_https` tool for non-GCS links. - * Make sure the citation URL is valid. Otherwise do not list this specific + * Make sure the citation URL is valid. Otherwise, do not list this specific citation. * Do not respond to any other discussion except the one specified by the user. From cdb246691bd0a9457e05cbe8a1ce4b2c13a83a66 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:56:24 -0500 Subject: [PATCH 22/31] spelling: plugin Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/gepa/adk_agent_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/gepa/adk_agent_test.py b/contributing/samples/gepa/adk_agent_test.py index 2eea7325d9..c7a3da3f14 100644 --- a/contributing/samples/gepa/adk_agent_test.py +++ b/contributing/samples/gepa/adk_agent_test.py @@ -26,7 +26,7 @@ class _TestPlugin(base_plugin.BasePlugin): def __init__(self, outputs): - super().__init__(name="test-pluggin") + super().__init__(name="test-plugin") self._model_output_idx = 0 self.got_llm_requests = [] self._outputs = outputs From 86f34733c2cb0b0c5bd037f891776cc2cd5bff43 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 20:03:24 -0500 Subject: [PATCH 23/31] spelling: referencing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../samples/adk_documentation/adk_release_analyzer/agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/adk_documentation/adk_release_analyzer/agent.py b/contributing/samples/adk_documentation/adk_release_analyzer/agent.py index a559bd7d47..d03585a870 100644 --- a/contributing/samples/adk_documentation/adk_release_analyzer/agent.py +++ b/contributing/samples/adk_documentation/adk_release_analyzer/agent.py @@ -102,7 +102,7 @@ **Reference**: Reference to the code file (e.g. src/google/adk/tools/spanner/metadata_tool.py). ``` - - When referncing doc file, use the full relative path of the doc file in the ADK Docs repository (e.g. docs/sessions/memory.md). + - When referencing doc file, use the full relative path of the doc file in the ADK Docs repository (e.g. docs/sessions/memory.md). 9. Create or recommend to create a GitHub issue in the GitHub Repository {DOC_REPO} with the instructions using the `create_issue` tool. - The title of the issue should be "Found docs updates needed from ADK python release to ", where start_tag and end_tag are the release tags. - The body of the issue should be the instructions about how to update the ADK docs. From e44c4bc741b5583f152b2bab72d51a923c1172fe Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 20:03:33 -0500 Subject: [PATCH 24/31] spelling: relevant Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/custom_code_execution/agent.py | 2 +- contributing/samples/vertex_code_execution/agent.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contributing/samples/custom_code_execution/agent.py b/contributing/samples/custom_code_execution/agent.py index 5dbadcf53a..e27c8dfb26 100644 --- a/contributing/samples/custom_code_execution/agent.py +++ b/contributing/samples/custom_code_execution/agent.py @@ -150,7 +150,7 @@ def base_system_instruction(): You need to assist the user with their queries by looking at the data and the context in the conversation. -You final answer should summarize the code and code execution relavant to the user query. +You final answer should summarize the code and code execution relevant to the user query. You should include all pieces of data to answer the user query, such as the table from code execution results. If you cannot answer the question directly, you should follow the guidelines above to generate the next step. diff --git a/contributing/samples/vertex_code_execution/agent.py b/contributing/samples/vertex_code_execution/agent.py index 573827c0ac..89838f5c99 100644 --- a/contributing/samples/vertex_code_execution/agent.py +++ b/contributing/samples/vertex_code_execution/agent.py @@ -84,7 +84,7 @@ def base_system_instruction(): You need to assist the user with their queries by looking at the data and the context in the conversation. -You final answer should summarize the code and code execution relavant to the user query. +You final answer should summarize the code and code execution relevant to the user query. You should include all pieces of data to answer the user query, such as the table from code execution results. If you cannot answer the question directly, you should follow the guidelines above to generate the next step. From a3c90cca9974b2a9fd8481cfbd7ecb633d14a021 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:13:33 -0500 Subject: [PATCH 25/31] spelling: request Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/authn-adk-all-in-one/idp/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/authn-adk-all-in-one/idp/app.py b/contributing/samples/authn-adk-all-in-one/idp/app.py index 50db9a57c5..0cc15cd084 100644 --- a/contributing/samples/authn-adk-all-in-one/idp/app.py +++ b/contributing/samples/authn-adk-all-in-one/idp/app.py @@ -139,7 +139,7 @@ def create_access_token(client_id, scopes, user_sub=None): payload = { "iss": "http://localhost:5000", # who issued this token? # aud - What client API is this token for? - please check comment in hotel booker is_token_valid - # ideally the reqeust's resource parameter (part of OAuth spec extension) + # ideally the request's resource parameter (part of OAuth spec extension) # Here is an example of such request inbound to this IDP # GET http://localhost:5000/authorize? # response_type=code& From 546def0392dc82d718100db63a1198dcae0f6a8b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 21:16:01 -0500 Subject: [PATCH 26/31] spelling: streaming Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/live_agent_api_server_example/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/live_agent_api_server_example/readme.md b/contributing/samples/live_agent_api_server_example/readme.md index 3f01912188..577afa8ff2 100644 --- a/contributing/samples/live_agent_api_server_example/readme.md +++ b/contributing/samples/live_agent_api_server_example/readme.md @@ -1,7 +1,7 @@ # What's this? This is a sample that shows how to start the ADK api server, and how to connect -your agents in a live(bidi-stremaing) way. It works text and audio input, and +your agents in a live(bidi-streaming) way. It works text and audio input, and the response is always audio. ## Prerequisite From d142185e275020851605a4b2f0422125722208b8 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:22:49 -0500 Subject: [PATCH 27/31] spelling: the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../samples/adk_documentation/adk_docs_updater/agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/adk_documentation/adk_docs_updater/agent.py b/contributing/samples/adk_documentation/adk_docs_updater/agent.py index a30f90f6cd..2bcd06a9bc 100644 --- a/contributing/samples/adk_documentation/adk_docs_updater/agent.py +++ b/contributing/samples/adk_documentation/adk_docs_updater/agent.py @@ -80,7 +80,7 @@ - You should find all the related Python files, not only the most relevant one. 7. Read the specified or found Python files using the `read_local_git_repo_file_content` tool to find all the related code. - You can ignore unit test files, unless you are sure that the test code is uesful to understand the related concepts. - - You should read all the the found files to find all the related code, unless you already know the content of the file or you are sure that the file is not related to the ADK doc. + - You should read all the found files to find all the related code, unless you already know the content of the file or you are sure that the file is not related to the ADK doc. 8. Update the ADK doc file according to the doc update instructions and the related code. - Use active voice phrasing in your doc updates. - Use second person "you" form of address in your doc updates. From 8641cff9fdeb74491396a9389652c9517c25f033 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 20:51:50 -0500 Subject: [PATCH 28/31] spelling: timestamped Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../adk_agent_builder_assistant/tools/write_config_files.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/adk_agent_builder_assistant/tools/write_config_files.py b/contributing/samples/adk_agent_builder_assistant/tools/write_config_files.py index 2ceb1241dd..84c4792786 100644 --- a/contributing/samples/adk_agent_builder_assistant/tools/write_config_files.py +++ b/contributing/samples/adk_agent_builder_assistant/tools/write_config_files.py @@ -66,7 +66,7 @@ async def write_config_files( Args: configs: Dict mapping file_path to config_content (YAML as string) - backup_existing: Whether to create timest amped backup of existing files + backup_existing: Whether to create timestamped backup of existing files before overwriting (default: False, User should decide) create_directories: Whether to create parent directories if they don't exist (default: True) From 972f6176fff43f10a15ceb0f89c903a1b1056ea8 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 20:17:20 -0500 Subject: [PATCH 29/31] spelling: useful Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../samples/adk_documentation/adk_docs_updater/agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/adk_documentation/adk_docs_updater/agent.py b/contributing/samples/adk_documentation/adk_docs_updater/agent.py index 2bcd06a9bc..564e71757a 100644 --- a/contributing/samples/adk_documentation/adk_docs_updater/agent.py +++ b/contributing/samples/adk_documentation/adk_docs_updater/agent.py @@ -79,7 +79,7 @@ - You should focus on the main ADK Python codebase, ignore the changes in tests or other auxiliary files. - You should find all the related Python files, not only the most relevant one. 7. Read the specified or found Python files using the `read_local_git_repo_file_content` tool to find all the related code. - - You can ignore unit test files, unless you are sure that the test code is uesful to understand the related concepts. + - You can ignore unit test files, unless you are sure that the test code is useful to understand the related concepts. - You should read all the found files to find all the related code, unless you already know the content of the file or you are sure that the file is not related to the ADK doc. 8. Update the ADK doc file according to the doc update instructions and the related code. - Use active voice phrasing in your doc updates. From 476ca3bcbdaa42f98936ad14617e41dae484d278 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:41:25 -0500 Subject: [PATCH 30/31] spelling: whether or not Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/toolbox_agent/tools.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/toolbox_agent/tools.yaml b/contributing/samples/toolbox_agent/tools.yaml index 692a758ecd..f9f8522eeb 100644 --- a/contributing/samples/toolbox_agent/tools.yaml +++ b/contributing/samples/toolbox_agent/tools.yaml @@ -49,7 +49,7 @@ tools: source: my-sqlite-db description: >- Update a hotel's check-in and check-out dates by its ID. Returns a message - indicating whether the hotel was successfully updated or not. + indicating whether or not the hotel was successfully updated. parameters: - name: hotel_id type: string From 0fd8d21025514b8897874523083623ae45ae7944 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 3 Nov 2025 20:21:18 -0500 Subject: [PATCH 31/31] spelling: youtube Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- contributing/samples/langchain_youtube_search_agent/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/samples/langchain_youtube_search_agent/README.md b/contributing/samples/langchain_youtube_search_agent/README.md index 7d46f60b8d..10d7f1a6f1 100644 --- a/contributing/samples/langchain_youtube_search_agent/README.md +++ b/contributing/samples/langchain_youtube_search_agent/README.md @@ -1,4 +1,4 @@ -# Langchain Youtube Search Agent +# Langchain YouTube Search Agent This agent utilize the Langchain YoutubeSearchTool to search youtubes. You need to install below dependencies: