From c09c563d9abc4269b44f62414eee256a77cda0f4 Mon Sep 17 00:00:00 2001 From: FingerLiu Date: Mon, 18 Aug 2025 15:08:59 +0800 Subject: [PATCH 1/3] Update local_eval_service.py --- src/google/adk/evaluation/local_eval_service.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/google/adk/evaluation/local_eval_service.py b/src/google/adk/evaluation/local_eval_service.py index f443bb7036..c0df99fc75 100644 --- a/src/google/adk/evaluation/local_eval_service.py +++ b/src/google/adk/evaluation/local_eval_service.py @@ -120,7 +120,7 @@ async def perform_inference( async def run_inference(eval_case): async with semaphore: - return await self._perform_inference_sigle_eval_item( + return await self._perform_inference_single_eval_item( app_name=inference_request.app_name, eval_set_id=inference_request.eval_set_id, eval_case=eval_case, @@ -342,7 +342,7 @@ def _generate_final_eval_status( return final_eval_status - async def _perform_inference_sigle_eval_item( + async def _perform_inference_single_eval_item( self, app_name: str, eval_set_id: str, From 8a2654aefec71e809b9ee4b5551ac435f9aa1d97 Mon Sep 17 00:00:00 2001 From: FingerLiu Date: Mon, 18 Aug 2025 15:09:39 +0800 Subject: [PATCH 2/3] Update test_local_eval_service.py --- tests/unittests/evaluation/test_local_eval_service.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/unittests/evaluation/test_local_eval_service.py b/tests/unittests/evaluation/test_local_eval_service.py index 49ebead2e7..f6a2332b08 100644 --- a/tests/unittests/evaluation/test_local_eval_service.py +++ b/tests/unittests/evaluation/test_local_eval_service.py @@ -126,7 +126,7 @@ async def test_perform_inference_success( mock_eval_sets_manager.get_eval_set.return_value = eval_set mock_inference_result = mock.MagicMock() - eval_service._perform_inference_sigle_eval_item = mock.AsyncMock( + eval_service._perform_inference_single_eval_item = mock.AsyncMock( return_value=mock_inference_result ) @@ -146,7 +146,7 @@ async def test_perform_inference_success( mock_eval_sets_manager.get_eval_set.assert_called_once_with( app_name="test_app", eval_set_id="test_eval_set" ) - assert eval_service._perform_inference_sigle_eval_item.call_count == 2 + assert eval_service._perform_inference_single_eval_item.call_count == 2 @pytest.mark.asyncio @@ -166,7 +166,7 @@ async def test_perform_inference_with_case_ids( mock_eval_sets_manager.get_eval_set.return_value = eval_set mock_inference_result = mock.MagicMock() - eval_service._perform_inference_sigle_eval_item = mock.AsyncMock( + eval_service._perform_inference_single_eval_item = mock.AsyncMock( return_value=mock_inference_result ) @@ -182,13 +182,13 @@ async def test_perform_inference_with_case_ids( results.append(result) assert len(results) == 2 - eval_service._perform_inference_sigle_eval_item.assert_any_call( + eval_service._perform_inference_single_eval_item.assert_any_call( app_name="test_app", eval_set_id="test_eval_set", eval_case=eval_set.eval_cases[0], root_agent=dummy_agent, ) - eval_service._perform_inference_sigle_eval_item.assert_any_call( + eval_service._perform_inference_single_eval_item.assert_any_call( app_name="test_app", eval_set_id="test_eval_set", eval_case=eval_set.eval_cases[2], From 78083cb5d4ba1cc90785ad5d727756d467737e08 Mon Sep 17 00:00:00 2001 From: Liang Wu <18244712+wuliang229@users.noreply.github.com> Date: Fri, 31 Oct 2025 15:22:07 -0700 Subject: [PATCH 3/3] Use mocker instead of mock --- tests/unittests/evaluation/test_local_eval_service.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/unittests/evaluation/test_local_eval_service.py b/tests/unittests/evaluation/test_local_eval_service.py index 6fc8b1b0da..df90bf39dc 100644 --- a/tests/unittests/evaluation/test_local_eval_service.py +++ b/tests/unittests/evaluation/test_local_eval_service.py @@ -173,8 +173,8 @@ async def test_perform_inference_success( ) mock_eval_sets_manager.get_eval_set.return_value = eval_set - mock_inference_result = mock.MagicMock() - eval_service._perform_inference_single_eval_item = mock.AsyncMock( + mock_inference_result = mocker.MagicMock() + eval_service._perform_inference_single_eval_item = mocker.AsyncMock( return_value=mock_inference_result ) @@ -214,8 +214,8 @@ async def test_perform_inference_with_case_ids( ) mock_eval_sets_manager.get_eval_set.return_value = eval_set - mock_inference_result = mock.MagicMock() - eval_service._perform_inference_single_eval_item = mock.AsyncMock( + mock_inference_result = mocker.MagicMock() + eval_service._perform_inference_single_eval_item = mocker.AsyncMock( return_value=mock_inference_result )