From 07a86495b71df8995a40a31cb2e191bde7b6bbbd Mon Sep 17 00:00:00 2001 From: kamalraj23 Date: Thu, 7 Aug 2025 16:28:40 +0200 Subject: [PATCH] fix: Fix various typos throughout the codebase --- CHANGELOG.md | 2 +- CONTRIBUTING.md | 2 +- src/google/adk/evaluation/agent_evaluator.py | 2 +- src/google/adk/tools/function_tool.py | 2 +- tests/unittests/tools/test_build_function_declaration.py | 2 +- tests/unittests/tools/test_function_tool.py | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4b5afb99ff..c6d6fbfd6e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -165,7 +165,7 @@ ### Documentation -* Update the a2a exmaple link in README.md [d0fdfb8](https://github.com/google/adk-python/commit/d0fdfb8c8e2e32801999c81de8d8ed0be3f88e76) +* Update the a2a example link in README.md [d0fdfb8](https://github.com/google/adk-python/commit/d0fdfb8c8e2e32801999c81de8d8ed0be3f88e76) * Adds AGENTS.md to provide relevant project context for the Gemini CLI [37108be](https://github.com/google/adk-python/commit/37108be8557e011f321de76683835448213f8515) * Update CONTRIBUTING.md [ffa9b36](https://github.com/google/adk-python/commit/ffa9b361db615ae365ba62c09a8f4226fb761551) * Add adk project overview and architecture [28d0ea8](https://github.com/google/adk-python/commit/28d0ea876f2f8de952f1eccbc788e98e39f50cf5) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dc07233531..863e0d553a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -50,7 +50,7 @@ This project follows ## Requirement for PRs - Each PR should only have one commit. Please squash it if there are multiple PRs. -- All PRs, other than small documentation or typo fixes, should have a Issue assoicated. If not, please create one. +- All PRs, other than small documentation or typo fixes, should have a Issue associated. If not, please create one. - Small, focused PRs. Keep changes minimal—one concern per PR. - For bug fixes or features, please provide logs or screenshot after the fix is applied to help reviewers better understand the fix. - Please include a `testing plan` section in your PR to talk about how you will test. This will save time for PR review. See `Testing Requirements` section for more details. diff --git a/src/google/adk/evaluation/agent_evaluator.py b/src/google/adk/evaluation/agent_evaluator.py index 150a80c1ac..3c18875877 100644 --- a/src/google/adk/evaluation/agent_evaluator.py +++ b/src/google/adk/evaluation/agent_evaluator.py @@ -559,7 +559,7 @@ async def _get_eval_results_by_eval_id( def _get_eval_metric_results_with_invocation( eval_results_per_eval_id: list[EvalCaseResult], ) -> dict[str, list[_EvalMetricResultWithInvocation]]: - """Retruns _EvalMetricResultWithInvocation grouped by metric. + """Returns _EvalMetricResultWithInvocation grouped by metric. EvalCaseResult contain results for each metric per invocation. diff --git a/src/google/adk/tools/function_tool.py b/src/google/adk/tools/function_tool.py index 2687f1200a..18a3dcec7c 100644 --- a/src/google/adk/tools/function_tool.py +++ b/src/google/adk/tools/function_tool.py @@ -107,7 +107,7 @@ async def run_async( # Functions are callable objects, but not all callable objects are functions # checking coroutine function is not enough. We also need to check whether - # Callable's __call__ function is a coroutine funciton + # Callable's __call__ function is a coroutine function if ( inspect.iscoroutinefunction(self.func) or hasattr(self.func, '__call__') diff --git a/tests/unittests/tools/test_build_function_declaration.py b/tests/unittests/tools/test_build_function_declaration.py index edf3c7128e..98d917382d 100644 --- a/tests/unittests/tools/test_build_function_declaration.py +++ b/tests/unittests/tools/test_build_function_declaration.py @@ -360,7 +360,7 @@ def function_string_return(param: str) -> str: assert function_decl.response.type == types.Type.STRING -def test_fucntion_with_no_response_annotations(): +def test_function_with_no_response_annotations(): """Test a function that has no response annotations.""" def transfer_to_agent(agent_name: str, tool_context: ToolContext): diff --git a/tests/unittests/tools/test_function_tool.py b/tests/unittests/tools/test_function_tool.py index 871f58dcb8..e3115f07f0 100644 --- a/tests/unittests/tools/test_function_tool.py +++ b/tests/unittests/tools/test_function_tool.py @@ -273,7 +273,7 @@ async def test_run_async_missing_all_arg_async_func(): @pytest.mark.asyncio async def test_run_async_with_optional_args_not_set_sync_func(): - """Test that run_async calls the function for sync funciton with optional args not set.""" + """Test that run_async calls the function for sync function with optional args not set.""" def func_with_optional_args(arg1, arg2=None, *, arg3, arg4=None, **kwargs): return f"{arg1},{arg3}" @@ -286,7 +286,7 @@ def func_with_optional_args(arg1, arg2=None, *, arg3, arg4=None, **kwargs): @pytest.mark.asyncio async def test_run_async_with_optional_args_not_set_async_func(): - """Test that run_async calls the function for async funciton with optional args not set.""" + """Test that run_async calls the function for async function with optional args not set.""" async def async_func_with_optional_args( arg1, arg2=None, *, arg3, arg4=None, **kwargs