|
| 1 | +# Copyright 2026 Google LLC |
| 2 | +# |
| 3 | +# Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | +# you may not use this file except in compliance with the License. |
| 5 | +# You may obtain a copy of the License at |
| 6 | +# |
| 7 | +# http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | +# |
| 9 | +# Unless required by applicable law or agreed to in writing, software |
| 10 | +# distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | +# See the License for the specific language governing permissions and |
| 13 | +# limitations under the License. |
| 14 | + |
| 15 | +"""Tests for BIDI live session restoration with SQLite persistence (Issue #3573).""" |
| 16 | + |
| 17 | +from __future__ import annotations |
| 18 | + |
| 19 | +from unittest.mock import AsyncMock |
| 20 | +from unittest.mock import MagicMock |
| 21 | +from unittest.mock import patch |
| 22 | + |
| 23 | +from google.adk.events.event import Event |
| 24 | +from google.adk.sessions.session import Session |
| 25 | +from google.genai import types |
| 26 | +import pytest |
| 27 | + |
| 28 | + |
| 29 | +@pytest.mark.asyncio |
| 30 | +async def test_live_session_replays_all_events_on_reconnection(): |
| 31 | + """Test that reconnecting to a live session replays all events including user messages. |
| 32 | + |
| 33 | + This tests the fix for Issue #3573 where user messages were stored in the |
| 34 | + database but not sent back to the client on reconnection. |
| 35 | + """ |
| 36 | + # Create a mock session with both user and agent events |
| 37 | + user_event = Event( |
| 38 | + id="event-user-1", |
| 39 | + author="user", |
| 40 | + content=types.Content(parts=[types.Part(text="Hello, assistant!")]), |
| 41 | + invocation_id="inv-1", |
| 42 | + ) |
| 43 | + agent_event = Event( |
| 44 | + id="event-agent-1", |
| 45 | + author="test_agent", |
| 46 | + content=types.Content( |
| 47 | + parts=[types.Part(text="Hello! How can I help you?")] |
| 48 | + ), |
| 49 | + invocation_id="inv-1", |
| 50 | + ) |
| 51 | + user_event2 = Event( |
| 52 | + id="event-user-2", |
| 53 | + author="user", |
| 54 | + content=types.Content( |
| 55 | + parts=[types.Part(text="What's the weather today?")] |
| 56 | + ), |
| 57 | + invocation_id="inv-2", |
| 58 | + ) |
| 59 | + agent_event2 = Event( |
| 60 | + id="event-agent-2", |
| 61 | + author="test_agent", |
| 62 | + content=types.Content( |
| 63 | + parts=[types.Part(text="I can help you check the weather.")] |
| 64 | + ), |
| 65 | + invocation_id="inv-2", |
| 66 | + ) |
| 67 | + |
| 68 | + mock_session = Session( |
| 69 | + app_name="test_app", |
| 70 | + user_id="test_user", |
| 71 | + id="test_session", |
| 72 | + state={}, |
| 73 | + events=[user_event, agent_event, user_event2, agent_event2], |
| 74 | + last_update_time=1234567890.0, |
| 75 | + ) |
| 76 | + |
| 77 | + # Mock WebSocket to capture replayed events |
| 78 | + mock_websocket = AsyncMock() |
| 79 | + replayed_events = [] |
| 80 | + |
| 81 | + async def capture_send_text(data): |
| 82 | + replayed_events.append(data) |
| 83 | + |
| 84 | + mock_websocket.send_text = capture_send_text |
| 85 | + |
| 86 | + # Test the core event replay logic that should be in run_agent_live |
| 87 | + # This simulates what happens when a client reconnects: |
| 88 | + # 1. Session is loaded (with all events) |
| 89 | + session = mock_session |
| 90 | + |
| 91 | + # 2. All existing events should be replayed to the client |
| 92 | + if session and session.events: |
| 93 | + for event in session.events: |
| 94 | + await mock_websocket.send_text( |
| 95 | + event.model_dump_json(exclude_none=True, by_alias=True) |
| 96 | + ) |
| 97 | + |
| 98 | + # Verify that all 4 events were replayed (2 user + 2 agent) |
| 99 | + assert len(replayed_events) == 4 |
| 100 | + |
| 101 | + # Verify that events were sent in order |
| 102 | + import json |
| 103 | + |
| 104 | + event_data = [json.loads(data) for data in replayed_events] |
| 105 | + |
| 106 | + # Check that user messages are included |
| 107 | + assert event_data[0]["author"] == "user" |
| 108 | + assert "Hello, assistant!" in event_data[0]["content"]["parts"][0]["text"] |
| 109 | + |
| 110 | + assert event_data[1]["author"] == "test_agent" |
| 111 | + |
| 112 | + assert event_data[2]["author"] == "user" |
| 113 | + assert "weather" in event_data[2]["content"]["parts"][0]["text"] |
| 114 | + |
| 115 | + assert event_data[3]["author"] == "test_agent" |
| 116 | + |
| 117 | + |
| 118 | +@pytest.mark.asyncio |
| 119 | +async def test_live_session_handles_empty_events_gracefully(): |
| 120 | + """Test that session restoration handles sessions with no events.""" |
| 121 | + mock_session = Session( |
| 122 | + app_name="test_app", |
| 123 | + user_id="test_user", |
| 124 | + id="new_session", |
| 125 | + state={}, |
| 126 | + events=[], # No events yet |
| 127 | + last_update_time=1234567890.0, |
| 128 | + ) |
| 129 | + |
| 130 | + mock_session_service = AsyncMock() |
| 131 | + mock_session_service.get_session.return_value = mock_session |
| 132 | + |
| 133 | + mock_websocket = AsyncMock() |
| 134 | + replayed_events = [] |
| 135 | + |
| 136 | + async def capture_send_text(data): |
| 137 | + replayed_events.append(data) |
| 138 | + |
| 139 | + mock_websocket.send_text = capture_send_text |
| 140 | + |
| 141 | + # Simulate event replay logic |
| 142 | + session = await mock_session_service.get_session( |
| 143 | + app_name="test_app", user_id="test_user", session_id="new_session" |
| 144 | + ) |
| 145 | + |
| 146 | + if session and session.events: |
| 147 | + for event in session.events: |
| 148 | + await mock_websocket.send_text( |
| 149 | + event.model_dump_json(exclude_none=True, by_alias=True) |
| 150 | + ) |
| 151 | + |
| 152 | + # Should not send any events for an empty session |
| 153 | + assert len(replayed_events) == 0 |
| 154 | + |
| 155 | + |
| 156 | +@pytest.mark.asyncio |
| 157 | +async def test_live_session_continues_after_replay_failure(): |
| 158 | + """Test that session continues even if one event fails to replay.""" |
| 159 | + # Create events where one might fail to serialize |
| 160 | + event1 = Event( |
| 161 | + id="event-1", |
| 162 | + author="user", |
| 163 | + content=types.Content(parts=[types.Part(text="First message")]), |
| 164 | + invocation_id="inv-1", |
| 165 | + ) |
| 166 | + event2 = Event( |
| 167 | + id="event-2", |
| 168 | + author="agent", |
| 169 | + content=types.Content(parts=[types.Part(text="Second message")]), |
| 170 | + invocation_id="inv-1", |
| 171 | + ) |
| 172 | + event3 = Event( |
| 173 | + id="event-3", |
| 174 | + author="user", |
| 175 | + content=types.Content(parts=[types.Part(text="Third message")]), |
| 176 | + invocation_id="inv-2", |
| 177 | + ) |
| 178 | + |
| 179 | + mock_session = Session( |
| 180 | + app_name="test_app", |
| 181 | + user_id="test_user", |
| 182 | + id="test_session", |
| 183 | + state={}, |
| 184 | + events=[event1, event2, event3], |
| 185 | + last_update_time=1234567890.0, |
| 186 | + ) |
| 187 | + |
| 188 | + mock_websocket = AsyncMock() |
| 189 | + replayed_events = [] |
| 190 | + send_call_count = 0 |
| 191 | + |
| 192 | + async def capture_send_text(data): |
| 193 | + nonlocal send_call_count |
| 194 | + send_call_count += 1 |
| 195 | + # Simulate failure on second event |
| 196 | + if send_call_count == 2: |
| 197 | + raise Exception("Simulated network error") |
| 198 | + replayed_events.append(data) |
| 199 | + |
| 200 | + mock_websocket.send_text = capture_send_text |
| 201 | + |
| 202 | + # Simulate event replay with error handling |
| 203 | + if mock_session and mock_session.events: |
| 204 | + for event in mock_session.events: |
| 205 | + try: |
| 206 | + await mock_websocket.send_text( |
| 207 | + event.model_dump_json(exclude_none=True, by_alias=True) |
| 208 | + ) |
| 209 | + except Exception: |
| 210 | + # Continue replaying even if one fails |
| 211 | + continue |
| 212 | + |
| 213 | + # Should have replayed 2 events successfully (skipped the failing one) |
| 214 | + assert len(replayed_events) == 2 |
| 215 | + assert send_call_count == 3 # Attempted all 3 |
0 commit comments