Skip to content

Commit 9dac3e2

Browse files
committed
address review comments
1 parent 1aaa7be commit 9dac3e2

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

gooddata-pipelines/gooddata_pipelines/provisioning/entities/users/models/permissions.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919

2020
class PermissionType(str, Enum):
21+
# NOTE: Start using StrEnum with Python 3.11
2122
user = "user"
2223
user_group = "userGroup"
2324

@@ -43,6 +44,7 @@ def from_list_of_dicts(
4344
cls: type[ConstructorType], data: list[dict[str, Any]]
4445
) -> list[ConstructorType]:
4546
"""Creates a list of instances from list of dicts."""
47+
# NOTE: We can use typing.Self for the return type in Python 3.11
4648
permissions = []
4749
for permission in data:
4850
permissions.append(cls.from_dict(permission))

gooddata-pipelines/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
from gooddata_pipelines.api import GoodDataApi
1111

12-
TEST_DATA_DIR = str(Path(Path(__file__).parent / "data").absolute())
12+
TEST_DATA_DIR = str((Path(__file__).parent / "data").absolute())
1313

1414

1515
@pytest.fixture(scope="function", autouse=True)

0 commit comments

Comments
 (0)