exit on error

[agsmorodin]

Is it possible to interrupt the script execution if something went wrong?
I can achieve it by using 'set -e' at the begging of the script, but in this case I need to set this flag for all my scripts. Is there any way to setup it globally? or to pass to /bin/sh specific flag from gocd?

[srinivasupadhya]

I will see what I can do for this. But since you already have a workaround its not a priority.

[Hraesvelg]

i up this request...

i would like to have a failed if my script exit(1) ... all values != 0 -> failed
if script return 0 -> success

[chadlwilson]

@Hraesvelg It should already work the way you describe if you use explicit exit codes/calls from a non Windows shell.

script-executor-task/src/main/java/com/tw/go/plugin/task/GoPluginImpl.java

Lines 136 to 144 in 334f75c

	int exitCode = executeScript(workingDirectory, shType, scriptFileName, isWindows, environmentVariables);
	if (exitCode == 0) {
	response.put("success", true);
	response.put("message", "[script-executor] Script completed successfully.");
	} else {
	response.put("success", false);
	response.put("message", "[script-executor] Script completed with exit code: " + exitCode + ".");
	}

This ticket is about exiting early if any of the commands within the script exit with non-zero exit code, i.e exiting early.

Implementing the original request across shells is possible but a bit of a rabbithole, as even with bash/zsh you need set -euo pipefail to get canonical behaviour across arbitrary scripts (with -u being opinionated but good practice to give people the semantics they normally expect), painful variations for csh and to my knowledge no equivalent of pipefail for POSIX shell just yet...

But yeah, could possibly just drop csh these days and allow opt-in for -euo pipefail on sh in case folks are using, for eg Alpine/Busybox shell.