backslash in between pipelines and pipeline name

[tonyzwei]

My Go server is running on Windows 2008. My Go agent is Linux redhat.
/var/lib/go-agent/pipelines\Check_ShellScript_Executor/d15675a0-35ba-46d3-b3a1-7eb69aa9c22f.sh

Do you have any quick fix? Thanks

[Diogomrol]

I am also having the same problem. Is there any breakthrough on this?

[srinivasupadhya]

fix is required here

[Diogomrol]

In fact, I think that the problem is on workingDirectory and not on that line. That line seems to be correct (and it has a correct behavior). The problem is that working directory contains something like "pipelines\PipelineName" instead of "pipelines/PipelineName", which is what causes the issue. As far as I was able to look (very quickly), workingDirectory is retrieved from Go in the plugin interaction, right?

Still, a quickfix might be just to replace '' occurences on workingDirectory to '/', if that does not cause some strange side effects. I can take a look at it

[arvindsv]

@Diogomrol: I think you're right. It looks like it's happening here, which calls this. WORKING_BASE_DIR is set to pipelines/ and the documentation of File#getPath says:

    /**
     * Converts this abstract pathname into a pathname string.  The resulting
     * string uses the {@link #separator default name-separator character} to
     * separate the names in the name sequence.
     *
     * @return  The string form of this abstract pathname
     */
    public String getPath() {
        return path;
    }

An addition to the test here might be a good approach which will fix it for everyone. Something which will force a forward slash there will work with all OSes.

[Diogomrol]

@arvindsv could you elaborate a little bit more on that? You mean that a test shall be created in order to "catch" that problem and then use TDD to fix it? :) Cause I'm thinking about working on that issue and wanted to get some pointers :)

[arvindsv]

I don't mind if it's properly TDDed or not, as long as the tests exist. My preference would be to TDD, but I can't "enforce" that from here. The PR looks, more or less, the same at the end. :)

Yes, I mean writing a little test and proving that the problem exists there and fixing it. If the test does not fail (and so, shows that the problem is not there), we can look at some other places to see what's going on.