unable to create a pull request from fork's fork

[dmach]

Description

• when I create org1/repo
• and I create org2
• and I fork org1/repo to org2/repo
• and I create org3
• and I fork org2/repo to org3/repo (I tried with a different name first, but it doesn't matter)

Then creating a pull request using API from org3/repo to org1/repo fails with {"message":"GetBaseRepo","url":"https://gitea.com/api/swagger","errors":null}

WebUI seems to be working fine.

Gitea Version

1.25.0~dev-623-ga4ccbc9291

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

https://demo.gitea.com/

Database

None

[dmach]

Reproducer (a bit verbose, generated by AI & fixed by hand):

#!/bin/sh

# --- CONFIGURATION ---
GITEA_URL="https://gitea.com"
# REPLACE WITH YOUR CREDENTIALS
USERNAME="<FIXME>"
TOKEN="<FIXME>"
# Organization and Repository Names (Randomized to avoid collision)
ORG1="org1-$RANDOM"
ORG2="org2-$RANDOM"
ORG3="org3-$RANDOM"
REPO_NAME="demo-repo"
REPO_FORK_NAME="demo-repo-another-name"
BRANCH_NAME="feature/new-content"
COMMIT_MESSAGE="Adding new test line via API"
# --- END CONFIGURATION ---

echo "--- START: Configuration Settings ---"
echo "URL: $GITEA_URL"
echo "ORG1: $ORG1"
echo "ORG2: $ORG2"
echo "ORG3: $ORG3"
echo "-----------------------------------"

# Function to check HTTP status code
check_status() {
    local status=$1
    local action=$2
    if [[ "$status" -ge 200 && "$status" -lt 300 ]]; then
        echo "✅ Success: $action"
    else
        echo "❌ ERROR ($status): $action"
        exit 1
    fi
}

# Function to create a Gitea Organization
create_org() {
    local org_name=$1
    local description=$2
    echo "### Creating organization $org_name"

    local RESPONSE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$GITEA_URL/api/v1/orgs" \
        -H "Authorization: token $TOKEN" \
        -H "Content-Type: application/json" \
        -d "{
            \"username\": \"$org_name\",
            \"description\": \"$description\"
        }")
    check_status $RESPONSE "Create $org_name"
}

# Function to create a repository within an organization
create_repo() {
    local org_name=$1
    local repo_name=$2
    echo "### Creating repository $org_name/$repo_name"

    local RESPONSE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$GITEA_URL/api/v1/orgs/$org_name/repos" \
        -H "Authorization: token $TOKEN" \
        -H "Content-Type: application/json" \
        -d "{
            \"name\": \"$repo_name\",
            \"private\": false
        }")
    check_status $RESPONSE "Create $org_name/$repo_name"
}

# Initializes a newly created repository by adding a README file.
initialize_repo() {
    local org_name=$1
    local repo_name=$2
    local main_branch="main" # Assuming 'main' is the default branch for new repos

    echo "### Initializing $org_name/$repo_name (Creating 'main' branch)"

    # Base64 encode the README content
    local readme_content_base64=$(echo "# $repo_name" | base64 -w 0)

    # API call to create the file, which initializes the repo and creates the default branch
    local RESPONSE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$GITEA_URL/api/v1/repos/$org_name/$repo_name/contents/README.md" \
        -H "Authorization: token $TOKEN" \
        -H "Content-Type: application/json" \
        -d "{
            \"content\": \"$readme_content_base64\",
            \"message\": \"Initial commit: Add README.md\",
            \"branch\": \"$main_branch\"
        }")
    check_status $RESPONSE "Initialize $org_name/$repo_name (Create README)"
}


# Function to fork a repository into a new organization
fork_repo() {
    local source_org=$1
    local source_repo=$2
    local target_org=$3
    local target_repo=$4 # Can be the same as source_repo or different

    echo "### Forking $source_org/$source_repo to $target_org/$target_repo"

    local RESPONSE=$(curl -s -o .message -w "%{http_code}" -X POST "$GITEA_URL/api/v1/repos/$source_org/$source_repo/forks" \
        -H "Authorization: token $TOKEN" \
        -H "Content-Type: application/json" \
        -d "{
            \"organization\": \"$target_org\",
            \"name\": \"$target_repo\"
        }")
    local HTTP_STATUS=$(echo "$RESPONSE" | tail -n 1 | awk '{print $NF}')
    check_status $RESPONSE "Fork $source_org/$source_repo to $target_org/$target_repo"

#    # Check if the fork request was successful (202 Accepted or 201 Created)
#    if [[ "$HTTP_STATUS" -ge 200 && "$HTTP_STATUS" -lt 300 ]]; then
#        echo "✅ Success: Fork operation started for $target_org/$target_repo"
#        sleep 5 # Wait for the asynchronous fork operation to complete
#    else
#        # Try to extract HTTP status from the curl output if it didn't use -o /dev/null
#        # Since we use -s, we check the actual response for errors.
#        local ERROR_MESSAGE=$(echo "$RESPONSE" | jq -r '.message' 2>/dev/null)
#        if [ -n "$ERROR_MESSAGE" ]; then
#             echo "❌ ERROR: Fork failed. Message: $ERROR_MESSAGE"
#        else
#             echo "❌ ERROR: Fork failed. Raw response: $RESPONSE"
#        fi
#        exit 1
#    fi
}

# --- EXECUTION ---

# 1. Setup ORG1 and the original repository
create_org $ORG1 "First organization and original repo"
create_repo $ORG1 $REPO_NAME
initialize_repo $ORG1 $REPO_NAME

# 2. Setup ORG2 and fork from ORG1
create_org $ORG2 "First level fork"
fork_repo $ORG1 $REPO_NAME $ORG2 $REPO_NAME

# 3. Setup ORG3 and fork from ORG2 (deep fork)
create_org $ORG3 "Second level (deep) fork"
fork_repo $ORG2 $REPO_NAME $ORG3 $REPO_FORK_NAME

# --- MAKING CHANGES ---

echo "--- Making Changes in $ORG3/$REPO_FORK_NAME ---"

# Get default branch and HEAD SHA
REPO_PATH="$ORG3/$REPO_FORK_NAME"
MAIN_BRANCH=$(curl -s -H "Authorization: token $TOKEN" "$GITEA_URL/api/v1/repos/$REPO_PATH" | jq -r '.default_branch')

if [ -z "$MAIN_BRANCH" ] || [ "$MAIN_BRANCH" == "null" ]; then
    echo "❌ ERROR: Could not determine default branch."
    exit 1
fi

SHA_INFO=$(curl -s -H "Authorization: token $TOKEN" "$GITEA_URL/api/v1/repos/$REPO_PATH/branches/$MAIN_BRANCH")
OLD_SHA=$(echo "$SHA_INFO" | jq -r '.commit.id')

if [ -z "$OLD_SHA" ] || [ "$OLD_SHA" == "null" ]; then
    echo "❌ ERROR: Could not get HEAD SHA for $MAIN_BRANCH. The repository might be empty. Please add a README first."
    exit 1
fi
echo "   > Default Branch: $MAIN_BRANCH, HEAD SHA: $OLD_SHA"

# Create new branch for the feature
echo "### Creating new branch $BRANCH_NAME"
RESPONSE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$GITEA_URL/api/v1/repos/$REPO_PATH/branches" \
    -H "Authorization: token $TOKEN" \
    -H "Content-Type: application/json" \
    -d "{
        \"new_branch_name\": \"$BRANCH_NAME\",
        \"old_branch_name\": \"$MAIN_BRANCH\"
    }")
check_status $RESPONSE "Create branch $BRANCH_NAME"

# Commit a new file to the feature branch
echo "### Committing change to $REPO_PATH/$BRANCH_NAME"
FILE_CONTENT_BASE64=$(echo "Hello, this is a change from ORG3. Time: $(date +%s)" | base64 -w 0)

RESPONSE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$GITEA_URL/api/v1/repos/$REPO_PATH/contents/testfile.txt" \
    -H "Authorization: token $TOKEN" \
    -H "Content-Type: application/json" \
    -d "{
        \"content\": \"$FILE_CONTENT_BASE64\",
        \"message\": \"$COMMIT_MESSAGE\",
        \"branch\": \"$BRANCH_NAME\"
    }")
check_status $RESPONSE "Create file testfile.txt"

# 4. Create Pull Request from ORG3 to ORG1
echo "--- Creating Pull Request from $ORG3/$REPO_FORK_NAME to $ORG1/$REPO_NAME ---"

# The target repo is ORG1/REPO_NAME (the URL path)
# The source is ORG3:BRANCH_NAME (the 'head' parameter)
PULL_RESPONSE=$(curl -s -X POST "$GITEA_URL/api/v1/repos/$ORG1/$REPO_NAME/pulls" \
    -H "Authorization: token $TOKEN" \
    -H "Content-Type: application/json" \
    -d "{
        \"title\": \"Deep Fork PR Test from ORG3\",
        \"body\": \"This PR validates the deep forking functionality.\",
        \"base\": \"$MAIN_BRANCH\",
        \"head\": \"$ORG3:$BRANCH_NAME\"
    }")

PR_ID=$(echo "$PULL_RESPONSE" | jq -r '.id')

if [[ -n "$PR_ID" && "$PR_ID" != "null" ]]; then
    echo "✅ Success: Pull Request (ID: $PR_ID) created."
    echo "   > Link: $GITEA_URL/$ORG2/$REPO_NAME/pulls/$PR_ID"
else
    echo "❌ ERROR: Failed to create Pull Request."
    echo "   > API Response: $PULL_RESPONSE"
    exit 1
fi

echo "--- SCRIPT COMPLETED ---"

# --- CLEANUP (OPTIONAL) ---
# Uncomment the following lines to automatically delete the created resources.
# echo "### Cleaning up (deleting repositories and organizations)..."
# curl -s -X DELETE "$GITEA_URL/api/v1/repos/$ORG3/$REPO_FORK_NAME" -H "Authorization: token $TOKEN"
# curl -s -X DELETE "$GITEA_URL/api/v1/repos/$ORG2/$REPO_NAME" -H "Authorization: token $TOKEN"
# curl -s -X DELETE "$GITEA_URL/api/v1/repos/$ORG1/$REPO_NAME" -H "Authorization: token $TOKEN"
# curl -s -X DELETE "$GITEA_URL/api/v1/orgs/$ORG3" -H "Authorization: token $TOKEN"
# curl -s -X DELETE "$GITEA_URL/api/v1/orgs/$ORG2" -H "Authorization: token $TOKEN"
# curl -s -X DELETE "$GITEA_URL/api/v1/orgs/$ORG1" -H "Authorization: token $TOKEN"
# echo "Cleanup finished."

[lunny]

The issue occurs when trying to identify the forked repository based on the owner name. The current logic only checks the direct parent or immediate fork, but it does not traverse deeper fork relationships.

As a temporary workaround, you can explicitly specify the forked repository name to avoid this limitation.