diff --git a/changelog.d/20260605_135304_aaschaer_remove_pinned.rst b/changelog.d/20260605_135304_aaschaer_remove_pinned.rst new file mode 100644 index 00000000..b5aa131a --- /dev/null +++ b/changelog.d/20260605_135304_aaschaer_remove_pinned.rst @@ -0,0 +1,4 @@ +Removed +------- + + - The ``pinned`` field was removed from the experimental ``BookmarkCreateDocument`` and ``BookmarkUpdateDocument`` classes to align with the API which does not support the field. diff --git a/src/globus_sdk/experimental/transfer_v2/data/bookmark_documents.py b/src/globus_sdk/experimental/transfer_v2/data/bookmark_documents.py index 15949bd0..105799b0 100644 --- a/src/globus_sdk/experimental/transfer_v2/data/bookmark_documents.py +++ b/src/globus_sdk/experimental/transfer_v2/data/bookmark_documents.py @@ -4,7 +4,6 @@ import typing as t import uuid -from globus_sdk._missing import MISSING, MissingType from globus_sdk._payload import GlobusPayload log = logging.getLogger(__name__) @@ -23,7 +22,6 @@ def __init__( name: str, path: str, *, - pinned: bool | MissingType = MISSING, additional_fields: dict[str, t.Any] | None = None, ) -> None: super().__init__() @@ -41,7 +39,6 @@ def __init__( attributes = { "name": name, "path": path, - "pinned": pinned, } if additional_fields is not None: @@ -66,7 +63,6 @@ def __init__( name: str, path: str, *, - pinned: bool | MissingType = MISSING, additional_fields: dict[str, t.Any] | None = None, ) -> None: super().__init__() @@ -75,7 +71,6 @@ def __init__( attributes = { "name": name, "path": path, - "pinned": pinned, } if additional_fields is not None: diff --git a/src/globus_sdk/testing/data/transfer/v2/create_bookmark.py b/src/globus_sdk/testing/data/transfer/v2/create_bookmark.py index bc6dc779..5acd9408 100644 --- a/src/globus_sdk/testing/data/transfer/v2/create_bookmark.py +++ b/src/globus_sdk/testing/data/transfer/v2/create_bookmark.py @@ -23,7 +23,6 @@ "attributes": { "name": _name, "path": _path, - "pinned": False, }, "relationships": { "collection": { diff --git a/src/globus_sdk/testing/data/transfer/v2/get_bookmark.py b/src/globus_sdk/testing/data/transfer/v2/get_bookmark.py index 9ad2aa08..88f2bcd5 100644 --- a/src/globus_sdk/testing/data/transfer/v2/get_bookmark.py +++ b/src/globus_sdk/testing/data/transfer/v2/get_bookmark.py @@ -19,7 +19,7 @@ "data": { "type": "Bookmark", "id": BOOKMARK_ID, - "attributes": {"name": _name, "path": _path, "pinned": True}, + "attributes": {"name": _name, "path": _path}, "relationships": { "collection": { "data": { diff --git a/src/globus_sdk/testing/data/transfer/v2/list_bookmarks.py b/src/globus_sdk/testing/data/transfer/v2/list_bookmarks.py index deddbdd5..5ef545ed 100644 --- a/src/globus_sdk/testing/data/transfer/v2/list_bookmarks.py +++ b/src/globus_sdk/testing/data/transfer/v2/list_bookmarks.py @@ -8,14 +8,12 @@ "collection_id": str(uuid.uuid4()), "name": "public datasets", "path": "/data_repository/public", - "pinned": True, }, { "bookmark_id": str(uuid.uuid4()), "collection_id": str(uuid.uuid4()), "name": "private datasets", "path": "/data_repository/private", - "pinned": False, }, ] @@ -32,7 +30,6 @@ "attributes": { "name": b["name"], "path": b["path"], - "pinned": b["pinned"], }, "relationships": { "collection": { diff --git a/src/globus_sdk/testing/data/transfer/v2/update_bookmark.py b/src/globus_sdk/testing/data/transfer/v2/update_bookmark.py index 62a81ebd..a858e2a3 100644 --- a/src/globus_sdk/testing/data/transfer/v2/update_bookmark.py +++ b/src/globus_sdk/testing/data/transfer/v2/update_bookmark.py @@ -7,7 +7,6 @@ _collection_id = str(uuid.uuid4()) _name = "private datasets" _path = "/data_repository/private" -_pinned = True RESPONSES = ResponseSet( @@ -24,7 +23,6 @@ "attributes": { "name": _name, "path": _path, - "pinned": _pinned, }, "relationships": { "collection": { @@ -41,7 +39,6 @@ "collection": _collection_id, "name": _name, "path": _path, - "pinned": _pinned, }, ) ) diff --git a/tests/functional/services/transfer/v2/test_list_bookmarks.py b/tests/functional/services/transfer/v2/test_list_bookmarks.py index 7e094875..de296d40 100644 --- a/tests/functional/services/transfer/v2/test_list_bookmarks.py +++ b/tests/functional/services/transfer/v2/test_list_bookmarks.py @@ -14,7 +14,6 @@ def test_list_bookmarks(client): assert bm["id"] == meta["bookmarks"][i]["bookmark_id"] assert bm["attributes"]["name"] == meta["bookmarks"][i]["name"] assert bm["attributes"]["path"] == meta["bookmarks"][i]["path"] - assert bm["attributes"]["pinned"] == meta["bookmarks"][i]["pinned"] assert ( bm["relationships"]["collection"]["data"]["id"] diff --git a/tests/functional/services/transfer/v2/test_update_bookmark.py b/tests/functional/services/transfer/v2/test_update_bookmark.py index 5f30d296..fb3ec413 100644 --- a/tests/functional/services/transfer/v2/test_update_bookmark.py +++ b/tests/functional/services/transfer/v2/test_update_bookmark.py @@ -10,7 +10,6 @@ def test_update_bookmark(client): data = BookmarkUpdateDocument( meta["name"], meta["path"], - pinned=meta["pinned"], ) res = client.update_bookmark(meta["bookmark_id"], data) @@ -25,4 +24,3 @@ def test_update_bookmark(client): sent = json.loads(req.body) assert sent["data"]["attributes"]["name"] == meta["name"] assert sent["data"]["attributes"]["path"] == meta["path"] - assert sent["data"]["attributes"]["pinned"] == meta["pinned"]